From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 00406C433F5 for ; Mon, 2 May 2022 06:48:16 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id A1FFD801CA; Mon, 2 May 2022 08:48:14 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1651474095; bh=O7t/MMks463A4YfEzJFBp8iJQcweaV0D7aXzMpNEc8k=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=BI5ndzkhhEwHQhW3slFWxDwWiJVBO8dVNPdrigpRPANOm6kUQjyigXQ1J4/O9359E owlQn2DOOHiQDXXOBrJPpd93EqBb1/8CnWCKs1u3KYl1PWzY0/mawV3KJTcMqSVQ9C Af35Mepi3l+F34QO/XX4HWtKKDOL6ov8qyFXF9dRvXdQ6O1Rdciux05KUTHNINfCCu DK5SYAKWfMhxChB/V8rI3IDOD+hX6mLlFpFuCXjl07jtbscNKnqtmG2WbDIZVB4zi5 0A1xxAYGhykE1l71z9Rk4zQDLdNzj62mFtInasGaKYJM+4hvMXg8UGNrVON+wNa2DF M6cNn8ifdiwKw== Received: by phobos.denx.de (Postfix, from userid 109) id CD091839BA; Mon, 2 May 2022 08:48:12 +0200 (CEST) Received: from mout-u-204.mailbox.org (mout-u-204.mailbox.org [IPv6:2001:67c:2050:101:465::204]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8BF768013A for ; Mon, 2 May 2022 08:48:10 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=sr@denx.de Received: from smtp2.mailbox.org (smtp2.mailbox.org [80.241.60.241]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-u-204.mailbox.org (Postfix) with ESMTPS id 4KsDF60wnmz9sRG; Mon, 2 May 2022 08:48:10 +0200 (CEST) Message-ID: Date: Mon, 2 May 2022 08:48:05 +0200 MIME-Version: 1.0 Subject: Re: [PATCH u-boot-marvell 01/19] net: mvneta: Get rid of platdata Content-Language: en-US To: =?UTF-8?Q?Marek_Beh=c3=ban?= Cc: Robert Marko , =?UTF-8?Q?Pali_Roh=c3=a1r?= , U-Boot-Denx , Ramon Fried , Joe Hershberger , =?UTF-8?Q?Marek_Beh=c3=ban?= References: <20220427104202.1205-1-kabel@kernel.org> <20220427104202.1205-2-kabel@kernel.org> From: Stefan Roese In-Reply-To: <20220427104202.1205-2-kabel@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 27.04.22 12:41, Marek Behún wrote: > From: Marek Behún > > Drop .of_to_plat() from the mvneta driver and parse the two properties > in .probe(). > > Signed-off-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stefan > --- > drivers/net/mvneta.c | 24 ++++-------------------- > 1 file changed, 4 insertions(+), 20 deletions(-) > > diff --git a/drivers/net/mvneta.c b/drivers/net/mvneta.c > index 15dc714058..d1c5f7930d 100644 > --- a/drivers/net/mvneta.c > +++ b/drivers/net/mvneta.c > @@ -1692,7 +1692,6 @@ static int mvneta_recv(struct udevice *dev, int flags, uchar **packetp) > > static int mvneta_probe(struct udevice *dev) > { > - struct eth_pdata *pdata = dev_get_plat(dev); > struct mvneta_port *pp = dev_get_priv(dev); > #if CONFIG_IS_ENABLED(DM_GPIO) > struct ofnode_phandle_args sfp_args; > @@ -1729,7 +1728,10 @@ static int mvneta_probe(struct udevice *dev) > buffer_loc.rx_buffers = (phys_addr_t)(bd_space + size); > } > > - pp->base = (void __iomem *)pdata->iobase; > + pp->base = dev_read_addr_ptr(dev); > + pp->phy_interface = dev_read_phy_mode(dev); > + if (pp->phy_interface == PHY_INTERFACE_MODE_NA) > + return -EINVAL; > > /* Configure MBUS address windows */ > if (device_is_compatible(dev, "marvell,armada-3700-neta")) > @@ -1737,9 +1739,6 @@ static int mvneta_probe(struct udevice *dev) > else > mvneta_conf_mbus_windows(pp); > > - /* PHY interface is already decoded in mvneta_of_to_plat() */ > - pp->phy_interface = pdata->phy_interface; > - > /* fetch 'fixed-link' property from 'neta' node */ > fl_node = fdt_subnode_offset(blob, node, "fixed-link"); > if (fl_node != -FDT_ERR_NOTFOUND) { > @@ -1808,20 +1807,6 @@ static const struct eth_ops mvneta_ops = { > .write_hwaddr = mvneta_write_hwaddr, > }; > > -static int mvneta_of_to_plat(struct udevice *dev) > -{ > - struct eth_pdata *pdata = dev_get_plat(dev); > - > - pdata->iobase = dev_read_addr(dev); > - > - /* Get phy-mode / phy_interface from DT */ > - pdata->phy_interface = dev_read_phy_mode(dev); > - if (pdata->phy_interface == PHY_INTERFACE_MODE_NA) > - return -EINVAL; > - > - return 0; > -} > - > static const struct udevice_id mvneta_ids[] = { > { .compatible = "marvell,armada-370-neta" }, > { .compatible = "marvell,armada-xp-neta" }, > @@ -1833,7 +1818,6 @@ U_BOOT_DRIVER(mvneta) = { > .name = "mvneta", > .id = UCLASS_ETH, > .of_match = mvneta_ids, > - .of_to_plat = mvneta_of_to_plat, > .probe = mvneta_probe, > .ops = &mvneta_ops, > .priv_auto = sizeof(struct mvneta_port), Viele Grüße, Stefan Roese -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de