From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michel Thierry Subject: Re: [PATCH 6/8] drm/i915/guc: Extract clients allocation to submission_init Date: Wed, 13 Dec 2017 11:10:44 -0800 Message-ID: References: <20171213125046.1735-1-michal.winiarski@intel.com> <20171213125046.1735-6-michal.winiarski@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 838EA6E0EA for ; Wed, 13 Dec 2017 19:10:45 +0000 (UTC) In-Reply-To: <20171213125046.1735-6-michal.winiarski@intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: =?UTF-8?Q?Micha=c5=82_Winiarski?= , "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org T24gMTMvMTIvMTcgMDQ6NTAsIE1pY2hhxYIgV2luaWFyc2tpIHdyb3RlOgo+IFdlIGNhbiBub3cg bW92ZSB0aGUgY2xpZW50cyBhbGxvY2F0aW9uIHRvIHN1Ym1pc3Npb25faW5pdCBwYXRoLCByYXRo ZXIKPiB0aGFuIGtlZXBpbmcgdGhlIGNvbmRpdGlvbiBpbnNpZGUgc3VibWlzc2lvbl9lbmFibGUg Y2FsbGVkIG9uIGV2ZXJ5Cj4gcmVzZXQuCj4gCj4gU2lnbmVkLW9mZi1ieTogTWljaGHFgiBXaW5p YXJza2kgPG1pY2hhbC53aW5pYXJza2lAaW50ZWwuY29tPgo+IENjOiBDaHJpcyBXaWxzb24gPGNo cmlzQGNocmlzLXdpbHNvbi5jby51az4KPiBDYzogSm9vbmFzIExhaHRpbmVuIDxqb29uYXMubGFo dGluZW5AbGludXguaW50ZWwuY29tPgo+IENjOiBNaWNoYWwgV2FqZGVjemtvIDxtaWNoYWwud2Fq ZGVjemtvQGludGVsLmNvbT4KPiAtLS0KClJldmlld2VkLWJ5OiBNaWNoZWwgVGhpZXJyeSA8bWlj aGVsLnRoaWVycnlAaW50ZWwuY29tPgoKPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1 Y19zdWJtaXNzaW9uLmMgfCAzMyArKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0tLQo+ICAgMSBm aWxlIGNoYW5nZWQsIDExIGluc2VydGlvbnMoKyksIDIyIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYg LS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ndWNfc3VibWlzc2lvbi5jIGIvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3VjX3N1Ym1pc3Npb24uYwo+IGluZGV4IGM3NGU3OGI2 YmE0MS4uNDg4MTEwNjAyZTdlIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2d1Y19zdWJtaXNzaW9uLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9n dWNfc3VibWlzc2lvbi5jCj4gQEAgLTExNDksNiArMTE0OSwxMCBAQCBpbnQgaW50ZWxfZ3VjX3N1 Ym1pc3Npb25faW5pdChzdHJ1Y3QgaW50ZWxfZ3VjICpndWMpCj4gICAgICAgICAgICAgICAgICBn b3RvIGVycl9sb2c7Cj4gICAgICAgICAgR0VNX0JVR19PTighZ3VjLT5hZHNfdm1hKTsKPiAKPiAr ICAgICAgIHJldCA9IGd1Y19jbGllbnRzX2NyZWF0ZShndWMpOwo+ICsgICAgICAgaWYgKHJldCkK PiArICAgICAgICAgICAgICAgcmV0dXJuIHJldDsKPiArCj4gICAgICAgICAgZm9yX2VhY2hfZW5n aW5lKGVuZ2luZSwgZGV2X3ByaXYsIGlkKSB7Cj4gICAgICAgICAgICAgICAgICBndWMtPnByZWVt cHRfd29ya1tpZF0uZW5naW5lID0gZW5naW5lOwo+ICAgICAgICAgICAgICAgICAgSU5JVF9XT1JL KCZndWMtPnByZWVtcHRfd29ya1tpZF0ud29yaywgaW5qZWN0X3ByZWVtcHRfY29udGV4dCk7Cj4g QEAgLTExNzIsNiArMTE3Niw3IEBAIHZvaWQgaW50ZWxfZ3VjX3N1Ym1pc3Npb25fZmluaShzdHJ1 Y3QgaW50ZWxfZ3VjICpndWMpCj4gICAgICAgICAgZm9yX2VhY2hfZW5naW5lKGVuZ2luZSwgZGV2 X3ByaXYsIGlkKQo+ICAgICAgICAgICAgICAgICAgY2FuY2VsX3dvcmtfc3luYygmZ3VjLT5wcmVl bXB0X3dvcmtbaWRdLndvcmspOwo+IAo+ICsgICAgICAgZ3VjX2NsaWVudHNfZGVzdHJveShndWMp Owo+ICAgICAgICAgIGd1Y19hZHNfZGVzdHJveShndWMpOwo+ICAgICAgICAgIGludGVsX2d1Y19s b2dfZGVzdHJveShndWMpOwo+ICAgICAgICAgIGd1Y19zdGFnZV9kZXNjX3Bvb2xfZGVzdHJveShn dWMpOwo+IEBAIC0xMjc3LDI4ICsxMjgyLDE4IEBAIGludCBpbnRlbF9ndWNfc3VibWlzc2lvbl9l bmFibGUoc3RydWN0IGludGVsX2d1YyAqZ3VjKQo+ICAgICAgICAgICAgICAgICAgICAgICBzaXpl b2Yoc3RydWN0IGd1Y193cV9pdGVtKSAqCj4gICAgICAgICAgICAgICAgICAgICAgIEk5MTVfTlVN X0VOR0lORVMgPiBHVUNfV1FfU0laRSk7Cj4gCj4gLSAgICAgICAvKgo+IC0gICAgICAgICogV2Un cmUgYmVpbmcgY2FsbGVkIG9uIGJvdGggbW9kdWxlIGluaXRpYWxpemF0aW9uIGFuZCBvbiByZXNl dCwKPiAtICAgICAgICAqIHVudGlsIHRoaXMgZmxvdyBpcyBjaGFuZ2VkLCB3ZSdyZSB1c2luZyBy ZWd1bGFyIGNsaWVudCBwcmVzZW5jZSB0bwo+IC0gICAgICAgICogZGV0ZXJtaW5lIHdoaWNoIGNh c2UgYXJlIHdlIGluLCBhbmQgd2hldGhlciB3ZSBzaG91bGQgYWxsb2NhdGUgbmV3Cj4gLSAgICAg ICAgKiBjbGllbnRzIG9yIGp1c3QgcmVzZXQgdGhlaXIgd29ya3F1ZXVlcy4KPiAtICAgICAgICAq Lwo+IC0gICAgICAgaWYgKCFndWMtPmV4ZWNidWZfY2xpZW50KSB7Cj4gLSAgICAgICAgICAgICAg IGVyciA9IGd1Y19jbGllbnRzX2NyZWF0ZShndWMpOwo+IC0gICAgICAgICAgICAgICBpZiAoZXJy KQo+IC0gICAgICAgICAgICAgICAgICAgICAgIHJldHVybiBlcnI7Cj4gLSAgICAgICB9IGVsc2Ug ewo+IC0gICAgICAgICAgICAgICBndWNfcmVzZXRfd3EoZ3VjLT5leGVjYnVmX2NsaWVudCk7Cj4g LSAgICAgICAgICAgICAgIGd1Y19yZXNldF93cShndWMtPnByZWVtcHRfY2xpZW50KTsKPiAtICAg ICAgIH0KPiArICAgICAgIEdFTV9CVUdfT04oIWd1Yy0+ZXhlY2J1Zl9jbGllbnQpOwo+ICsKPiAr ICAgICAgIGd1Y19yZXNldF93cShndWMtPmV4ZWNidWZfY2xpZW50KTsKPiArICAgICAgIGd1Y19y ZXNldF93cShndWMtPnByZWVtcHRfY2xpZW50KTsKPiAKPiAgICAgICAgICBlcnIgPSBpbnRlbF9n dWNfc2FtcGxlX2ZvcmNld2FrZShndWMpOwo+ICAgICAgICAgIGlmIChlcnIpCj4gLSAgICAgICAg ICAgICAgIGdvdG8gZXJyX2ZyZWVfY2xpZW50czsKPiArICAgICAgICAgICAgICAgcmV0dXJuIGVy cjsKPiAKPiAgICAgICAgICBlcnIgPSBndWNfY2xpZW50c19kb29yYmVsbF9pbml0KGd1Yyk7Cj4g ICAgICAgICAgaWYgKGVycikKPiAtICAgICAgICAgICAgICAgZ290byBlcnJfZnJlZV9jbGllbnRz Owo+ICsgICAgICAgICAgICAgICByZXR1cm4gZXJyOwo+IAo+ICAgICAgICAgIC8qIFRha2Ugb3Zl ciBmcm9tIG1hbnVhbCBjb250cm9sIG9mIEVMU1AgKGV4ZWNsaXN0cykgKi8KPiAgICAgICAgICBn dWNfaW50ZXJydXB0c19jYXB0dXJlKGRldl9wcml2KTsKPiBAQCAtMTMxNSwxMCArMTMxMCw2IEBA IGludCBpbnRlbF9ndWNfc3VibWlzc2lvbl9lbmFibGUoc3RydWN0IGludGVsX2d1YyAqZ3VjKQo+ ICAgICAgICAgIH0KPiAKPiAgICAgICAgICByZXR1cm4gMDsKPiAtCj4gLWVycl9mcmVlX2NsaWVu dHM6Cj4gLSAgICAgICBndWNfY2xpZW50c19kZXN0cm95KGd1Yyk7Cj4gLSAgICAgICByZXR1cm4g ZXJyOwo+ICAgfQo+IAo+ICAgdm9pZCBpbnRlbF9ndWNfc3VibWlzc2lvbl9kaXNhYmxlKHN0cnVj dCBpbnRlbF9ndWMgKmd1YykKPiBAQCAtMTMzMiw4ICsxMzIzLDYgQEAgdm9pZCBpbnRlbF9ndWNf c3VibWlzc2lvbl9kaXNhYmxlKHN0cnVjdCBpbnRlbF9ndWMgKmd1YykKPiAKPiAgICAgICAgICAv KiBSZXZlcnQgYmFjayB0byBtYW51YWwgRUxTUCBzdWJtaXNzaW9uICovCj4gICAgICAgICAgaW50 ZWxfZW5naW5lc19yZXNldF9kZWZhdWx0X3N1Ym1pc3Npb24oZGV2X3ByaXYpOwo+IC0KPiAtICAg ICAgIGd1Y19jbGllbnRzX2Rlc3Ryb3koZ3VjKTsKPiAgIH0KPiAKPiAgICNpZiBJU19FTkFCTEVE KENPTkZJR19EUk1fSTkxNV9TRUxGVEVTVCkKPiAtLQo+IDIuMTQuMwo+IAo+IF9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gSW50ZWwtZ2Z4IG1haWxpbmcg bGlzdAo+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwczovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo+IApfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0 CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK