From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Neil Horman <nhorman@tuxdriver.com>,
John McNamara <john.mcnamara@intel.com>,
Marko Kovacevic <marko.kovacevic@intel.com>
Cc: dev@dpdk.org, Thomas Monjalon <thomas@monjalon.net>,
Shahaf Shuler <shahafs@mellanox.com>
Subject: Re: [PATCH v3] doc: announce ethdev CRC strip flag deprecation
Date: Tue, 17 Apr 2018 14:36:17 +0100 [thread overview]
Message-ID: <dbdfc3c3-a6be-4558-b74c-be5f2729e739@intel.com> (raw)
In-Reply-To: <20180417131221.181117-1-ferruh.yigit@intel.com>
On 4/17/2018 2:12 PM, Ferruh Yigit wrote:
> Make CRC stripping default behavior, deprecate flag
> DEV_RX_OFFLOAD_CRC_STRIP.
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
> ---
> v2:
> * Make CRC behavior active in this release
>
> v3:
> * Distribute switch into next two releases for more smooth transition
> v18.08: add new flag to keep crc, and implement this in PMDs
> v18.11: remove crc strip flag and make default behavior to strip crc
> ---
> doc/guides/rel_notes/deprecation.rst | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index fd9def20c..3ee1bd05e 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -100,6 +100,26 @@ Deprecation Notices
> between the VF representor and the VF or the parent PF. Those new fields
> are to be included in ``rte_eth_dev_info`` struct.
>
> +* ethdev: A new offloading flag ``DEV_RX_OFFLOAD_KEEP_CRC`` will be added in v18.08,
> + This will replace the usage of not setting ``DEV_RX_OFFLOAD_CRC_STRIP`` flag
> + and will be implemented in PMDs accordingly.
> + In v18.08 both ``DEV_RX_OFFLOAD_KEEP_CRC`` and ``DEV_RX_OFFLOAD_CRC_STRIP`` flags
> + will be available, usage will be:
> + ``CRC_STRIP``: Strip CRC from packet
> + ``KEEP_CRC``: Keep CRC in packet
> + Both ``CRC_STRIP`` & ``KEEP_CRC``: Invalid
> + No flag: Keep CRC in packet
> +
> +* ethdev: In v18.11 ``DEV_RX_OFFLOAD_CRC_STRIP`` offload flag will be removed, default
> + behavior without any flag will be changed to CRC strip.
> + To keep CRC ``DEV_RX_OFFLOAD_KEEP_CRC`` flag is required.
> + ``KEEP_CRC``: Keep CRC in packet
> + No flag: Strip CRC from packet
> +
> +* ethdev: Make CRC stripping default behavior in v18.05 without any flag
> + and remove flag completely in v18.08
> + ``DEV_RX_OFFLOAD_CRC_STRIP`` flag will be removed.
> +
This last part is git artifact, I will send a new version to fix it.
> * i40e: The default flexible payload configuration which extracts the first 16
> bytes of the payload for RSS will be deprecated starting from 18.02. If
> required the previous behavior can be configured using existing flow
>
next prev parent reply other threads:[~2018-04-17 13:36 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-20 11:26 [PATCH] doc: announce ethdev CRC strip flag deprecation Ferruh Yigit
2018-03-20 11:35 ` Thomas Monjalon
2018-03-20 17:23 ` Ferruh Yigit
2018-03-21 19:47 ` [PATCH v2 1/2] " Ferruh Yigit
2018-03-21 19:47 ` [PATCH v2 2/2] ethdev: add new offload flag to keep CRC Ferruh Yigit
2018-03-21 21:05 ` Thomas Monjalon
2018-03-29 5:38 ` Shahaf Shuler
2018-03-29 7:43 ` Thomas Monjalon
2018-03-29 7:56 ` Shahaf Shuler
2018-03-29 13:32 ` Ferruh Yigit
2018-04-01 7:10 ` Shahaf Shuler
2018-04-16 17:23 ` Ferruh Yigit
2018-04-16 22:13 ` Thomas Monjalon
2018-04-17 13:12 ` [PATCH v3] doc: announce ethdev CRC strip flag deprecation Ferruh Yigit
2018-04-17 13:31 ` Andrew Rybchenko
2018-04-17 13:36 ` Ferruh Yigit [this message]
2018-04-17 13:39 ` [PATCH v4] " Ferruh Yigit
2018-04-17 13:47 ` Shahaf Shuler
2018-05-28 1:05 ` Thomas Monjalon
2018-08-01 15:27 ` Maxime Coquelin
2018-08-02 8:50 ` Shahaf Shuler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dbdfc3c3-a6be-4558-b74c-be5f2729e739@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=marko.kovacevic@intel.com \
--cc=nhorman@tuxdriver.com \
--cc=shahafs@mellanox.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.