From: "David Härdeman" <david@hardeman.nu>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org, jesse.barnes@intel.com
Subject: Re: [PATCH] i915: enable AVI infoframe for intel_hdmi.c [v2]
Date: Fri, 10 Sep 2010 10:13:15 +0200 (CEST) [thread overview]
Message-ID: <dbe67491bda26898271ac9691b6ff4da.squirrel@www.hardeman.nu> (raw)
In-Reply-To: <8u3s8d$jhdi8u@orsmga001.jf.intel.com>
On Thu, September 9, 2010 23:58, Chris Wilson wrote:
> On Thu, 09 Sep 2010 23:00:01 +0200, David Härdeman <david@hardeman.nu>
> wrote:
>> This is the second version which merges the infoframe code from
>> intel_hdmi.c and intel_sdvo.c, I hope this is something along the lines
>> Chris Wilson had in mind. Note that I'm assuming that the sdvo hardware
>> also stores a header ECC byte in the MSB of the first dword (haven't
>> found
>> any documentation for the sdvo).
>
> Pretty close. Using a callback function for writing the data is overkill,
> just call the common function to compute the avi csum, then pass the avi
> to the sdvo or hdmi handlers. It just makes following the logic that
> little bit easier.
>
> drm-intel-next has changed slightly since you wrote the patch, so can you
> respin it - just a couple of the macro names have changed to be
> consistent.
I'll respin the patch, but I still need to know if the intel_sdvo.c
hardware has an ECC byte as the MSB of the first dword or not.
--
David Härdeman
next prev parent reply other threads:[~2010-09-10 8:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-09 21:00 [PATCH] i915: enable AVI infoframe for intel_hdmi.c [v2] David Härdeman
2010-09-09 21:58 ` Chris Wilson
2010-09-10 8:13 ` David Härdeman [this message]
2010-09-20 22:01 ` David Härdeman
2010-09-21 8:02 ` Chris Wilson
2010-09-10 22:04 ` David Härdeman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dbe67491bda26898271ac9691b6ff4da.squirrel@www.hardeman.nu \
--to=david@hardeman.nu \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jesse.barnes@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.