From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vignesh R Date: Thu, 13 Apr 2017 09:54:06 +0530 Subject: [U-Boot] [PATCH 1/7] omap_hsmmc: update struct hsmmc to accommodate omap3 from DT In-Reply-To: <1492000720-11743-1-git-send-email-aford173@gmail.com> References: <1492000720-11743-1-git-send-email-aford173@gmail.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wednesday 12 April 2017 06:08 PM, Adam Ford wrote: > This patch fixes and issue where DM_MMC adds a 0x100 byte offset to the > base register. This is necessary for AM33xx, OMAP4+ and newer devices, but > it is not necessary for OMAP34XX boards. > > This patch will now only apply the x100 byte offset correction if DM_MMC > is enabled and the device is not OMAP34XX. > Although this is an easy solution, I think its better to handle this w/o ifdefs and instead using compatible string. See how omap3 base address is handled in Linux omap_hsmmc driver (drivers/mmc/host/omap_hsmmc.c). Also, please send rest of the series in reply to Patch 0/7, git send-email should automatically do that for you. > Fixes 11e1582506c6 ("omap_hsmmc: update struct hsmmc to accomodate > base address from DT") > > Signed-off-by: Adam Ford > > diff --git a/arch/arm/include/asm/omap_mmc.h b/arch/arm/include/asm/omap_mmc.h > index f2bf645..5b44c40 100644 > --- a/arch/arm/include/asm/omap_mmc.h > +++ b/arch/arm/include/asm/omap_mmc.h > @@ -26,7 +26,7 @@ > #define OMAP_MMC_H_ > > struct hsmmc { > -#ifdef CONFIG_DM_MMC > +#if defined(CONFIG_DM_MMC) && !defined(CONFIG_OMAP34XX) > unsigned char res0[0x100]; > #endif > unsigned char res1[0x10]; > -- Regards Vignesh