All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kaartic Sivaraam <kaartic.sivaraam@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: What's cooking in git.git (Dec 2017, #03; Wed, 13)
Date: Sat, 16 Dec 2017 11:36:30 +0530	[thread overview]
Message-ID: <dbed9ef3-0bf6-01e2-13d2-4c92a243c321@gmail.com> (raw)
In-Reply-To: <xmqq1sjxt3tz.fsf@gitster.mtv.corp.google.com>

On Friday 15 December 2017 02:38 AM, Junio C Hamano wrote:
> Junio C Hamano <gitster@pobox.com> writes:
> 
>> I think you only sent 3/3 in newer rounds, which made it not to
>> apply to my tree.  If you meant to drop changes in 1/3 and 2/3,
>> perhaps because they were needless churn, then 3/3 needs to be
>> updated not to depend on the changes these two made.
> 
> Here is what I reconstructed to suit my taste better ;-)
> 

Looks good to me except that your v4 3/3 seems to be spawning a subshell 
is an oversight, I guess? Also, I guess it would be better if there was 
comment in the code saying 'branch_nam' might hold a commit/branch name. 
No worries I'll send a v5 to that thread based on your v4.

Thanks,
Kaartic

  reply	other threads:[~2017-12-16  6:06 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-13 23:00 What's cooking in git.git (Dec 2017, #03; Wed, 13) Junio C Hamano
2017-12-14 12:37 ` Kaartic Sivaraam
2017-12-14 17:20   ` Junio C Hamano
2017-12-14 21:08     ` Junio C Hamano
2017-12-16  6:06       ` Kaartic Sivaraam [this message]
2017-12-14 21:09     ` [PATCH v4 2/3] rebase: distinguish user input by quoting it Junio C Hamano
2017-12-14 21:09     ` [PATCH v4 3/3] rebase: rebasing can also be done when HEAD is detached Junio C Hamano
2017-12-15 15:29     ` What's cooking in git.git (Dec 2017, #03; Wed, 13) Kaartic Sivaraam
2017-12-14 17:41 ` Ævar Arnfjörð Bjarmason
2017-12-14 21:04 ` Jonathan Nieder
2017-12-14 21:06   ` Junio C Hamano
2017-12-14 21:26     ` Jonathan Nieder
2017-12-15 12:39 ` Johannes Schindelin
2018-01-09 12:59 ` Lars Schneider
2018-01-09 18:59   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dbed9ef3-0bf6-01e2-13d2-4c92a243c321@gmail.com \
    --to=kaartic.sivaraam@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.