All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heinrich Schuchardt <xypron.glpk@gmx.de>
To: u-boot@lists.denx.de
Subject: [PATCH v4 0/7] usb: kbd: implement special keys
Date: Fri, 27 Dec 2019 19:21:23 +0100	[thread overview]
Message-ID: <dbf0f62d-ba22-84ec-2e9f-2cd598e6db58@gmx.de> (raw)
In-Reply-To: <CAPnjgZ0M2oA2ToYicZ4zuH8oG3_i6AMGj0OELGA4yR3shw8GyA@mail.gmail.com>

On 12/27/19 5:41 PM, Simon Glass wrote:
> Hi,
>
> On Sat, 23 Nov 2019 at 13:05, Marek Vasut <marex@denx.de> wrote:
>>
>> On 11/23/19 6:15 PM, Heinrich Schuchardt wrote:
>>> GRUB uses function keys. So we should support these with an USB keyboard.
>>> Provide support for F1-F12, Insert, Delete, Home, End, Page Up, Page Down.
>>> Simplify the code beforehand.
>>>
>>> Enhance the keyboard unit test.
>>>
>>> In total I could not see any increase of u-boot.img on the TBS2910 but
>>> as the special keys are only needed in the context of the UEFI subsystem
>>> it makes sense to save several hundred bytes on other boards.
>>
>> Applied all to usb/next, thanks, so let's see what CI has to say.
>
> I notice that pressing F1 at the prompt now shows P and then pressing
> backspace a few times makes a bit of a mess. If U-Boot itself doesn't
> understand these keys, could they be ignored?

Hello Simon,

Thanks for reporting your test results. Could you, please, describe your
scenario in detail.

Was USB_KEYBOARD_FN_KEYS enabled?
Which output device did you use?

Best regards

Heinrich

  reply	other threads:[~2019-12-27 18:21 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-23 17:15 [U-Boot] [PATCH v4 0/7] usb: kbd: implement special keys Heinrich Schuchardt
2019-11-23 17:15 ` [U-Boot] [PATCH v4 1/7] usb: kbd: fix typo Heinrich Schuchardt
2019-11-23 17:15 ` [U-Boot] [PATCH v4 2/7] usb: kbd: signature of usb_kbd_put_queue() Heinrich Schuchardt
2019-11-23 17:15 ` [U-Boot] [PATCH v4 3/7] usb: kbd: simplify coding for arrow keys Heinrich Schuchardt
2019-11-23 17:15 ` [U-Boot] [PATCH v4 4/7] usb: kbd: implement special keys Heinrich Schuchardt
2019-11-23 17:15 ` [U-Boot] [PATCH v4 5/7] usb: kbd: move USB_KBD_BOOT_REPORT_SIZE to usb.h Heinrich Schuchardt
2019-11-23 17:15 ` [U-Boot] [PATCH v4 6/7] dm: test: usb: rework keyboard test Heinrich Schuchardt
2019-11-23 17:15 ` [U-Boot] [PATCH v4 7/7] sandbox: enable USB_KEYBOARD_FN_KEYS Heinrich Schuchardt
2019-11-23 19:15 ` [U-Boot] [PATCH v4 0/7] usb: kbd: implement special keys Marek Vasut
2019-12-27 16:41   ` Simon Glass
2019-12-27 18:21     ` Heinrich Schuchardt [this message]
2019-12-28  2:26       ` Simon Glass
2019-12-28  4:54         ` Heinrich Schuchardt
2019-12-30  1:21           ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dbf0f62d-ba22-84ec-2e9f-2cd598e6db58@gmx.de \
    --to=xypron.glpk@gmx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.