From: Marian Cichy <mci@pengutronix.de>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Andrew Lunn" <andrew@lunn.ch>
Cc: netdev@vger.kernel.org, Fugang Duan <fugang.duan@nxp.com>,
"David S. Miller" <davem@davemloft.net>,
kernel@pengutronix.de
Subject: Re: [PATCH] net: ethernet: fec: Clear stale flag in IEVENT register before MII transfers
Date: Fri, 11 Dec 2020 16:19:48 +0100 [thread overview]
Message-ID: <dbf9184d-adb2-6377-414b-0593ecb89149@pengutronix.de> (raw)
In-Reply-To: <20201209165148.6kbntgmjopymomx5@pengutronix.de>
On 12/9/20 5:51 PM, Uwe Kleine-König wrote:
> Hi Andrew,
>
> On Wed, Dec 09, 2020 at 03:44:13PM +0100, Andrew Lunn wrote:
>> On Wed, Dec 09, 2020 at 11:29:59AM +0100, Uwe Kleine-König wrote:
>> Do you have
>>
>> ommit 1e6114f51f9d4090390fcec2f5d67d8cc8dc4bfc
>> Author: Greg Ungerer <gerg@linux-m68k.org>
>> Date: Wed Oct 28 15:22:32 2020 +1000
>>
>> net: fec: fix MDIO probing for some FEC hardware blocks
>>
>> Some (apparently older) versions of the FEC hardware block do not like
>> the MMFR register being cleared to avoid generation of MII events at
>> initialization time. The action of clearing this register results in no
>> future MII events being generated at all on the problem block. This means
>> the probing of the MDIO bus will find no PHYs.
>>
>> Create a quirk that can be checked at the FECs MII init time so that
>> the right thing is done. The quirk is set as appropriate for the FEC
>> hardware blocks that are known to need this.
>>
>> in your tree?
> Unless I did something wrong I also saw the failure with v5.10-rc$latest
> earlier today.
>
> ... some time later ...
>
> Argh, I checked my git reflog and the newest release I tested was
> 5.9-rc8.
>
> I wonder if my patch is a simpler and more straight forward fix for the
> problem however, but that might also be because I don't understand the
> comment touched by 1e6114f51f9d4090390fcec2f5d67d8cc8dc4bfc without
> checking the reference manual (which I didn't).
>
> @Marian: As it's you who has to work on this i.MX25 machine, can you
> maybe test if using a kernel > 5.10-rc3 (or cherry-picking
> 1e6114f51f9d4090390fcec2f5d67d8cc8dc4bfc) fixes the problem for you?
Tested it on 5.10-rc7 and the problem is fixed without your previous patch.
Best regards,
Marian
>
> Best regards
> Uwe
>
next prev parent reply other threads:[~2020-12-11 16:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-09 10:29 [PATCH] net: ethernet: fec: Clear stale flag in IEVENT register before MII transfers Uwe Kleine-König
2020-12-09 14:32 ` Andrew Lunn
2020-12-09 14:44 ` Andrew Lunn
2020-12-09 16:51 ` Uwe Kleine-König
2020-12-11 15:19 ` Marian Cichy [this message]
2020-12-11 15:55 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dbf9184d-adb2-6377-414b-0593ecb89149@pengutronix.de \
--to=mci@pengutronix.de \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=fugang.duan@nxp.com \
--cc=kernel@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.