From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77F3BC433DB for ; Tue, 5 Jan 2021 09:33:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2164B2222A for ; Tue, 5 Jan 2021 09:33:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728135AbhAEJcu convert rfc822-to-8bit (ORCPT ); Tue, 5 Jan 2021 04:32:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38752 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728123AbhAEJcu (ORCPT ); Tue, 5 Jan 2021 04:32:50 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9CE8DC061574 for ; Tue, 5 Jan 2021 01:32:09 -0800 (PST) Received: from lupine.hi.pengutronix.de ([2001:67c:670:100:3ad5:47ff:feaf:1a17] helo=lupine) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kwihB-000798-37; Tue, 05 Jan 2021 10:32:05 +0100 Received: from pza by lupine with local (Exim 4.92) (envelope-from ) id 1kwih7-0003N2-G6; Tue, 05 Jan 2021 10:32:01 +0100 Message-ID: Subject: Re: [PATCH v2 3/6] dt-bindings: display: imx: hdmi: Convert binding to YAML From: Philipp Zabel To: Laurent Pinchart Cc: Laurent Pinchart , dri-devel@lists.freedesktop.org, Rob Herring , Sandy Huang , linux-renesas-soc@vger.kernel.org, Chen-Yu Tsai , Maxime Ripard , Mark Yao Date: Tue, 05 Jan 2021 10:32:01 +0100 In-Reply-To: References: <20201220195005.26438-1-laurent.pinchart+renesas@ideasonboard.com> <20201220195005.26438-4-laurent.pinchart+renesas@ideasonboard.com> <810947ea1a18e06db1f36a4a8013fbca17e0ea89.camel@pengutronix.de> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:1a17 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-renesas-soc@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org On Tue, 2021-01-05 at 07:49 +0200, Laurent Pinchart wrote: > Hi Philipp, > > On Mon, Jan 04, 2021 at 04:30:36PM +0100, Philipp Zabel wrote: > > On Sun, 2020-12-20 at 21:50 +0200, Laurent Pinchart wrote: > > > Convert the i.MX6 HDMI TX text binding to YAML. > > > > > > Signed-off-by: Laurent Pinchart > > > --- > > > Changes since v1: > > > > > > - Only specify maxItems for clocks > > > - Drop reg and interrupts as they're checked in the base schema > > > - Rebase on top of OF graph schema, dropped redundant properties > > > - Fix identation for enum entries > > > - Drop clock-names items, use maxItems only > > > --- > > > .../bindings/display/imx/fsl,imx6-hdmi.yaml | 130 ++++++++++++++++++ > > > .../devicetree/bindings/display/imx/hdmi.txt | 65 --------- > > > 2 files changed, 130 insertions(+), 65 deletions(-) > > > create mode 100644 Documentation/devicetree/bindings/display/imx/fsl,imx6-hdmi.yaml > > > delete mode 100644 Documentation/devicetree/bindings/display/imx/hdmi.txt > > > > > > diff --git a/Documentation/devicetree/bindings/display/imx/fsl,imx6-hdmi.yaml b/Documentation/devicetree/bindings/display/imx/fsl,imx6-hdmi.yaml > > > new file mode 100644 > > > index 000000000000..f9b131bb3339 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/display/imx/fsl,imx6-hdmi.yaml > > > @@ -0,0 +1,130 @@ > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/display/imx/fsl,imx6-hdmi.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: Freescale i.MX6 DWC HDMI TX Encoder > > > + > > > +maintainers: > > > + - Philipp Zabel > > > + > > > +description: | > > > + The HDMI transmitter is a Synopsys DesignWare HDMI 1.4 TX controller IP > > > + with a companion PHY IP. > > > + > > > +allOf: > > > + - $ref: ../bridge/synopsys,dw-hdmi.yaml# > > > + > > > +properties: > > > + compatible: > > > + enum: > > > + - fsl,imx6dl-hdmi > > > + - fsl,imx6q-hdmi > > > + > > > + reg-io-width: > > > + const: 1 > > > + > > > + clocks: > > > + maxItems: 2 > > > + > > > + clock-names: > > > + maxItems: 2 > > > + > > > + ddc-i2c-bus: > > > + $ref: /schemas/types.yaml#/definitions/phandle > > > + description: > > > + The HDMI DDC bus can be connected to either a system I2C master or the > > > + functionally-reduced I2C master contained in the DWC HDMI. When connected > > > + to a system I2C master this property contains a phandle to that I2C > > > + master controller. > > > + > > > + gpr: > > > + $ref: /schemas/types.yaml#/definitions/phandle > > > + description: > > > + phandle to the iomuxc-gpr region containing the HDMI multiplexer control > > > + register. > > > + > > > + ports: > > > + $ref: /schemas/graph.yaml#/properties/ports > > > + description: | > > > + This device has four video ports, corresponding to the four inputs of the > > > + HDMI multiplexer. Each port shall have a single endpoint. > > > + > > > + properties: > > > + port@0: > > > + $ref: /schemas/graph.yaml#/$defs/port-base > > > + unevaluatedProperties: false > > > + description: First input of the HDMI multiplexer > > > + > > > + port@1: > > > + $ref: /schemas/graph.yaml#/$defs/port-base > > > + unevaluatedProperties: false > > > + description: Second input of the HDMI multiplexer > > > + > > > + port@2: > > > + $ref: /schemas/graph.yaml#/$defs/port-base > > > + unevaluatedProperties: false > > > + description: Third input of the HDMI multiplexer > > > + > > > + port@3: > > > + $ref: /schemas/graph.yaml#/$defs/port-base > > > + unevaluatedProperties: false > > > + description: Fourth input of the HDMI multiplexer > > > + > > > + anyOf: > > > + - required: > > > + - port@0 > > > + - required: > > > + - port@1 > > > + - required: > > > + - port@2 > > > + - required: > > > + - port@3 > > > + > > > +required: > > > + - compatible > > > + - reg > > > + - clocks > > > + - clock-names > > > + - gpr > > > + - interrupts > > > + - ports The binding marks the "ports" container node as required. > > Won't this break validation of current i.MX6 DTs, which don't use the > > ports node (in imx6q(dl).dtsi)? > > I may be missing something, but in imx6qdl.dtsi, we have [...] > and in imx6q.dtsi, > > &hdmi { > compatible = "fsl,imx6q-hdmi"; > > port@2 { > reg = <2>; > > hdmi_mux_2: endpoint { > remote-endpoint = <&ipu2_di0_hdmi>; > }; > }; > > port@3 { > reg = <3>; > > hdmi_mux_3: endpoint { > remote-endpoint = <&ipu2_di1_hdmi>; > }; > }; > }; > > There are no other occurrences of "fsl,imx6q-hdmi" than in imx6q.dtsi > (and no occurrences of "fsl,imx6qdl-hdmi" at all). The port@[0-3] nodes are currently direct children of the &hdmi node, without the "ports" container node. regards Philipp From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FF0FC433DB for ; Tue, 5 Jan 2021 09:32:11 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F266D20756 for ; Tue, 5 Jan 2021 09:32:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F266D20756 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E9C396E0AF; Tue, 5 Jan 2021 09:32:09 +0000 (UTC) Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1C6246E0AF for ; Tue, 5 Jan 2021 09:32:08 +0000 (UTC) Received: from lupine.hi.pengutronix.de ([2001:67c:670:100:3ad5:47ff:feaf:1a17] helo=lupine) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kwihB-000798-37; Tue, 05 Jan 2021 10:32:05 +0100 Received: from pza by lupine with local (Exim 4.92) (envelope-from ) id 1kwih7-0003N2-G6; Tue, 05 Jan 2021 10:32:01 +0100 Message-ID: Subject: Re: [PATCH v2 3/6] dt-bindings: display: imx: hdmi: Convert binding to YAML From: Philipp Zabel To: Laurent Pinchart Date: Tue, 05 Jan 2021 10:32:01 +0100 In-Reply-To: References: <20201220195005.26438-1-laurent.pinchart+renesas@ideasonboard.com> <20201220195005.26438-4-laurent.pinchart+renesas@ideasonboard.com> <810947ea1a18e06db1f36a4a8013fbca17e0ea89.camel@pengutronix.de> User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:1a17 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: dri-devel@lists.freedesktop.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Pinchart , Sandy Huang , dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, Chen-Yu Tsai , Rob Herring , Maxime Ripard , Mark Yao Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, 2021-01-05 at 07:49 +0200, Laurent Pinchart wrote: > Hi Philipp, > > On Mon, Jan 04, 2021 at 04:30:36PM +0100, Philipp Zabel wrote: > > On Sun, 2020-12-20 at 21:50 +0200, Laurent Pinchart wrote: > > > Convert the i.MX6 HDMI TX text binding to YAML. > > > > > > Signed-off-by: Laurent Pinchart > > > --- > > > Changes since v1: > > > > > > - Only specify maxItems for clocks > > > - Drop reg and interrupts as they're checked in the base schema > > > - Rebase on top of OF graph schema, dropped redundant properties > > > - Fix identation for enum entries > > > - Drop clock-names items, use maxItems only > > > --- > > > .../bindings/display/imx/fsl,imx6-hdmi.yaml | 130 ++++++++++++++++++ > > > .../devicetree/bindings/display/imx/hdmi.txt | 65 --------- > > > 2 files changed, 130 insertions(+), 65 deletions(-) > > > create mode 100644 Documentation/devicetree/bindings/display/imx/fsl,imx6-hdmi.yaml > > > delete mode 100644 Documentation/devicetree/bindings/display/imx/hdmi.txt > > > > > > diff --git a/Documentation/devicetree/bindings/display/imx/fsl,imx6-hdmi.yaml b/Documentation/devicetree/bindings/display/imx/fsl,imx6-hdmi.yaml > > > new file mode 100644 > > > index 000000000000..f9b131bb3339 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/display/imx/fsl,imx6-hdmi.yaml > > > @@ -0,0 +1,130 @@ > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/display/imx/fsl,imx6-hdmi.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: Freescale i.MX6 DWC HDMI TX Encoder > > > + > > > +maintainers: > > > + - Philipp Zabel > > > + > > > +description: | > > > + The HDMI transmitter is a Synopsys DesignWare HDMI 1.4 TX controller IP > > > + with a companion PHY IP. > > > + > > > +allOf: > > > + - $ref: ../bridge/synopsys,dw-hdmi.yaml# > > > + > > > +properties: > > > + compatible: > > > + enum: > > > + - fsl,imx6dl-hdmi > > > + - fsl,imx6q-hdmi > > > + > > > + reg-io-width: > > > + const: 1 > > > + > > > + clocks: > > > + maxItems: 2 > > > + > > > + clock-names: > > > + maxItems: 2 > > > + > > > + ddc-i2c-bus: > > > + $ref: /schemas/types.yaml#/definitions/phandle > > > + description: > > > + The HDMI DDC bus can be connected to either a system I2C master or the > > > + functionally-reduced I2C master contained in the DWC HDMI. When connected > > > + to a system I2C master this property contains a phandle to that I2C > > > + master controller. > > > + > > > + gpr: > > > + $ref: /schemas/types.yaml#/definitions/phandle > > > + description: > > > + phandle to the iomuxc-gpr region containing the HDMI multiplexer control > > > + register. > > > + > > > + ports: > > > + $ref: /schemas/graph.yaml#/properties/ports > > > + description: | > > > + This device has four video ports, corresponding to the four inputs of the > > > + HDMI multiplexer. Each port shall have a single endpoint. > > > + > > > + properties: > > > + port@0: > > > + $ref: /schemas/graph.yaml#/$defs/port-base > > > + unevaluatedProperties: false > > > + description: First input of the HDMI multiplexer > > > + > > > + port@1: > > > + $ref: /schemas/graph.yaml#/$defs/port-base > > > + unevaluatedProperties: false > > > + description: Second input of the HDMI multiplexer > > > + > > > + port@2: > > > + $ref: /schemas/graph.yaml#/$defs/port-base > > > + unevaluatedProperties: false > > > + description: Third input of the HDMI multiplexer > > > + > > > + port@3: > > > + $ref: /schemas/graph.yaml#/$defs/port-base > > > + unevaluatedProperties: false > > > + description: Fourth input of the HDMI multiplexer > > > + > > > + anyOf: > > > + - required: > > > + - port@0 > > > + - required: > > > + - port@1 > > > + - required: > > > + - port@2 > > > + - required: > > > + - port@3 > > > + > > > +required: > > > + - compatible > > > + - reg > > > + - clocks > > > + - clock-names > > > + - gpr > > > + - interrupts > > > + - ports The binding marks the "ports" container node as required. > > Won't this break validation of current i.MX6 DTs, which don't use the > > ports node (in imx6q(dl).dtsi)? > > I may be missing something, but in imx6qdl.dtsi, we have [...] > and in imx6q.dtsi, > > &hdmi { > compatible = "fsl,imx6q-hdmi"; > > port@2 { > reg = <2>; > > hdmi_mux_2: endpoint { > remote-endpoint = <&ipu2_di0_hdmi>; > }; > }; > > port@3 { > reg = <3>; > > hdmi_mux_3: endpoint { > remote-endpoint = <&ipu2_di1_hdmi>; > }; > }; > }; > > There are no other occurrences of "fsl,imx6q-hdmi" than in imx6q.dtsi > (and no occurrences of "fsl,imx6qdl-hdmi" at all). The port@[0-3] nodes are currently direct children of the &hdmi node, without the "ports" container node. regards Philipp _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel