From: poma <pomidorabelisima@gmail.com>
To: Philippe Reynes <tremyfr@gmail.com>,
oliver@neukum.org, jacmet@sunsite.dk,
steve.glendinning@shawell.net, UNGLinuxDriver@microchip.com,
gregkh@linuxfoundation.org, davem@davemloft.net,
robert.foss@collabora.com, allan@asix.com.tw,
grundler@google.com, jarod@redhat.com, peter.chen@nxp.com,
stefan.bruens@rwth-aachen.de, akpm@linux-foundation.org,
adobriyan@gmail.com
Cc: linux-usb@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 06/11] net: usb: mcs7830: use new api ethtool_{get|set}_link_ksettings
Date: Tue, 21 Mar 2017 15:36:20 +0100 [thread overview]
Message-ID: <dc26076e-7ef5-17f1-33c9-fabcb84dd66d@gmail.com> (raw)
In-Reply-To: <1489702737-2401-7-git-send-email-tremyfr@gmail.com>
On 16.03.2017 23:18, Philippe Reynes wrote:
> The ethtool api {get|set}_settings is deprecated.
> We move this driver to new api {get|set}_link_ksettings.
>
> As I don't have the hardware, I'd be very pleased if
> someone may test this patch.
>
> Signed-off-by: Philippe Reynes <tremyfr@gmail.com>
> ---
> drivers/net/usb/mcs7830.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/usb/mcs7830.c b/drivers/net/usb/mcs7830.c
> index 4f345bd..5771ff2 100644
> --- a/drivers/net/usb/mcs7830.c
> +++ b/drivers/net/usb/mcs7830.c
> @@ -464,9 +464,9 @@ static void mcs7830_get_regs(struct net_device *net, struct ethtool_regs *regs,
> .get_link = usbnet_get_link,
> .get_msglevel = usbnet_get_msglevel,
> .set_msglevel = usbnet_set_msglevel,
> - .get_settings = usbnet_get_settings,
> - .set_settings = usbnet_set_settings,
> .nway_reset = usbnet_nway_reset,
> + .get_link_ksettings = usbnet_get_link_ksettings,
> + .set_link_ksettings = usbnet_set_link_ksettings,
> };
>
> static const struct net_device_ops mcs7830_netdev_ops = {
>
$ modinfo mcs7830 usbnet mii -n
/lib/modules/4.11.0-0.rc3.git0.1.fc26.x86_64/updates/mcs7830.ko
/lib/modules/4.11.0-0.rc3.git0.1.fc26.x86_64/updates/usbnet.ko
/lib/modules/4.11.0-0.rc3.git0.1.fc26.x86_64/updates/mii.ko
$ lsmod | grep mcs7830
mcs7830 16384 0
usbnet 45056 1 mcs7830
mii 16384 2 usbnet,mcs7830
$ nmcli -f GENERAL.DRIVER,GENERAL.STATE device show enp0s4f1u4
GENERAL.DRIVER: MOSCHIP usb-ethernet driver
GENERAL.STATE: 100 (connected)
Tested-by: poma <poma@gmail.com>
next prev parent reply other threads:[~2017-03-21 15:06 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-16 22:18 [PATCH 00/11] net: usbnet: move to new api ethtool_{get|set}_link_ksettings Philippe Reynes
2017-03-16 22:18 ` [PATCH 01/11] net: usb: usbnet: add " Philippe Reynes
2017-03-20 6:39 ` Oliver Neukum
2017-03-21 11:33 ` Oliver Neukum
2017-03-21 23:03 ` David Miller
2017-03-16 22:18 ` [PATCH 02/11] net: usb: smsc95xx: use " Philippe Reynes
2017-03-16 22:18 ` [PATCH 03/11] net: usb: sr9800: " Philippe Reynes
2017-03-16 22:18 ` [PATCH 04/11] net: usb: cdc_ncm: " Philippe Reynes
2017-03-16 22:18 ` Philippe Reynes
2017-03-16 22:18 ` [PATCH 05/11] net: usb: dm9601: " Philippe Reynes
2017-03-16 22:18 ` [PATCH 06/11] net: usb: mcs7830: " Philippe Reynes
2017-03-21 14:36 ` poma [this message]
2017-03-16 22:18 ` [PATCH 07/11] net: usb: sierra_net: " Philippe Reynes
2017-03-16 22:18 ` [PATCH 08/11] net: usb: smsc75xx: " Philippe Reynes
2017-03-16 22:18 ` [PATCH 09/11] net: usb: sr9700: " Philippe Reynes
2017-03-16 22:18 ` [PATCH 10/11] net: usb: asix: " Philippe Reynes
2017-03-16 22:18 ` [PATCH 11/11] net: usb: usb: remove old api ethtool_{get|set}_settings Philippe Reynes
2017-03-20 6:40 ` Oliver Neukum
2017-03-20 6:40 ` Oliver Neukum
2017-03-21 23:04 ` [PATCH 00/11] net: usbnet: move to new api ethtool_{get|set}_link_ksettings David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc26076e-7ef5-17f1-33c9-fabcb84dd66d@gmail.com \
--to=pomidorabelisima@gmail.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=allan@asix.com.tw \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=grundler@google.com \
--cc=jacmet@sunsite.dk \
--cc=jarod@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oliver@neukum.org \
--cc=peter.chen@nxp.com \
--cc=robert.foss@collabora.com \
--cc=stefan.bruens@rwth-aachen.de \
--cc=steve.glendinning@shawell.net \
--cc=tremyfr@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.