All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Mahoney <jeffm@suse.com>
To: "Luis R. Chamberlain" <mcgrof@kernel.org>
Cc: Amir Goldstein <amir73il@gmail.com>,
	Linux FS Devel <linux-fsdevel@vger.kernel.org>,
	xfs <linux-xfs@vger.kernel.org>,
	fstests <fstests@vger.kernel.org>,
	Sasha Levin <Alexander.Levin@microsoft.com>,
	Sasha Levin <levinsasha928@gmail.com>,
	Valentin Rothberg <valentinrothberg@gmail.com>
Subject: Re: [ANN] oscheck: wrapper for fstests check.sh - tracking and working with baselines
Date: Fri, 13 Jul 2018 17:03:56 -0400	[thread overview]
Message-ID: <dc2c2b79-6124-4673-301b-47429b29119e@suse.com> (raw)
In-Reply-To: <20180713205038.GB3620@garbanzo.do-not-panic.com>


[-- Attachment #1.1: Type: text/plain, Size: 4049 bytes --]

On 7/13/18 4:50 PM, Luis R. Chamberlain wrote:
> On Fri, Jul 13, 2018 at 04:40:39PM -0400, Jeff Mahoney wrote:
>> On 7/13/18 12:44 PM, Luis R. Chamberlain wrote:
>>> On Fri, Jul 13, 2018 at 11:39:55AM +0300, Amir Goldstein wrote:
>>>> On Fri, Jul 13, 2018 at 5:43 AM, Luis R. Chamberlain <mcgrof@kernel.org> wrote:
>>>>> I had volunteered at the last LSF/MM to help with the stable work for
>>>>> XFS. To help with this, as part of this year's SUSE Hackweek, I've
>>>>> first generalized my own set of scripts to help track a baseline of
>>>>> results from fstests [0], and extended it to be able to easily ramp up
>>>>> with fstests on different distributions, and I've also created a
>>>>> respective baseline of results against these distributions as a
>>>>> further example of how these scripts and wrapper framework can be used
>>>>
>>>> Hi Luis!
>>>>
>>>> Thanks a lot for doing this work!
>>>>
>>>> Will take me some time to try it out, but see some questions below...
>>>>
>>>>> [1]. The distributions currently supported are:
>>>>>
>>>>>   * Debian testing
>>>>>   * OpenSUSE Leap 15.0
>>>>>   * Fedora 28
>>>>>
>>>>> The stable work starts with creating a baseline for v4.17.3. The
>>>>> results are visible as a result of expunge files which categorize the
>>>>> failures for the different sections tested.
>>>>
>>>> So the only "bad" indication is a test failure?
>>>
>>> That is correct to a certain degree, ie, if xfsprogs / the kernel
>>> config could run it we can assume it passed.
>>>
>>>> How about indication about a test that started to pass since baseline?
>>>
>>> Indeed, that is desirable.
>>>
>>> We have a few options. One is share the entire results directory for
>>> a release / section, however this is rather big. For instance for a
>>> full v4.17.3 run this is about 292 MiB alone. I don't think this
>>> scales. IMHO lgogs should only be supplied onto bug reports, not this
>>> framework.
>>>
>>> The other option is to use -R xunit to generate the report in the
>>> specified unit. I have not yet run this, or tried it, however IIRC
>>> it does record success runs? Does it also keep logs? Hopefully not.  I'm
>>> assuming it does not as of yet. I should note if one hits CTRL-C in the
>>> middle one does not get the results. An alternative was being worked on
>>> by Jeff which would sprinkle IIRC .ok files for tests which succeed,
>>> then you could just scrape the results directory to determine which
>>> tests did pass -- but you run into the same size problem as above.
>>
>> Eryu didn't like that idea, so I abandoned it.  What I have now is a -R
>> files mode that creates a bunch of files with the goal of just archiving
>> the results for later comparison or import into a results db.
>>
>> For each test, there are:
>> $seq.result.start.txt - start timestamp
>> $seq.result.stop.txt - stop timestamp
>> $seq.result.result.txt - simple result: pass/fail/expunged/notrun
>> $seq.result.detail.txt - contains the contents of $seq.notrun/$seq.expunged
>> $seq.result.{dmesg,kmemleak,full,check}.txt - contains the contents of
>> the corresponding files
> 
> This is sexy, it also gives the person interpretting the results to
> opt-in or not for the actuall full log of the output. You pick and
> choose what info you want.
> 
> This is indeed nice.
> 
>> As an aside, IIRC, -R xunit doesn't catch all kinds of failures.  Also,
>> as you mentioned, if it's interrupted, all results are lost.  This makes
>> it difficult to identify test failures that crashed or hung the test system.
> 
> OK so indeed not my preference.
> 
>> I have some basic scripts that parse the output and generate an HTML
>> report/table (and it does do what Amir asks WRT tests that started passing).
> 
> These scripts, are they for parsing your new -R files output?

Yep.

> I take it the patches are still being worked on?

Yeah.  They just need a bit of review and cleaning up and I can post them.

-Jeff

-- 
Jeff Mahoney
SUSE Labs


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2018-07-13 21:20 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-13  2:43 [ANN] oscheck: wrapper for fstests check.sh - tracking and working with baselines Luis R. Chamberlain
2018-07-13  8:39 ` Amir Goldstein
2018-07-13 16:44   ` Luis R. Chamberlain
2018-07-13 17:46     ` Luis R. Chamberlain
2018-07-13 20:40     ` Jeff Mahoney
2018-07-13 20:50       ` Luis R. Chamberlain
2018-07-13 21:03         ` Jeff Mahoney [this message]
2018-07-14  0:52     ` Theodore Y. Ts'o
2018-07-14  6:56     ` Eryu Guan
2018-07-13 20:51 ` Matthew Wilcox
2018-07-13 20:59   ` Luis R. Chamberlain
2018-07-14 22:21     ` Matthew Wilcox
2018-12-03 23:41       ` Luis Chamberlain
2018-12-04 11:01       ` Kent Overstreet
2019-08-16 17:34       ` Luis Chamberlain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dc2c2b79-6124-4673-301b-47429b29119e@suse.com \
    --to=jeffm@suse.com \
    --cc=Alexander.Levin@microsoft.com \
    --cc=amir73il@gmail.com \
    --cc=fstests@vger.kernel.org \
    --cc=levinsasha928@gmail.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=mcgrof@kernel.org \
    --cc=valentinrothberg@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.