All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeremy Kerr <jk@ozlabs.org>
To: Christopher Bostic <cbostic@linux.vnet.ibm.com>, joel@jms.id.au
Cc: openbmc@lists.ozlabs.org
Subject: Re: [PATCH linux dev-4.7 v2 3/7] drivers/fsi: Define hub master callbacks
Date: Wed, 22 Feb 2017 09:06:17 +0800	[thread overview]
Message-ID: <dc340299-0b3c-f262-153d-a9ee5787b786@ozlabs.org> (raw)
In-Reply-To: <20170221215032.79282-4-cbostic@linux.vnet.ibm.com>

Hi Chris,

> Define hub master read, write, link enable, and break ops.

Now that we have things more contained, you may want to add the complete
hub functionality in one patch.

However:

> @@ -571,6 +598,7 @@ static int fsi_slave_init(struct fsi_master *master,
>  	slave->id = slave_id;
>  	slave->dev.parent = master->dev;
>  	slave->dev.release = fsi_slave_release;
> +	slave->link = link;
>  
>  	dev_set_name(&slave->dev, "slave@%02x:%02x", link, slave_id);
>  	rc = device_register(&slave->dev);

This looks like a generally-useful fix, for more than just the hub code.

Otherwise, looks good.

Cheers,


Jeremy

  reply	other threads:[~2017-02-22  1:06 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-21 21:50 [PATCH linux dev-4.7 v2 0/7] drivers/fsi: Add hub master Christopher Bostic
2017-02-21 21:50 ` [PATCH linux dev-4.7 v2 1/7] drivers/fsi: Add hub master scan detect Christopher Bostic
2017-02-22  1:02   ` Jeremy Kerr
2017-02-22 15:29     ` Christopher Bostic
2017-02-21 21:50 ` [PATCH linux dev-4.7 v2 2/7] drivers/fsi: Initialize hub master Christopher Bostic
2017-02-21 21:50 ` [PATCH linux dev-4.7 v2 3/7] drivers/fsi: Define hub master callbacks Christopher Bostic
2017-02-22  1:06   ` Jeremy Kerr [this message]
2017-02-22 16:33     ` Christopher Bostic
2017-02-21 21:50 ` [PATCH linux dev-4.7 v2 4/7] drivers/fsi: Move common read write ops into single function Christopher Bostic
2017-02-22  1:02   ` Joel Stanley
2017-02-21 21:50 ` [PATCH linux dev-4.7 v2 5/7] drivers/fsi: Add retry on bus error detect Christopher Bostic
2017-02-22  1:00   ` Joel Stanley
2017-02-22 16:34     ` Christopher Bostic
2017-02-22 22:36     ` Christopher Bostic
2017-02-22  1:13   ` Jeremy Kerr
2017-02-22 16:37     ` Christopher Bostic
2017-02-21 21:50 ` [PATCH linux dev-4.7 v2 6/7] drivers/fsi: Cleanup bus errors Christopher Bostic
2017-02-22 21:55   ` Jeremy Kerr
2017-02-22 22:51     ` Christopher Bostic
2017-02-21 21:50 ` [PATCH linux dev-4.7 v2 7/7] tools/testing/selftests: Add fsi command line tool Christopher Bostic
2017-02-22  1:08 ` [PATCH linux dev-4.7 v2 0/7] drivers/fsi: Add hub master Jeremy Kerr
2017-02-22 15:27   ` Christopher Bostic
2017-02-22 16:24 ` Andrew Geissler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dc340299-0b3c-f262-153d-a9ee5787b786@ozlabs.org \
    --to=jk@ozlabs.org \
    --cc=cbostic@linux.vnet.ibm.com \
    --cc=joel@jms.id.au \
    --cc=openbmc@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.