All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Colin King <colin.king@canonical.com>,
	Chas Williams <3chas3@gmail.com>,
	linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] atm: iphase: fix newline escape and minor tweak to source formatting
Date: Mon, 12 Sep 2016 14:55:15 +0300	[thread overview]
Message-ID: <dc4b1df0-4d8a-cab3-3d6f-62c0ca25d686@cogentembedded.com> (raw)
In-Reply-To: <20160912092930.20683-1-colin.king@canonical.com>

Hello.

On 9/12/2016 12:29 PM, Colin King wrote:

> From: Colin Ian King <colin.king@canonical.com>
>
> The newline escape is incorrect and needs fixing. Also adjust source
> formatting / indentation and remove trailing white space.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  drivers/atm/iphase.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/atm/iphase.c b/drivers/atm/iphase.c
> index 9d8807e..256b191 100644
> --- a/drivers/atm/iphase.c
> +++ b/drivers/atm/iphase.c
> @@ -1885,9 +1885,8 @@ static int open_tx(struct atm_vcc *vcc)
>                  if ((ret = ia_cbr_setup (iadev, vcc)) < 0) {
>                      return ret;
>                  }
> -       }
> -	else
> -           printk("iadev:  Non UBR, ABR and CBR traffic not supportedn");
> +	} else
> +		printk("iadev:  Non UBR, ABR and CBR traffic not supported\n");

    All branches of the *if* statement should have {} if at least one has 
them, perhaps a material for a follow-up patch).

[...]

MBR, Sergei

  reply	other threads:[~2016-09-12 11:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-12  9:29 [PATCH] atm: iphase: fix newline escape and minor tweak to source formatting Colin King
2016-09-12 11:55 ` Sergei Shtylyov [this message]
2016-09-12 11:55 ` Sergei Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dc4b1df0-4d8a-cab3-3d6f-62c0ca25d686@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=3chas3@gmail.com \
    --cc=colin.king@canonical.com \
    --cc=linux-atm-general@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.