From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DDC5C432BE for ; Mon, 2 Aug 2021 07:33:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 18BA560F5A for ; Mon, 2 Aug 2021 07:33:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232560AbhHBHdY (ORCPT ); Mon, 2 Aug 2021 03:33:24 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:20271 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232428AbhHBHdW (ORCPT ); Mon, 2 Aug 2021 03:33:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1627889593; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oKwm+VrriTnIjZjtBTh8lfiPTFsXfXUu+LiwuOKDUz4=; b=HNkpsTzEORCLdhKa6H0GOyrnOrPDoisJyha2RhOn6aioXqLqMY8dAC9JTKZq7ljPljMfhJ 5aRK+2zORdCh4rVrIZ3qxoGYovx2nuqSpqfjiL7ZvN8746TXbxa4M5XBiv7JpyodSmm+fh 3UhMCQ+UDQOQHz9BhgxUPg6pAZMoqXU= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-106-SuuJ7Ys6Pp6-IbRW3AgLmw-1; Mon, 02 Aug 2021 03:33:12 -0400 X-MC-Unique: SuuJ7Ys6Pp6-IbRW3AgLmw-1 Received: by mail-ej1-f70.google.com with SMTP id g21-20020a1709061e15b029052292d7c3b4so4300996ejj.9 for ; Mon, 02 Aug 2021 00:33:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=oKwm+VrriTnIjZjtBTh8lfiPTFsXfXUu+LiwuOKDUz4=; b=jgIpp37Skx2Ozz/E+nOk3vVfNeaBpv1C/CEL5cvMX7JV0+Sx6HrH26Qqc0lEsBeLge 7WldaWuoyQ2OCFhsMBtsLXMQtkoGlu9uKBua7RfuA9FBL1uYnaSZPqf6a/e9KQU4/tDw XkrgUJ3q4D0UZBSK+ZpHwcHNrimeociO+yv3B5Oy3+ZsBDed93ENPbtLe5OZGmzWGY4N LQpEHEs9tFIF5F5h23SRzFkXfVFW7ZBugtsQLQ39NM0gthYQeVE/TJToKqK0iqDMHv0C 7j+ucmQ4yA5Icokmz4LnPEv8H2EfAp9xDzHSduWKCu6ySwTjjtAfFQh2hgDpkiBmijgh QFDw== X-Gm-Message-State: AOAM532vq93rncbciENzwRc1gaXZwN17GqQBKts4cHNRwd9HqNPz9/Ca uo9AP48MzIZM7jPoD0GcXxgdLxX8iUbVYBBc6JWDny3SQH9HcNJ6K7xsd3PNzXI8B5Cw4YdKzkd /gaopQ9ccDpEZNTMUNJB7iVXf X-Received: by 2002:a17:906:948f:: with SMTP id t15mr14341824ejx.85.1627889590830; Mon, 02 Aug 2021 00:33:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzbsCOdlvVMel6wSv3vdUOaqGxihvei3PtY062A1Soqa5gEZO0krjA811OYtz6iN03PfgjegQ== X-Received: by 2002:a17:906:948f:: with SMTP id t15mr14341804ejx.85.1627889590666; Mon, 02 Aug 2021 00:33:10 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id n15sm5436746edw.70.2021.08.02.00.33.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Aug 2021 00:33:09 -0700 (PDT) Subject: Re: [RFC PATCH v2 00/69] KVM: X86: TDX support To: Sean Christopherson Cc: isaku.yamahata@intel.com, Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H . Peter Anvin" , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , erdemaktas@google.com, Connor Kuehl , x86@kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, isaku.yamahata@gmail.com References: <0d453d76-11e7-aeb9-b890-f457afbb6614@redhat.com> From: Paolo Bonzini Message-ID: Date: Mon, 2 Aug 2021 09:33:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28/07/21 18:51, Sean Christopherson wrote: > I strongly object to merging these two until we see the new SEAMLDR code: > > [RFC PATCH v2 02/69] KVM: X86: move kvm_cpu_vmxon() from vmx.c to virtext.h > [RFC PATCH v2 03/69] KVM: X86: move out the definition vmcs_hdr/vmcs from kvm to x86 > > If the SEAMLDR code ends up being fully contained in KVM, then this is unnecessary > churn and exposes code outside of KVM that we may not want exposed (yet). E.g. > setting and clearing CR4.VMXE (in the fault path) in cpu_vmxon() may not be > necessary/desirable for SEAMLDR, we simply can't tell without seeing the code. Fair enough (though, for patch 2, it's a bit weird to have vmxoff in virtext.h and not vmxon). Paolo