From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60FAAC433DB for ; Thu, 24 Dec 2020 08:25:31 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8438C229CA for ; Thu, 24 Dec 2020 08:25:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8438C229CA Authentication-Results: mail.kernel.org; dmarc=pass (p=none dis=none) header.from=nongnu.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:49806 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ksLw9-0005nG-7w for qemu-devel@archiver.kernel.org; Thu, 24 Dec 2020 03:25:29 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34298) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ksLvM-0005N9-Pp for qemu-devel@nongnu.org; Thu, 24 Dec 2020 03:24:40 -0500 Received: from zero.eik.bme.hu ([2001:738:2001:2001::2001]:44089) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ksLvK-0000ot-AO for qemu-devel@nongnu.org; Thu, 24 Dec 2020 03:24:40 -0500 Received: from zero.eik.bme.hu (blah.eik.bme.hu [152.66.115.182]) by localhost (Postfix) with SMTP id 24654746553; Thu, 24 Dec 2020 09:24:33 +0100 (CET) Received: by zero.eik.bme.hu (Postfix, from userid 432) id 9329F746552; Thu, 24 Dec 2020 09:24:32 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by zero.eik.bme.hu (Postfix) with ESMTP id 911E2746383; Thu, 24 Dec 2020 09:24:32 +0100 (CET) Date: Thu, 24 Dec 2020 09:24:32 +0100 (CET) To: Jiaxun Yang Subject: Re: [PATCH v3 5/8] hw/mips/fuloong2e: Remove unused env entry In-Reply-To: <20201224031750.52146-6-jiaxun.yang@flygoat.com> Message-ID: References: <20201224031750.52146-1-jiaxun.yang@flygoat.com> <20201224031750.52146-6-jiaxun.yang@flygoat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Received-SPF: pass client-ip=2001:738:2001:2001::2001; envelope-from=balaton@eik.bme.hu; helo=zero.eik.bme.hu X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Aleksandar Rikalo , Huacai Chen , qemu-devel@nongnu.org, Wainer dos Santos Moschetta , =?ISO-8859-15?Q?Philippe_Mathieu-Daud=E9?= , Cleber Rosa , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Reply-to: BALATON Zoltan From: BALATON Zoltan via On Thu, 24 Dec 2020, Jiaxun Yang wrote: > modetty is not handled by kernel and the parameter > here seems unreasonable. > > Signed-off-by: Jiaxun Yang > --- > v3: Bring busclock back > --- > hw/mips/fuloong2e.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/hw/mips/fuloong2e.c b/hw/mips/fuloong2e.c > index d846ef7b00..c4843dd15e 100644 > --- a/hw/mips/fuloong2e.c > +++ b/hw/mips/fuloong2e.c > @@ -159,10 +159,8 @@ static uint64_t load_kernel(CPUMIPSState *env) > } > > /* Setup minimum environment variables */ > - prom_set(prom_buf, index++, "busclock=33000000"); Commit message does not mention removing this as well. Was this unintentionally left here? Regards, BALATON Zoltan > prom_set(prom_buf, index++, "cpuclock=100000000"); > prom_set(prom_buf, index++, "memsize=%"PRIi64, loaderparams.ram_size / MiB); > - prom_set(prom_buf, index++, "modetty0=38400n8r"); > prom_set(prom_buf, index++, NULL); > > rom_add_blob_fixed("prom", prom_buf, prom_size, ENVP_PADDR); >