From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Subject: Re: [PATCH v2] libs/power: add p-state driver
	compatibility
Date: Fri, 14 Dec 2018 12:20:07 +0000
Message-ID: <dc52b441-a1bf-f3df-b9d7-8d6a5cf3e9e8@intel.com>
References: <1542972781-6149-1-git-send-email-liang.j.ma@intel.com>
 <1544786028-10138-1-git-send-email-liang.j.ma@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Cc: dev@dpdk.org
To: Liang Ma <liang.j.ma@intel.com>, david.hunt@intel.com
Return-path: <dev-bounces@dpdk.org>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id 079BC4C74
 for <dev@dpdk.org>; Fri, 14 Dec 2018 13:20:09 +0100 (CET)
In-Reply-To: <1544786028-10138-1-git-send-email-liang.j.ma@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 14-Dec-18 11:13 AM, Liang Ma wrote:
> Previously, in order to use the power library, it was necessary
> for the user to disable the intel_pstate driver by adding
> “intel_pstate=disable” to the kernel command line for the system,
> which causes the acpi_cpufreq driver to be loaded in its place.
> 
> This patch adds the ability for the power library use the intel-pstate
> driver.
> 
> It adds a new suite of functions behind the current power library API,
> and will seamlessly set up the user facing API function pointers to
> the relevant functions depending on whether the system is running with
> acpi_cpufreq kernel driver, intel_pstate kernel driver or in a guest,
> using kvm. The library API and ABI is unchanged.
> 
> Signed-off-by: Liang Ma <liang.j.ma@intel.com>
> ---

<snip>

>   sources = files('rte_power.c', 'power_acpi_cpufreq.c',
>   		'power_kvm_vm.c', 'guest_channel.c',
> -		'rte_power_empty_poll.c')
> +		'rte_power_empty_poll.c',
> +		'power_pstate_cpufreq.c')
>   headers = files('rte_power.h','rte_power_empty_poll.h')
> -deps += ['timer']
> diff --git a/lib/librte_power/power_pstate_cpufreq.c b/lib/librte_power/power_pstate_cpufreq.c
> new file mode 100644
> index 0000000..1711484
> --- /dev/null
> +++ b/lib/librte_power/power_pstate_cpufreq.c
> @@ -0,0 +1,770 @@
> +/* SPDX-License-Identifier: BSD-3-Clause
> + * Copyright(c) 2010-2018 Intel Corporation

Like i said in comments to previous revision, copyright date here is 
wrong - you're creating a new file. This file wasn't created in 2010. It 
should just say "2018".

Other than that, LGTM

Reviewed-by: Anatoly Burakov <anatoly.burakov@intel.com>

-- 
Thanks,
Anatoly