From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE1B4C433EF for ; Mon, 14 Mar 2022 11:44:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238292AbiCNLpY (ORCPT ); Mon, 14 Mar 2022 07:45:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33472 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240706AbiCNLom (ORCPT ); Mon, 14 Mar 2022 07:44:42 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id D72617670; Mon, 14 Mar 2022 04:43:31 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 90714106F; Mon, 14 Mar 2022 04:43:31 -0700 (PDT) Received: from [10.57.42.204] (unknown [10.57.42.204]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 34EC43F99C; Mon, 14 Mar 2022 04:43:30 -0700 (PDT) Message-ID: Date: Mon, 14 Mar 2022 11:43:26 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH v2 3/3] ARM: dts: lpc32xx: Update spi clock properties Content-Language: en-GB To: Vladimir Zapolskiy , Arnd Bergmann Cc: Kuldeep Singh , Olof Johansson , SoC Team , Rob Herring , DTML , Linux ARM , Linux Kernel Mailing List References: <20220311093800.18778-1-singh.kuldeep87k@gmail.com> <20220311093800.18778-4-singh.kuldeep87k@gmail.com> <4aae560d-d266-d0d0-136f-32891b15bc01@mleia.com> <4f39f086-1932-1729-8761-d5c533356812@mleia.com> From: Robin Murphy In-Reply-To: <4f39f086-1932-1729-8761-d5c533356812@mleia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022-03-11 14:07, Vladimir Zapolskiy wrote: > On 3/11/22 3:38 PM, Arnd Bergmann wrote: >> On Fri, Mar 11, 2022 at 2:20 PM Vladimir Zapolskiy wrote: >>> >>> On 3/11/22 11:38 AM, Kuldeep Singh wrote: >>>> PL022 binding require two clocks to be defined but lpc platform doesn't >>>> comply with bindings and define only one clock i.e apb_pclk. >>>> >>>> Update spi clocks and clocks-names property by adding appropriate clock >>>> reference to make it compliant with bindings. >>>> >>>> CC: Vladimir Zapolskiy >>>> Signed-off-by: Kuldeep Singh >>>> --- >>>> v2: >>>> - New patch with similar changeset >>>> - Send to soc ML >>>> >>>>    arch/arm/boot/dts/lpc32xx.dtsi | 8 ++++---- >>>>    1 file changed, 4 insertions(+), 4 deletions(-) >>>> >>>> diff --git a/arch/arm/boot/dts/lpc32xx.dtsi >>>> b/arch/arm/boot/dts/lpc32xx.dtsi >>>> index c87066d6c995..30958e02d5e2 100644 >>>> --- a/arch/arm/boot/dts/lpc32xx.dtsi >>>> +++ b/arch/arm/boot/dts/lpc32xx.dtsi >>>> @@ -178,8 +178,8 @@ ssp0: spi@20084000 { >>>>                                compatible = "arm,pl022", >>>> "arm,primecell"; >>>>                                reg = <0x20084000 0x1000>; >>>>                                interrupts = <20 IRQ_TYPE_LEVEL_HIGH>; >>>> -                             clocks = <&clk LPC32XX_CLK_SSP0>; >>>> -                             clock-names = "apb_pclk"; >>>> +                             clocks = <&clk LPC32XX_CLK_SSP0>, >>>> <&clk LPC32XX_CLK_SSP0>; >>>> +                             clock-names = "sspclk", "apb_pclk"; >>> >>> In fact I'm uncertain if it is the right change, could it happen that >>> the commit >>> cc0f6e96c4fd ("spi: dt-bindings: Convert Arm pl022 to json-schema") >>> sets a wrong >>> schema pattern? >> >> Good pointm this doesn't quite seem right: it is unlikely that the >> same clock >> is used for both the SPI bus and the APB bus. >> >>> Apparently just one clock is wanted on all observed platforms and >>> cases, this >>> is implicitly confirmed by clock handling in the >>> drivers/spi/spi-pl022.c : >>> >>>          pl022->clk = devm_clk_get(&adev->dev, NULL); >>> >>> So, I would vote to fix the device tree bindings schema. >> >> Isn't this just using the wrong name? The name of the macro >> LPC32XX_CLK_SSP0 might indicate that this is indeed the SPI clock >> rather than the APB clock, so we only need to change clock-names >> property here and leave it unchanged otherwise. > > Yes, the name is wrong, here I'm ready to take the blame: > > Fixes: 93898eb775e5 ("arm: dts: lpc32xx: add clock properties to device > nodes") > > Noteworthy the commit above presets the same clock name to other PrimeCell > controllers, namely pl110 (LCD), pl080 (DMA), pl175 (EMC) and pl18x (SD), > plus this one pl022 (SSP), and all but SSP and SD are AHB slaves in fact. > > On LPC32xx the bus clock source and function clock source for SSP is HCLK. > > My guess is that the misnamed "apb_pclk" migrated into the schema from > the lpc32xx.dtsi, so I'd suggest, unless some platform really needs it, > firstly fix the schema by removing "apb_pclk" clock. It will leave just one > clock, so "clock-names" property can be set as optional, and the drop > the property from the lpc32xx.dtsi. No, "apb_pclk" is part of the common AMBA binding, and is required by the "arm,primecell" compatible. You won't (usually) find it referenced in drivers because it's dealt with by amba_get_enable_pclk() via amba_probe(). Robin. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0B538C433EF for ; Mon, 14 Mar 2022 11:44:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=N69f3fmdruTyfkUF9dNQrqn13TsrvPam39F2WznO00M=; b=G7rBZGBZltQxOx mxFD+sBKL5znFtIuKP36eBTJsSEdwqEiaFhkNdv0i4HA7t4XAlyBMIIFqRrK/vL8QHm+IWFdU8nnm xViM9TlTHhQ17FJ99k0HhjKFa3u+gDTUsCt1nb3UI5mx3eqSFqnJyF0QmJjXa+zZEOQF7tzUFrH4n DyeuwhfLXR5JCu59+f1JIEt0CRseUEGaJ7aDacrsgx6VEO87bjEbpCzfpvp/0/YWkCD0hBrNawuso 0Cv80rcL/bTcdWSZhDpp8rLMLQPdMn/ZIpX4qpCcQOyCJEoifb59vJz8+jjnQpXJhnJwmwXNyMia2 DnRBy/eg/Sf02805tt6A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nTj6u-005DkW-SA; Mon, 14 Mar 2022 11:43:36 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nTj6r-005Djg-A2 for linux-arm-kernel@lists.infradead.org; Mon, 14 Mar 2022 11:43:34 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 90714106F; Mon, 14 Mar 2022 04:43:31 -0700 (PDT) Received: from [10.57.42.204] (unknown [10.57.42.204]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 34EC43F99C; Mon, 14 Mar 2022 04:43:30 -0700 (PDT) Message-ID: Date: Mon, 14 Mar 2022 11:43:26 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH v2 3/3] ARM: dts: lpc32xx: Update spi clock properties Content-Language: en-GB To: Vladimir Zapolskiy , Arnd Bergmann Cc: Kuldeep Singh , Olof Johansson , SoC Team , Rob Herring , DTML , Linux ARM , Linux Kernel Mailing List References: <20220311093800.18778-1-singh.kuldeep87k@gmail.com> <20220311093800.18778-4-singh.kuldeep87k@gmail.com> <4aae560d-d266-d0d0-136f-32891b15bc01@mleia.com> <4f39f086-1932-1729-8761-d5c533356812@mleia.com> From: Robin Murphy In-Reply-To: <4f39f086-1932-1729-8761-d5c533356812@mleia.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220314_044333_474608_FA6CC8A7 X-CRM114-Status: GOOD ( 22.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMjAyMi0wMy0xMSAxNDowNywgVmxhZGltaXIgWmFwb2xza2l5IHdyb3RlOgo+IE9uIDMvMTEv MjIgMzozOCBQTSwgQXJuZCBCZXJnbWFubiB3cm90ZToKPj4gT24gRnJpLCBNYXIgMTEsIDIwMjIg YXQgMjoyMCBQTSBWbGFkaW1pciBaYXBvbHNraXkgPHZ6QG1sZWlhLmNvbT4gd3JvdGU6Cj4+Pgo+ Pj4gT24gMy8xMS8yMiAxMTozOCBBTSwgS3VsZGVlcCBTaW5naCB3cm90ZToKPj4+PiBQTDAyMiBi aW5kaW5nIHJlcXVpcmUgdHdvIGNsb2NrcyB0byBiZSBkZWZpbmVkIGJ1dCBscGMgcGxhdGZvcm0g ZG9lc24ndAo+Pj4+IGNvbXBseSB3aXRoIGJpbmRpbmdzIGFuZCBkZWZpbmUgb25seSBvbmUgY2xv Y2sgaS5lIGFwYl9wY2xrLgo+Pj4+Cj4+Pj4gVXBkYXRlIHNwaSBjbG9ja3MgYW5kIGNsb2Nrcy1u YW1lcyBwcm9wZXJ0eSBieSBhZGRpbmcgYXBwcm9wcmlhdGUgY2xvY2sKPj4+PiByZWZlcmVuY2Ug dG8gbWFrZSBpdCBjb21wbGlhbnQgd2l0aCBiaW5kaW5ncy4KPj4+Pgo+Pj4+IENDOiBWbGFkaW1p ciBaYXBvbHNraXkgPHZ6QG1sZWlhLmNvbT4KPj4+PiBTaWduZWQtb2ZmLWJ5OiBLdWxkZWVwIFNp bmdoIDxzaW5naC5rdWxkZWVwODdrQGdtYWlsLmNvbT4KPj4+PiAtLS0KPj4+PiB2MjoKPj4+PiAt IE5ldyBwYXRjaCB3aXRoIHNpbWlsYXIgY2hhbmdlc2V0Cj4+Pj4gLSBTZW5kIHRvIHNvYyBNTAo+ Pj4+Cj4+Pj4gwqDCoCBhcmNoL2FybS9ib290L2R0cy9scGMzMnh4LmR0c2kgfCA4ICsrKystLS0t Cj4+Pj4gwqDCoCAxIGZpbGUgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygt KQo+Pj4+Cj4+Pj4gZGlmZiAtLWdpdCBhL2FyY2gvYXJtL2Jvb3QvZHRzL2xwYzMyeHguZHRzaSAK Pj4+PiBiL2FyY2gvYXJtL2Jvb3QvZHRzL2xwYzMyeHguZHRzaQo+Pj4+IGluZGV4IGM4NzA2NmQ2 Yzk5NS4uMzA5NThlMDJkNWUyIDEwMDY0NAo+Pj4+IC0tLSBhL2FyY2gvYXJtL2Jvb3QvZHRzL2xw YzMyeHguZHRzaQo+Pj4+ICsrKyBiL2FyY2gvYXJtL2Jvb3QvZHRzL2xwYzMyeHguZHRzaQo+Pj4+ IEBAIC0xNzgsOCArMTc4LDggQEAgc3NwMDogc3BpQDIwMDg0MDAwIHsKPj4+PiDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgY29tcGF0 aWJsZSA9ICJhcm0scGwwMjIiLCAKPj4+PiAiYXJtLHByaW1lY2VsbCI7Cj4+Pj4gwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHJlZyA9 IDwweDIwMDg0MDAwIDB4MTAwMD47Cj4+Pj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGludGVycnVwdHMgPSA8MjAgSVJRX1RZUEVf TEVWRUxfSElHSD47Cj4+Pj4gLcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgIGNsb2NrcyA9IDwmY2xrIExQQzMyWFhfQ0xLX1NTUDA+Owo+Pj4+ IC3CoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oCBjbG9jay1uYW1lcyA9ICJhcGJfcGNsayI7Cj4+Pj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGNsb2NrcyA9IDwmY2xrIExQQzMyWFhf Q0xLX1NTUDA+LCAKPj4+PiA8JmNsayBMUEMzMlhYX0NMS19TU1AwPjsKPj4+PiArwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgY2xvY2stbmFt ZXMgPSAic3NwY2xrIiwgImFwYl9wY2xrIjsKPj4+Cj4+PiBJbiBmYWN0IEknbSB1bmNlcnRhaW4g aWYgaXQgaXMgdGhlIHJpZ2h0IGNoYW5nZSwgY291bGQgaXQgaGFwcGVuIHRoYXQgCj4+PiB0aGUg Y29tbWl0Cj4+PiBjYzBmNmU5NmM0ZmQgKCJzcGk6IGR0LWJpbmRpbmdzOiBDb252ZXJ0IEFybSBw bDAyMiB0byBqc29uLXNjaGVtYSIpIAo+Pj4gc2V0cyBhIHdyb25nCj4+PiBzY2hlbWEgcGF0dGVy bj8KPj4KPj4gR29vZCBwb2ludG0gdGhpcyBkb2Vzbid0IHF1aXRlIHNlZW0gcmlnaHQ6IGl0IGlz IHVubGlrZWx5IHRoYXQgdGhlIAo+PiBzYW1lIGNsb2NrCj4+IGlzIHVzZWQgZm9yIGJvdGggdGhl IFNQSSBidXMgYW5kIHRoZSBBUEIgYnVzLgo+Pgo+Pj4gQXBwYXJlbnRseSBqdXN0IG9uZSBjbG9j ayBpcyB3YW50ZWQgb24gYWxsIG9ic2VydmVkIHBsYXRmb3JtcyBhbmQgCj4+PiBjYXNlcywgdGhp cwo+Pj4gaXMgaW1wbGljaXRseSBjb25maXJtZWQgYnkgY2xvY2sgaGFuZGxpbmcgaW4gdGhlIAo+ Pj4gZHJpdmVycy9zcGkvc3BpLXBsMDIyLmMgOgo+Pj4KPj4+IMKgwqDCoMKgwqDCoMKgwqAgcGww MjItPmNsayA9IGRldm1fY2xrX2dldCgmYWRldi0+ZGV2LCBOVUxMKTsKPj4+Cj4+PiBTbywgSSB3 b3VsZCB2b3RlIHRvIGZpeCB0aGUgZGV2aWNlIHRyZWUgYmluZGluZ3Mgc2NoZW1hLgo+Pgo+PiBJ c24ndCB0aGlzIGp1c3QgdXNpbmcgdGhlIHdyb25nIG5hbWU/IFRoZSBuYW1lIG9mIHRoZSBtYWNy bwo+PiBMUEMzMlhYX0NMS19TU1AwIG1pZ2h0IGluZGljYXRlIHRoYXQgdGhpcyBpcyBpbmRlZWQg dGhlIFNQSSBjbG9jawo+PiByYXRoZXIgdGhhbiB0aGUgQVBCIGNsb2NrLCBzbyB3ZSBvbmx5IG5l ZWQgdG8gY2hhbmdlIGNsb2NrLW5hbWVzCj4+IHByb3BlcnR5IGhlcmUgYW5kIGxlYXZlIGl0IHVu Y2hhbmdlZCBvdGhlcndpc2UuCj4gCj4gWWVzLCB0aGUgbmFtZSBpcyB3cm9uZywgaGVyZSBJJ20g cmVhZHkgdG8gdGFrZSB0aGUgYmxhbWU6Cj4gCj4gRml4ZXM6IDkzODk4ZWI3NzVlNSAoImFybTog ZHRzOiBscGMzMnh4OiBhZGQgY2xvY2sgcHJvcGVydGllcyB0byBkZXZpY2UgCj4gbm9kZXMiKQo+ IAo+IE5vdGV3b3J0aHkgdGhlIGNvbW1pdCBhYm92ZSBwcmVzZXRzIHRoZSBzYW1lIGNsb2NrIG5h bWUgdG8gb3RoZXIgUHJpbWVDZWxsCj4gY29udHJvbGxlcnMsIG5hbWVseSBwbDExMCAoTENEKSwg cGwwODAgKERNQSksIHBsMTc1IChFTUMpIGFuZCBwbDE4eCAoU0QpLAo+IHBsdXMgdGhpcyBvbmUg cGwwMjIgKFNTUCksIGFuZCBhbGwgYnV0IFNTUCBhbmQgU0QgYXJlIEFIQiBzbGF2ZXMgaW4gZmFj dC4KPiAKPiBPbiBMUEMzMnh4IHRoZSBidXMgY2xvY2sgc291cmNlIGFuZCBmdW5jdGlvbiBjbG9j ayBzb3VyY2UgZm9yIFNTUCBpcyBIQ0xLLgo+IAo+IE15IGd1ZXNzIGlzIHRoYXQgdGhlIG1pc25h bWVkICJhcGJfcGNsayIgbWlncmF0ZWQgaW50byB0aGUgc2NoZW1hIGZyb20KPiB0aGUgbHBjMzJ4 eC5kdHNpLCBzbyBJJ2Qgc3VnZ2VzdCwgdW5sZXNzIHNvbWUgcGxhdGZvcm0gcmVhbGx5IG5lZWRz IGl0LAo+IGZpcnN0bHkgZml4IHRoZSBzY2hlbWEgYnkgcmVtb3ZpbmcgImFwYl9wY2xrIiBjbG9j ay4gSXQgd2lsbCBsZWF2ZSBqdXN0IG9uZQo+IGNsb2NrLCBzbyAiY2xvY2stbmFtZXMiIHByb3Bl cnR5IGNhbiBiZSBzZXQgYXMgb3B0aW9uYWwsIGFuZCB0aGUgZHJvcAo+IHRoZSBwcm9wZXJ0eSBm cm9tIHRoZSBscGMzMnh4LmR0c2kuCgpObywgImFwYl9wY2xrIiBpcyBwYXJ0IG9mIHRoZSBjb21t b24gQU1CQSBiaW5kaW5nLCBhbmQgaXMgcmVxdWlyZWQgYnkgCnRoZSAiYXJtLHByaW1lY2VsbCIg Y29tcGF0aWJsZS4gWW91IHdvbid0ICh1c3VhbGx5KSBmaW5kIGl0IHJlZmVyZW5jZWQgCmluIGRy aXZlcnMgYmVjYXVzZSBpdCdzIGRlYWx0IHdpdGggYnkgYW1iYV9nZXRfZW5hYmxlX3BjbGsoKSB2 aWEgCmFtYmFfcHJvYmUoKS4KClJvYmluLgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJt LWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21h aWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=