From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michal Simek <michal.simek@xilinx.com>
Date: Mon, 17 Oct 2016 13:33:27 +0200
Subject: [U-Boot] [PATCH] ARM: zynq: Extend picozed board support
In-Reply-To: <3b0080c5-2511-dd4d-f19f-e5ccbb7bbe89@xilinx.com>
References: <1476703132-31975-1-git-send-email-oscargomezf@gmail.com>
 <3b0080c5-2511-dd4d-f19f-e5ccbb7bbe89@xilinx.com>
Message-ID: <dc72a335-070a-836f-5446-7aca95e71f55@xilinx.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi,

and I forget to mentioned. Use mainline mailing list instead of xilinx one.

Thanks,
Michal

On 17.10.2016 13:32, Michal Simek wrote:
> On 17.10.2016 13:18, Oscar Gomez Fuente wrote:
>> Add missing DT nodes.
>>
>> Signed-off-by: Oscar Gomez Fuente <oscargomezf@gmail.com>
>> ---
>>  arch/arm/dts/zynq-picozed.dts | 20 ++++++++++++++++++++
>>  1 file changed, 20 insertions(+)
>>
>> diff --git a/arch/arm/dts/zynq-picozed.dts b/arch/arm/dts/zynq-picozed.dts
>> index 3408df8..5f703a2 100644
>> --- a/arch/arm/dts/zynq-picozed.dts
>> +++ b/arch/arm/dts/zynq-picozed.dts
>> @@ -26,3 +26,23 @@
>>  	u-boot,dm-pre-reloc;
>>  	status = "okay";
>>  };
>> +
> 
> please also extended aliases list.
> 
>> +&gem0 {
>> +	status = "okay";
>> +	phy-mode = "rgmii-id";
>> +	phy-handle = <&ethernet_phy>;
>> +
>> +	ethernet_phy: ethernet-phy at 0 {
>> +		reg = <0>;
> 
> I expect that this is on board 88e1512
> 
>> +	};
>> +};
>> +
>> +&qspi {
>> +	u-boot,dm-pre-reloc;
>> +	status = "okay";
>> +	};
> 
> wrong indentation here.
> 
>> +
>> +&sdhci0 {
> 
> is this sd0 or sd1 hard IP? I expect that this is emmc right?
> 
>> +	u-boot,dm-pre-reloc;
>> +	status = "okay";
>> +};
>>
> 
> Thanks,
> Michal
>