All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Weil <sw@weilnetz.de>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	adam.s@Safe-mail.net, qemu-devel@nongnu.org
Subject: Re: Shortcoming (oversight) in Windows installer
Date: Sat, 19 Jun 2021 12:34:39 +0200	[thread overview]
Message-ID: <dc74be85-c0d9-7433-a572-9cb1a7a484d8@weilnetz.de> (raw)
In-Reply-To: <1c25fadd-1f3f-b3ba-c2fb-d5654b6e6e29@amsat.org>

Am 19.06.21 um 12:03 schrieb Philippe Mathieu-Daudé:

> Hi Adam,
>
> On 6/19/21 12:55 AM, adam.s@Safe-mail.net wrote:
>> but I noticed this about the Windows installer:
>>
>> Does not add (nor offer to add) "C:\Program Files\qemu" to path.
>>
>> It should maybe be an optional choice in the installer.
> Can you try sending a patch via email?


Adding the installation directory to the search path is dangerous on 
Windows and can result in an empty path when the length exceeds some 
limit: 
https://stackoverflow.com/questions/43014724/how-to-reset-system-variable-path-after-tesseract-installation.

In addition I don't like having a global path setting with lots of 
entries for many different programs. That can cause ambiguities if 
different path entries include incompatible EXE or DLL files with the 
same name. Windows uses PATH not only for finding EXE files but also for 
DLL files.

Therefore I would not implement the suggested feature.

I suggest running the QEMU executables by specifying their full name 
including their installation directory. And it's also easy to add a 
local batch file which sets the right path temporarily.

Regards

Stefan




      reply	other threads:[~2021-06-19 10:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-18 22:55 Shortcoming (oversight) in Windows installer adam.s
2021-06-19 10:03 ` Philippe Mathieu-Daudé
2021-06-19 10:34   ` Stefan Weil [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dc74be85-c0d9-7433-a572-9cb1a7a484d8@weilnetz.de \
    --to=sw@weilnetz.de \
    --cc=adam.s@Safe-mail.net \
    --cc=f4bug@amsat.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.