From mboxrd@z Thu Jan  1 00:00:00 1970
From: Shreyansh Jain <shreyansh.jain@nxp.com>
Subject: Re: [PATCH v4 13/41] bus/dpaa: add support for FMAN
 frame queue lookup
Date: Thu, 28 Sep 2017 17:17:25 +0530
Message-ID: <dc7bb08c-b5cc-71b4-5d71-6265d95613a4@nxp.com>
References: <20170823141213.25476-1-shreyansh.jain@nxp.com>
 <20170909112132.13936-1-shreyansh.jain@nxp.com>
 <20170909112132.13936-14-shreyansh.jain@nxp.com>
 <596a7bff-1179-1590-c9b2-92e8362460d0@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Cc: <dev@dpdk.org>, <hemant.agrawal@nxp.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM01-BY2-obe.outbound.protection.outlook.com
 (mail-by2nam01on0073.outbound.protection.outlook.com [104.47.34.73])
 by dpdk.org (Postfix) with ESMTP id CA0EE107A
 for <dev@dpdk.org>; Thu, 28 Sep 2017 13:36:36 +0200 (CEST)
In-Reply-To: <596a7bff-1179-1590-c9b2-92e8362460d0@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Monday 18 September 2017 08:21 PM, Ferruh Yigit wrote:
> On 9/9/2017 12:21 PM, Shreyansh Jain wrote:
>> Signed-off-by: Geoff Thorpe <geoff.thorpe@nxp.com>
>> Signed-off-by: Roy Pledge <roy.pledge@nxp.com>
>> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
>> Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
> 
> <...>
> 
>>   
>> +#if !defined(CONFIG_FSL_QMAN_FQ_LOOKUP) && defined(RTE_ARCH_ARM64)
>> +#error "_ARM64 requires _FSL_QMAN_FQ_LOOKUP"
>> +#endif
> 
> This PMD enabled with new added config
> "defconfig_arm64-armv8a-linuxapp-gcc", which is 64bits. So this means
> CONFIG_FSL_QMAN_FQ_LOOKUP always defined for the bus.
> 
> Does is make sense to keep above check, but for rest of the code assume
> CONFIG_FSL_QMAN_FQ_LOOKUP always set and remove the #ifdefs, to simplify
> the code?
> 
> <...>
> 

I have removed these lines in v5. They were indeed unnecessary.
Thanks for highlighting.