From: John Hubbard <jhubbard@nvidia.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Ilya Dryomov <idryomov@gmail.com>, Jens Axboe <axboe@kernel.dk>,
<linux-xfs@vger.kernel.org>, <linux-fsdevel@vger.kernel.org>,
<linux-block@vger.kernel.org>, <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/3] iov_iter: introduce iov_iter_pin_user_pages*() routines
Date: Sat, 29 Aug 2020 14:58:45 -0700 [thread overview]
Message-ID: <dc7e5dde-9dc0-7d56-48de-777a2e50bca5@nvidia.com> (raw)
In-Reply-To: <20200829145849.GB12470@infradead.org>
On 8/29/20 7:58 AM, Christoph Hellwig wrote:
> On Sat, Aug 29, 2020 at 01:08:52AM -0700, John Hubbard wrote:
...
>> @@ -1280,7 +1281,11 @@ static inline ssize_t __pipe_get_pages(struct iov_iter *i,
>> maxsize = n;
>> n += *start;
>> while (n > 0) {
>> - get_page(*pages++ = pipe->bufs[iter_head & p_mask].page);
>> + if (use_pup)
>> + pin_user_page(*pages++ = pipe->bufs[iter_head & p_mask].page);
>> + else
>> + get_page(*pages++ = pipe->bufs[iter_head & p_mask].page);
>
> Maybe this would become a little more readable with a local variable
> and a little more verbosity:
>
> struct page *page = pipe->bufs[iter_head & p_mask].page;
>
> if (use_pup)
> pin_user_page(page);
> else
> get_page(page);
>
> *pages++ = page;
>
Yes, that is cleaner, I'll change to that, thanks.
thanks,
--
John Hubbard
NVIDIA
next prev parent reply other threads:[~2020-08-29 21:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-29 8:08 [PATCH v2 0/3] bio: Direct IO: convert to pin_user_pages_fast() John Hubbard
2020-08-29 8:08 ` [PATCH v2 1/3] mm/gup: introduce pin_user_page() John Hubbard
2020-08-29 14:54 ` Christoph Hellwig
2020-08-29 21:57 ` John Hubbard
2020-08-29 8:08 ` [PATCH v2 2/3] iov_iter: introduce iov_iter_pin_user_pages*() routines John Hubbard
2020-08-29 14:58 ` Christoph Hellwig
2020-08-29 21:58 ` John Hubbard [this message]
2020-08-30 20:17 ` Al Viro
2020-08-30 20:44 ` John Hubbard
2020-08-29 8:08 ` [PATCH v2 3/3] bio: convert get_user_pages_fast() --> pin_user_pages_fast() John Hubbard
2020-08-29 15:02 ` Christoph Hellwig
2020-08-29 22:08 ` John Hubbard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc7e5dde-9dc0-7d56-48de-777a2e50bca5@nvidia.com \
--to=jhubbard@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=idryomov@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.