From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A2509C43219 for ; Thu, 24 Nov 2022 18:50:44 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.448017.704779 (Exim 4.92) (envelope-from ) id 1oyHIx-0004Ma-83; Thu, 24 Nov 2022 18:50:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 448017.704779; Thu, 24 Nov 2022 18:50:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyHIx-0004MT-5R; Thu, 24 Nov 2022 18:50:35 +0000 Received: by outflank-mailman (input) for mailman id 448017; Thu, 24 Nov 2022 18:50:33 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyHIv-0004MN-JU for xen-devel@lists.xenproject.org; Thu, 24 Nov 2022 18:50:33 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oyHIv-0003OX-6L; Thu, 24 Nov 2022 18:50:33 +0000 Received: from [54.239.6.186] (helo=[192.168.1.238]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oyHIu-0006DP-W7; Thu, 24 Nov 2022 18:50:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=quuE02vogMuiDZiAXQUyR695Sh6wYPgHfrStJ3fHoo8=; b=ZaCDEi9/ZnMDe2wGmyGbW63DPc G58vOtqatJabvoLduBvGhfmLoFo1YWgwY/n1r2UDYsCn5W/DiJqMhNnTrMlHLSm4Je/NQUgvqA7vJ a4s24EZrKcjmWKi+UewCKHgEzjdzWX8VOBR02UcX+GLiEiB9zFPsPzne2qxjy80mS2pw=; Message-ID: Date: Thu, 24 Nov 2022 19:50:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [XEN v3 02/12] xen/Arm: GICv3: Adapt access to VMPIDR register for AArch32 Content-Language: en-US To: Michal Orzel , Ayan Kumar Halder , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, stefanos@xilinx.com, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com, jgrall@amazon.com, burzalodowa@gmail.com References: <20221111141739.2872-1-ayan.kumar.halder@amd.com> <20221111141739.2872-3-ayan.kumar.halder@amd.com> <8086e3ac-445b-17a1-bba3-078024ab2579@amd.com> <4045f91a-620a-98b0-d3c7-28af1b0ba4a8@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 23/11/2022 10:35, Michal Orzel wrote: > Hi Julien, > > On 22/11/2022 21:31, Julien Grall wrote: >> >> >> On 17/11/2022 13:39, Michal Orzel wrote: >>> Hi Ayan, >>> >>> On 11/11/2022 15:17, Ayan Kumar Halder wrote: >>>> Refer ARM DDI 0487I.a ID081822, G8-9817, G8.2.169 >>>> Affinity level 3 is not present in AArch32. >>>> Also, refer ARM DDI 0406C.d ID040418, B4-1644, B4.1.106, >>>> Affinity level 3 is not present in Armv7 (ie arm32). >>>> Thus, any access to affinity level 3 needs to be guarded within >>>> "ifdef CONFIG_ARM_64". >>>> >>>> Signed-off-by: Ayan Kumar Halder >>> Reviewed-by: Michal Orzel >>> >>> although, IMO the commit msg does not reflect the change (i.e. you do nothing >>> related to accessing MPIDR, but instead you are just not taking the Aff3 into account for AArch32). >>> Also, I'm not sure why you used VMPIDR and not MPIDR. >> >> +1. Can one of you propose an improved commit message/title? > Title: "Do not calculate affinity level 3 for AArch32" Sounds good to me. > > I think the commit message can stay as it is. >> >> I would be happy to update the patch on commit if there are nothing else >> to update in this series. > The series requires re-spinning anyway so no need to update the patch on commit. Fine with that. Cheers, -- Julien Grall