From: Jan Kiszka <jan.kiszka@siemens.com>
To: "florian.bezdeka@siemens.com" <florian.bezdeka@siemens.com>,
"xenomai@xenomai.org" <xenomai@xenomai.org>,
song <chensong@tj.kylinos.cn>
Subject: Re: [PATCH v2 3/3] cobalt uapi: Introducing new feature flag for time64 availability
Date: Fri, 11 Dec 2020 07:41:01 +0100 [thread overview]
Message-ID: <dc946872-4e9a-11fd-d5f6-20413b9ba90d@siemens.com> (raw)
In-Reply-To: <20201116140641.72027-4-florian.bezdeka@siemens.com>
On 16.11.20 15:07, florian.bezdeka--- via Xenomai wrote:
> From: Florian Bezdeka <florian.bezdeka@siemens.com>
>
> Adding a new feature flag to allow the library asking for time64
> support. That will allow the library to use the new system calls when
> available / supported by the kernel.
>
> The feature flag should be removed during next ABI revision bump.
>
> Signed-off-by: Florian Bezdeka <florian.bezdeka@siemens.com>
> ---
> include/cobalt/uapi/asm-generic/features.h | 6 +++++-
> .../cobalt/arch/arm64/include/asm/xenomai/uapi/features.h | 1 +
> .../cobalt/arch/powerpc/include/asm/xenomai/uapi/features.h | 1 +
> kernel/cobalt/arch/x86/include/asm/xenomai/uapi/features.h | 1 +
> 4 files changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/include/cobalt/uapi/asm-generic/features.h b/include/cobalt/uapi/asm-generic/features.h
> index 8a4927c49..705729aae 100644
> --- a/include/cobalt/uapi/asm-generic/features.h
> +++ b/include/cobalt/uapi/asm-generic/features.h
> @@ -51,6 +51,7 @@ struct cobalt_featinfo {
> #define __xn_feat_nofastsynch 0x10000000
> #define __xn_feat_control 0x08000000
> #define __xn_feat_prioceiling 0x04000000
> +#define __xn_feat_time64 0x02000000
>
> #ifdef CONFIG_SMP
> #define __xn_feat_smp_mask __xn_feat_smp
> @@ -70,7 +71,8 @@ struct cobalt_featinfo {
> #define __xn_feat_generic_mask \
> (__xn_feat_smp_mask | \
> __xn_feat_fastsynch_mask | \
> - __xn_feat_prioceiling)
> + __xn_feat_prioceiling | \
> + __xn_feat_time64)
>
> /*
> * List of features both sides have to agree on: If userland supports
> @@ -101,6 +103,8 @@ const char *get_generic_feature_label(unsigned int feature)
> return "control";
> case __xn_feat_prioceiling:
> return "prioceiling";
> + case __xn_feat_time64:
> + return "time64";
> default:
> return 0;
> }
> diff --git a/kernel/cobalt/arch/arm64/include/asm/xenomai/uapi/features.h b/kernel/cobalt/arch/arm64/include/asm/xenomai/uapi/features.h
> index 74423f68b..f03f483f6 100644
> --- a/kernel/cobalt/arch/arm64/include/asm/xenomai/uapi/features.h
> +++ b/kernel/cobalt/arch/arm64/include/asm/xenomai/uapi/features.h
> @@ -22,6 +22,7 @@
> #define _COBALT_ARM64_ASM_UAPI_FEATURES_H
>
> /* The ABI revision level we use on this arch. */
> +// TODO: Reminder: Remove __xn_feat_time64 feature flag on next ABI_REV bump
> #define XENOMAI_ABI_REV 1UL
>
> #define XENOMAI_FEAT_DEP (__xn_feat_generic_mask)
> diff --git a/kernel/cobalt/arch/powerpc/include/asm/xenomai/uapi/features.h b/kernel/cobalt/arch/powerpc/include/asm/xenomai/uapi/features.h
> index f6e67d884..db6dbed24 100644
> --- a/kernel/cobalt/arch/powerpc/include/asm/xenomai/uapi/features.h
> +++ b/kernel/cobalt/arch/powerpc/include/asm/xenomai/uapi/features.h
> @@ -19,6 +19,7 @@
> #define _COBALT_POWERPC_ASM_UAPI_FEATURES_H
>
> /* The ABI revision level we use on this arch. */
> +// TODO: Reminder: Remove __xn_feat_time64 feature flag on next ABI_REV bump
> #define XENOMAI_ABI_REV 17UL
>
> #define XENOMAI_FEAT_DEP __xn_feat_generic_mask
> diff --git a/kernel/cobalt/arch/x86/include/asm/xenomai/uapi/features.h b/kernel/cobalt/arch/x86/include/asm/xenomai/uapi/features.h
> index 67c7625f8..30539a5d1 100644
> --- a/kernel/cobalt/arch/x86/include/asm/xenomai/uapi/features.h
> +++ b/kernel/cobalt/arch/x86/include/asm/xenomai/uapi/features.h
> @@ -19,6 +19,7 @@
> #define _COBALT_X86_ASM_UAPI_FEATURES_H
>
> /* The ABI revision level we use on this arch. */
> +// TODO: Reminder: Remove __xn_feat_time64 feature flag on next ABI_REV bump
> #define XENOMAI_ABI_REV 17UL
>
> #define XENOMAI_FEAT_DEP __xn_feat_generic_mask
>
There is a larger pile of refactorings sitting in Philippe's queue that
likely require us to move to 3.2 rather sooner than later. Therefore I'm
pulling this our until we have the patches that add time32 also to 3.1.
The other changes can stay, though.
Jan
--
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux
next prev parent reply other threads:[~2020-12-11 6:41 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-03 3:05 [PATCH 5/5] lib/cobalt/clock.c:dispatch clock_settime chensong
2020-11-10 10:24 ` Jan Kiszka
2020-11-11 3:55 ` chensong
2020-11-11 7:29 ` Jan Kiszka
2020-11-11 9:23 ` chensong
2020-11-11 9:43 ` Jan Kiszka
2020-11-11 10:13 ` chensong
2020-11-13 11:47 ` Florian Bezdeka
2020-11-13 11:56 ` Jan Kiszka
2020-11-13 11:59 ` [PATCH 0/3] Make offered kernel features accessible during florian.bezdeka
2020-11-13 12:00 ` [PATCH 1/3] cobalt uapi: Introducing new feature flag for settime64 availability florian.bezdeka
2020-11-13 13:25 ` Jan Kiszka
2020-11-13 16:18 ` florian.bezdeka
2020-11-14 7:33 ` Jan Kiszka
2020-11-14 6:57 ` song
2020-11-14 7:32 ` Jan Kiszka
2020-11-14 7:50 ` song
2020-11-16 14:07 ` [PATCH v2 0/3] Make offered kernel features accessible during florian.bezdeka
2020-11-16 14:07 ` [PATCH v2 1/3] lib/cobalt: Rename cobalt_check_features to cobalt_arch_check_features florian.bezdeka
2020-11-16 14:07 ` [PATCH v2 3/3] cobalt uapi: Introducing new feature flag for time64 availability florian.bezdeka
2020-12-11 6:41 ` Jan Kiszka [this message]
2020-11-16 14:07 ` [PATCH v2 2/3] lib/cobalt: Introduce generic feature initialization and check API florian.bezdeka
2020-11-17 4:31 ` song
2020-11-17 8:29 ` florian.bezdeka
2020-11-17 8:43 ` song
2020-11-17 14:28 ` Jan Kiszka
2020-11-13 12:00 ` [PATCH 2/3] lib/cobalt: Rename cobalt_check_features to cobalt_arch_check_features florian.bezdeka
2020-11-13 12:00 ` [PATCH 3/3] lib/cobalt: Introduce generic feature initialization and check API florian.bezdeka
2020-11-13 13:25 ` Jan Kiszka
2020-11-13 16:10 ` florian.bezdeka
2020-11-14 7:04 ` [PATCH 5/5] lib/cobalt/clock.c:dispatch clock_settime song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc946872-4e9a-11fd-d5f6-20413b9ba90d@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=chensong@tj.kylinos.cn \
--cc=florian.bezdeka@siemens.com \
--cc=xenomai@xenomai.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.