From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx08-00178001.pphosted.com ([91.207.212.93]:26186 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756551AbcK3P3S (ORCPT ); Wed, 30 Nov 2016 10:29:18 -0500 From: Vincent ABRIOU To: Laurent Pinchart , "dri-devel@lists.freedesktop.org" CC: "linux-renesas-soc@vger.kernel.org" , Archit Taneja , Dae , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , CK Hu , Philipp Zabel , Benjamin Gaignard Date: Wed, 30 Nov 2016 16:28:52 +0100 Subject: Re: [PATCH v3 11/13] drm: Set on-chip bridges' encoder type Message-ID: References: <1480410283-28698-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> <1480410283-28698-12-git-send-email-laurent.pinchart+renesas@ideasonboard.com> In-Reply-To: <1480410283-28698-12-git-send-email-laurent.pinchart+renesas@ideasonboard.com> Content-Language: en-US Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: On 11/29/2016 10:04 AM, Laurent Pinchart wrote: > Initialize the new drm_bridge::encoder_type field to the right value for > all bridges that model on-SoC IP cores. > > Signed-off-by: Laurent Pinchart > --- > drivers/gpu/drm/exynos/exynos_drm_mic.c | 2 ++ > drivers/gpu/drm/mediatek/mtk_hdmi.c | 2 ++ > drivers/gpu/drm/sti/sti_dvo.c | 2 ++ > 3 files changed, 6 insertions(+) > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_mic.c b/drivers/gpu/drm/exynos/exynos_drm_mic.c > index a0def0be6d65..7175ecda36e8 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_mic.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_mic.c > @@ -390,6 +390,8 @@ static int exynos_mic_bind(struct device *dev, struct device *master, > mic->bridge.funcs = &mic_bridge_funcs; > mic->bridge.of_node = dev->of_node; > mic->bridge.driver_private = mic; > + mic->bridge.encoder_type = DRM_MODE_ENCODER_DSI; > + > ret = drm_bridge_add(&mic->bridge); > if (ret) > DRM_ERROR("mic: Failed to add MIC to the global bridge list\n"); > diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c > index 5ca1b0fbf937..bb5cf594c721 100644 > --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c > +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c > @@ -1712,6 +1712,8 @@ static int mtk_drm_hdmi_probe(struct platform_device *pdev) > > hdmi->bridge.funcs = &mtk_hdmi_bridge_funcs; > hdmi->bridge.of_node = pdev->dev.of_node; > + hdmi->bridge.encoder_type = DRM_MODE_ENCODER_TMDS; > + > ret = drm_bridge_add(&hdmi->bridge); > if (ret) { > dev_err(dev, "failed to add bridge, ret = %d\n", ret); > diff --git a/drivers/gpu/drm/sti/sti_dvo.c b/drivers/gpu/drm/sti/sti_dvo.c > index 411dc6ec976e..8912c932078f 100644 > --- a/drivers/gpu/drm/sti/sti_dvo.c > +++ b/drivers/gpu/drm/sti/sti_dvo.c > @@ -472,6 +472,8 @@ static int sti_dvo_bind(struct device *dev, struct device *master, void *data) > bridge->driver_private = dvo; > bridge->funcs = &sti_dvo_bridge_funcs; > bridge->of_node = dvo->dev.of_node; > + bridge->encoder_type = DRM_MODE_ENCODER_LVDS; > + > err = drm_bridge_add(bridge); > if (err) { > DRM_ERROR("Failed to add bridge\n"); For the sti dvo part: Acked-by: Vincent Abriou Vincent > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vincent ABRIOU Subject: Re: [PATCH v3 11/13] drm: Set on-chip bridges' encoder type Date: Wed, 30 Nov 2016 16:28:52 +0100 Message-ID: References: <1480410283-28698-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> <1480410283-28698-12-git-send-email-laurent.pinchart+renesas@ideasonboard.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mx07-00178001.pphosted.com (mx08-00178001.pphosted.com [91.207.212.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id B37AF6E112 for ; Wed, 30 Nov 2016 15:29:01 +0000 (UTC) In-Reply-To: <1480410283-28698-12-git-send-email-laurent.pinchart+renesas@ideasonboard.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Laurent Pinchart , "dri-devel@lists.freedesktop.org" Cc: Seung-Woo Kim , "linux-renesas-soc@vger.kernel.org" , Kyungmin Park List-Id: dri-devel@lists.freedesktop.org CgpPbiAxMS8yOS8yMDE2IDEwOjA0IEFNLCBMYXVyZW50IFBpbmNoYXJ0IHdyb3RlOgo+IEluaXRp YWxpemUgdGhlIG5ldyBkcm1fYnJpZGdlOjplbmNvZGVyX3R5cGUgZmllbGQgdG8gdGhlIHJpZ2h0 IHZhbHVlIGZvcgo+IGFsbCBicmlkZ2VzIHRoYXQgbW9kZWwgb24tU29DIElQIGNvcmVzLgo+Cj4g U2lnbmVkLW9mZi1ieTogTGF1cmVudCBQaW5jaGFydCA8bGF1cmVudC5waW5jaGFydCtyZW5lc2Fz QGlkZWFzb25ib2FyZC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9leHlub3MvZXh5bm9z X2RybV9taWMuYyB8IDIgKysKPiAgZHJpdmVycy9ncHUvZHJtL21lZGlhdGVrL210a19oZG1pLmMg ICAgIHwgMiArKwo+ICBkcml2ZXJzL2dwdS9kcm0vc3RpL3N0aV9kdm8uYyAgICAgICAgICAgfCAy ICsrCj4gIDMgZmlsZXMgY2hhbmdlZCwgNiBpbnNlcnRpb25zKCspCj4KPiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9ncHUvZHJtL2V4eW5vcy9leHlub3NfZHJtX21pYy5jIGIvZHJpdmVycy9ncHUvZHJt L2V4eW5vcy9leHlub3NfZHJtX21pYy5jCj4gaW5kZXggYTBkZWYwYmU2ZDY1Li43MTc1ZWNkYTM2 ZTggMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2V4eW5vcy9leHlub3NfZHJtX21pYy5j Cj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2V4eW5vcy9leHlub3NfZHJtX21pYy5jCj4gQEAgLTM5 MCw2ICszOTAsOCBAQCBzdGF0aWMgaW50IGV4eW5vc19taWNfYmluZChzdHJ1Y3QgZGV2aWNlICpk ZXYsIHN0cnVjdCBkZXZpY2UgKm1hc3RlciwKPiAgCW1pYy0+YnJpZGdlLmZ1bmNzID0gJm1pY19i cmlkZ2VfZnVuY3M7Cj4gIAltaWMtPmJyaWRnZS5vZl9ub2RlID0gZGV2LT5vZl9ub2RlOwo+ICAJ bWljLT5icmlkZ2UuZHJpdmVyX3ByaXZhdGUgPSBtaWM7Cj4gKwltaWMtPmJyaWRnZS5lbmNvZGVy X3R5cGUgPSBEUk1fTU9ERV9FTkNPREVSX0RTSTsKPiArCj4gIAlyZXQgPSBkcm1fYnJpZGdlX2Fk ZCgmbWljLT5icmlkZ2UpOwo+ICAJaWYgKHJldCkKPiAgCQlEUk1fRVJST1IoIm1pYzogRmFpbGVk IHRvIGFkZCBNSUMgdG8gdGhlIGdsb2JhbCBicmlkZ2UgbGlzdFxuIik7Cj4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfaGRtaS5jIGIvZHJpdmVycy9ncHUvZHJtL21l ZGlhdGVrL210a19oZG1pLmMKPiBpbmRleCA1Y2ExYjBmYmY5MzcuLmJiNWNmNTk0YzcyMSAxMDA2 NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2hkbWkuYwo+ICsrKyBiL2Ry aXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfaGRtaS5jCj4gQEAgLTE3MTIsNiArMTcxMiw4IEBA IHN0YXRpYyBpbnQgbXRrX2RybV9oZG1pX3Byb2JlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBk ZXYpCj4KPiAgCWhkbWktPmJyaWRnZS5mdW5jcyA9ICZtdGtfaGRtaV9icmlkZ2VfZnVuY3M7Cj4g IAloZG1pLT5icmlkZ2Uub2Zfbm9kZSA9IHBkZXYtPmRldi5vZl9ub2RlOwo+ICsJaGRtaS0+YnJp ZGdlLmVuY29kZXJfdHlwZSA9IERSTV9NT0RFX0VOQ09ERVJfVE1EUzsKPiArCj4gIAlyZXQgPSBk cm1fYnJpZGdlX2FkZCgmaGRtaS0+YnJpZGdlKTsKPiAgCWlmIChyZXQpIHsKPiAgCQlkZXZfZXJy KGRldiwgImZhaWxlZCB0byBhZGQgYnJpZGdlLCByZXQgPSAlZFxuIiwgcmV0KTsKPiBkaWZmIC0t Z2l0IGEvZHJpdmVycy9ncHUvZHJtL3N0aS9zdGlfZHZvLmMgYi9kcml2ZXJzL2dwdS9kcm0vc3Rp L3N0aV9kdm8uYwo+IGluZGV4IDQxMWRjNmVjOTc2ZS4uODkxMmM5MzIwNzhmIDEwMDY0NAo+IC0t LSBhL2RyaXZlcnMvZ3B1L2RybS9zdGkvc3RpX2R2by5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJt L3N0aS9zdGlfZHZvLmMKPiBAQCAtNDcyLDYgKzQ3Miw4IEBAIHN0YXRpYyBpbnQgc3RpX2R2b19i aW5kKHN0cnVjdCBkZXZpY2UgKmRldiwgc3RydWN0IGRldmljZSAqbWFzdGVyLCB2b2lkICpkYXRh KQo+ICAJYnJpZGdlLT5kcml2ZXJfcHJpdmF0ZSA9IGR2bzsKPiAgCWJyaWRnZS0+ZnVuY3MgPSAm c3RpX2R2b19icmlkZ2VfZnVuY3M7Cj4gIAlicmlkZ2UtPm9mX25vZGUgPSBkdm8tPmRldi5vZl9u b2RlOwo+ICsJYnJpZGdlLT5lbmNvZGVyX3R5cGUgPSBEUk1fTU9ERV9FTkNPREVSX0xWRFM7Cj4g Kwo+ICAJZXJyID0gZHJtX2JyaWRnZV9hZGQoYnJpZGdlKTsKPiAgCWlmIChlcnIpIHsKPiAgCQlE Uk1fRVJST1IoIkZhaWxlZCB0byBhZGQgYnJpZGdlXG4iKTsKCkZvciB0aGUgc3RpIGR2byBwYXJ0 OgpBY2tlZC1ieTogVmluY2VudCBBYnJpb3UgPHZpbmNlbnQuYWJyaW91QHN0LmNvbT4KClZpbmNl bnQKPgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmkt ZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK