All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	Stephen Boyd <sboyd@kernel.org>
Cc: Andy Gross <agross@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Olof Johansson <olof@lixom.net>, Rob Herring <robh@kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	linux-arm-msm <linux-arm-msm@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Removal of qcom,board-id and qcom,msm-id
Date: Fri, 20 May 2022 09:00:42 +0200	[thread overview]
Message-ID: <dcc36d60-23fe-57d6-f85e-c51dc0da71a0@linaro.org> (raw)
In-Reply-To: <CAA8EJpqjcAcoooaZ6iTSCy4B1x4=HTUgvJ4VqX_Fr_hSMEbfDA@mail.gmail.com>

On 20/05/2022 03:39, Dmitry Baryshkov wrote:
>> I vaguely recall that the properties had to be extracted during the
>> boot.img creation process to create a table of contents header. But
>> after some time the bootloader started scanning the DTBs directly for
>> the vendor properties and thus the header was deprecated/removed. If the
>> bootloader is doing the scanning then I'm not sure what is preventing
>> the properties from being documented and allowed. I think the main
>> rejection was that the properties were added purely to be extracted
>> during post processing and placed into the table of contents header,
>> i.e. they weren't actually used by the kernel or the bootloader. If they
>> are now used by the bootloader it sounds OK to me if they're kept
>> around.
> 
> Yes, as far as I understand, they are used by the bootloader directly.

This solves only one part of concern form previous discussions - having
entries not used by anything. Kernel still don't use them but some
vendor bootloader (not U-boot) does.

The second problem with these is still not solved - these duplicate what
is already described by compatible. Basically, they do not add any new
hardware description, because board or SoC revision should be encoded
into the compatible. Imagine now adding such "vendor,device-id"
properties to every device node in DTS!

Best regards,
Krzysztof

  reply	other threads:[~2022-05-20  7:01 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-19 10:44 Removal of qcom,board-id and qcom,msm-id Krzysztof Kozlowski
2022-05-19 11:39 ` Dmitry Baryshkov
2022-05-19 11:53   ` Krzysztof Kozlowski
2022-05-19 12:46     ` Dmitry Baryshkov
     [not found]       ` <20220519221227.B66D3C385AA@smtp.kernel.org>
2022-05-20  1:39         ` Dmitry Baryshkov
2022-05-20  7:00           ` Krzysztof Kozlowski [this message]
2022-05-22 10:26           ` Krzysztof Kozlowski
2022-05-22 10:50             ` Dmitry Baryshkov
2022-05-22 19:51 ` Konrad Dybcio
2022-05-23  5:41   ` Amit Pundir
2022-05-23  7:21   ` Krzysztof Kozlowski
2022-05-23 12:02     ` Konrad Dybcio
2022-05-23 12:14       ` Krzysztof Kozlowski
2022-05-23 15:29         ` Konrad Dybcio
2022-05-23 16:41         ` Trilok Soni
2022-05-23 21:34           ` Bjorn Andersson
2022-05-23 22:13             ` Trilok Soni
2022-05-23 21:29     ` Rob Clark
2022-05-23 21:50     ` Bjorn Andersson
2022-05-23 22:18       ` Dmitry Baryshkov
2022-05-25 17:36         ` Stephan Gerhold
2022-05-26  7:16       ` Krzysztof Kozlowski
2022-06-22  8:21   ` Dmitry Baryshkov
2022-06-22 11:53     ` Konrad Dybcio
2022-06-23  9:55       ` Dmitry Baryshkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dcc36d60-23fe-57d6-f85e-c51dc0da71a0@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=agross@kernel.org \
    --cc=arnd@arndb.de \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=olof@lixom.net \
    --cc=robh@kernel.org \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.