All of lore.kernel.org
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Johannes Berg <johannes@sipsolutions.net>, linux-pci@vger.kernel.org
Cc: Jonathan Derrick <jonathan.derrick@intel.com>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	linux-um@lists.infradead.org,
	Johannes Berg <johannes.berg@intel.com>
Subject: Re: [PATCH] PCI: vmd: depend on !UML
Date: Wed, 11 Aug 2021 08:43:44 -0700	[thread overview]
Message-ID: <dcd547a5-3ebc-3034-2614-d60000fc1594@infradead.org> (raw)
In-Reply-To: <20210811162530.affe26231bc3.I131b3c1e67e3d2ead6e98addd256c835fbef9a3e@changeid>

On 8/11/21 7:25 AM, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
> 
> With UML having enabled (simulated) PCI on UML, VMD breaks
> allyesconfig/allmodconfig compilation because it assumes
> it's running on X86_64 bare metal, and has hardcoded API
> use of ARCH=x86. Make it depend on !UML to fix this.
> 
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> ---
>   drivers/pci/controller/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/controller/Kconfig b/drivers/pci/controller/Kconfig
> index 64e2f5e379aa..297bbd86806a 100644
> --- a/drivers/pci/controller/Kconfig
> +++ b/drivers/pci/controller/Kconfig
> @@ -257,7 +257,7 @@ config PCIE_TANGO_SMP8759
>   	  config and MMIO accesses.
>   
>   config VMD
> -	depends on PCI_MSI && X86_64 && SRCU
> +	depends on PCI_MSI && X86_64 && SRCU && !UML
>   	tristate "Intel Volume Management Device Driver"
>   	help
>   	  Adds support for the Intel Volume Management Device (VMD). VMD is a
> 

Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested

Thanks.

-- 
~Randy


  parent reply	other threads:[~2021-08-11 15:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-11 14:25 [PATCH] PCI: vmd: depend on !UML Johannes Berg
2021-08-11 14:43 ` Derrick, Jonathan
2021-08-11 14:43   ` Derrick, Jonathan
2021-10-08 21:37   ` Randy Dunlap
2021-08-11 15:43 ` Randy Dunlap [this message]
2021-10-13 14:13 ` Lorenzo Pieralisi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dcd547a5-3ebc-3034-2614-d60000fc1594@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=geert@linux-m68k.org \
    --cc=johannes.berg@intel.com \
    --cc=johannes@sipsolutions.net \
    --cc=jonathan.derrick@intel.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-um@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.