From: Vlastimil Babka <vbabka@suse.cz>
To: Hyeonggon Yoo <42.hyeyoo@gmail.com>
Cc: Kees Cook <kees@kernel.org>, Christoph Lameter <cl@linux.com>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Pekka Enberg <penberg@kernel.org>,
Roman Gushchin <roman.gushchin@linux.dev>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Matthew Wilcox <willy@infradead.org>,
patches@lists.linux.dev, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH 01/12] mm, slab: ignore hardened usercopy parameters when disabled
Date: Thu, 24 Nov 2022 12:26:41 +0100 [thread overview]
Message-ID: <dcde302f-faa7-5e55-1e67-f8c7386119d4@suse.cz> (raw)
In-Reply-To: <Y39Sq8vReXouviyn@hyeyoo>
On 11/24/22 12:16, Hyeonggon Yoo wrote:
>> /* Fail closed on bad usersize of useroffset values. */
>> - if (WARN_ON(!usersize && useroffset) ||
>> + if (!IS_ENABLED(CONFIG_HARDENED_USERCOPY) ||
>> + WARN_ON(!usersize && useroffset) ||
>> WARN_ON(size < usersize || size - usersize < useroffset))
>> usersize = useroffset = 0;
>
> I think this change is no longer needed as slab_unmergeable()
> now does not check usersize when CONFIG_HARDENED_USERCOPY=n?
True, but the code here still follows by
if (!usersize)
s = __kmem_cache_alias(name, size, align, flags, ctor);
So it seemed simplest just to leave it like that.
next prev parent reply other threads:[~2022-11-24 11:26 UTC|newest]
Thread overview: 102+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-21 17:11 [PATCH 00/12] Introduce CONFIG_SLUB_TINY and deprecate SLOB Vlastimil Babka
2022-11-21 17:11 ` Vlastimil Babka
2022-11-21 17:11 ` Vlastimil Babka
2022-11-21 17:11 ` Vlastimil Babka
2022-11-21 17:11 ` [PATCH 01/12] mm, slab: ignore hardened usercopy parameters when disabled Vlastimil Babka
2022-11-21 21:35 ` Kees Cook
2022-11-23 14:23 ` Vlastimil Babka
2022-11-24 11:16 ` Hyeonggon Yoo
2022-11-24 11:26 ` Vlastimil Babka [this message]
2022-11-24 12:33 ` Hyeonggon Yoo
2022-11-21 17:11 ` [PATCH 02/12] mm, slub: add CONFIG_SLUB_TINY Vlastimil Babka
2022-11-24 1:08 ` Roman Gushchin
2022-11-24 11:33 ` Hyeonggon Yoo
2022-11-25 7:55 ` Vlastimil Babka
2022-11-21 17:11 ` [PATCH 03/12] mm, slub: disable SYSFS support with CONFIG_SLUB_TINY Vlastimil Babka
2022-11-24 1:12 ` Roman Gushchin
2022-11-24 9:00 ` Vlastimil Babka
2022-11-21 17:11 ` [PATCH 04/12] mm, slub: retain no free slabs on partial list " Vlastimil Babka
2022-11-24 1:12 ` Roman Gushchin
2022-11-24 11:38 ` Hyeonggon Yoo
2022-11-21 17:11 ` [PATCH 05/12] mm, slub: lower the default slub_max_order " Vlastimil Babka
2022-11-24 1:16 ` Roman Gushchin
2022-11-24 11:40 ` Hyeonggon Yoo
2022-11-21 17:11 ` [PATCH 06/12] mm, slub: don't create kmalloc-rcl caches " Vlastimil Babka
2022-11-23 13:53 ` Vlastimil Babka
2022-11-24 12:06 ` Hyeonggon Yoo
2022-11-24 12:12 ` Vlastimil Babka
2022-11-24 12:55 ` Hyeonggon Yoo
2022-11-24 13:23 ` Hyeonggon Yoo
2022-11-24 14:25 ` Hyeonggon Yoo
2022-11-21 17:11 ` [PATCH 07/12] mm, slab: ignore SLAB_RECLAIM_ACCOUNT " Vlastimil Babka
2022-11-24 1:20 ` Roman Gushchin
2022-11-24 9:09 ` Vlastimil Babka
2022-11-24 9:21 ` Christoph Lameter
2022-11-27 23:11 ` Vlastimil Babka
2022-11-21 17:11 ` [PATCH 08/12] mm, slub: refactor free debug processing Vlastimil Babka
2022-11-27 10:18 ` Hyeonggon Yoo
2022-11-21 17:11 ` [PATCH 09/12] mm, slub: split out allocations from pre/post hooks Vlastimil Babka
2022-11-27 10:54 ` Hyeonggon Yoo
2022-11-27 23:01 ` Vlastimil Babka
2022-11-28 13:06 ` Hyeonggon Yoo
2022-11-21 17:12 ` [PATCH 10/12] mm, slub: remove percpu slabs with CONFIG_SLUB_TINY Vlastimil Babka
2022-11-27 11:05 ` Hyeonggon Yoo
2022-12-12 10:54 ` Vlastimil Babka
2022-12-12 13:11 ` Dennis Zhou
2022-12-13 3:04 ` Baoquan He
2022-12-13 14:02 ` Hyeonggon Yoo
2022-12-18 10:16 ` Hyeonggon Yoo
2022-11-21 17:12 ` [PATCH 11/12] mm, slub: don't aggressively inline " Vlastimil Babka
2022-11-28 13:19 ` Hyeonggon Yoo
2022-11-21 17:12 ` [PATCH 12/12] mm, slob: rename CONFIG_SLOB to CONFIG_SLOB_DEPRECATED Vlastimil Babka
2022-11-21 17:12 ` Vlastimil Babka
2022-11-21 17:12 ` Vlastimil Babka
2022-11-21 17:12 ` Vlastimil Babka
2022-11-21 18:41 ` Aaro Koskinen
2022-11-21 18:41 ` Aaro Koskinen
2022-11-21 18:41 ` Aaro Koskinen
2022-11-21 18:41 ` Aaro Koskinen
2022-11-21 19:42 ` Vlastimil Babka
2022-11-21 19:42 ` Vlastimil Babka
2022-11-21 19:42 ` Vlastimil Babka
2022-11-21 19:42 ` Vlastimil Babka
2022-11-22 6:47 ` Damien Le Moal
2022-11-22 6:47 ` Damien Le Moal
2022-11-22 6:47 ` Damien Le Moal
2022-11-22 6:47 ` Damien Le Moal
2022-11-22 16:08 ` Arnd Bergmann
2022-11-22 16:08 ` Arnd Bergmann
2022-11-22 16:08 ` Arnd Bergmann
2022-11-22 16:08 ` Arnd Bergmann
2022-11-24 1:21 ` Roman Gushchin
2022-11-24 1:21 ` Roman Gushchin
2022-11-24 1:21 ` Roman Gushchin
2022-11-24 1:21 ` Roman Gushchin
2022-12-02 17:59 ` Palmer Dabbelt
2022-12-02 17:59 ` Palmer Dabbelt
2022-12-02 17:59 ` Palmer Dabbelt
2022-12-02 17:59 ` Palmer Dabbelt
2022-12-05 12:25 ` Damien Le Moal
2022-12-05 12:25 ` Damien Le Moal
2022-12-05 12:25 ` Damien Le Moal
2022-12-05 12:25 ` Damien Le Moal
2022-12-13 13:41 ` Hyeonggon Yoo
2022-12-13 13:41 ` Hyeonggon Yoo
2022-12-13 13:41 ` Hyeonggon Yoo
2022-12-13 13:41 ` Hyeonggon Yoo
2022-11-22 16:33 ` [PATCH 00/12] Introduce CONFIG_SLUB_TINY and deprecate SLOB Arnd Bergmann
2022-11-22 16:33 ` Arnd Bergmann
2022-11-22 16:33 ` Arnd Bergmann
2022-11-22 16:33 ` Arnd Bergmann
2022-11-22 16:59 ` Vlastimil Babka
2022-11-22 16:59 ` Vlastimil Babka
2022-11-22 16:59 ` Vlastimil Babka
2022-11-22 16:59 ` Vlastimil Babka
2022-11-22 17:15 ` Arnd Bergmann
2022-11-22 17:15 ` Arnd Bergmann
2022-11-22 17:15 ` Arnd Bergmann
2022-11-22 17:15 ` Arnd Bergmann
2022-11-24 20:30 ` Mike Rapoport
2022-11-24 20:30 ` Mike Rapoport
2022-11-24 20:30 ` Mike Rapoport
2022-11-24 20:30 ` Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dcde302f-faa7-5e55-1e67-f8c7386119d4@suse.cz \
--to=vbabka@suse.cz \
--cc=42.hyeyoo@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=kees@kernel.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=patches@lists.linux.dev \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=torvalds@linux-foundation.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.