All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Ahern <dsa@cumulusnetworks.com>
To: Simon Horman <simon.horman@netronome.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
	buytenh@wantstofly.org, ebiederm@xmission.com,
	rshearma@brocade.com, tom@herbertland.com, tgraf@suug.ch,
	olivier.dugeon@orange.com, alexander.duyck@gmail.com,
	roopa@cumulusnetworks.com
Subject: Re: [PATCH net-next 2/3] net: mpls: Fixups for GSO
Date: Mon, 22 Aug 2016 07:11:27 -0600	[thread overview]
Message-ID: <dcf3df40-3914-37c6-55dc-e5c3de7530b5@cumulusnetworks.com> (raw)
In-Reply-To: <20160822122122.GA8689@penelope.isobedori.kobe.vergenet.net>

On 8/22/16 6:21 AM, Simon Horman wrote:
>> diff --git a/net/openvswitch/actions.c b/net/openvswitch/actions.c
>> index 1ecbd7715f6d..6d78f162a88b 100644
>> --- a/net/openvswitch/actions.c
>> +++ b/net/openvswitch/actions.c
>> @@ -167,6 +167,12 @@ static int push_mpls(struct sk_buff *skb, struct sw_flow_key *key,
>>  		skb->mac_len);
>>  	skb_reset_mac_header(skb);
>>  
>> +	/* for GSO: set MPLS as network header and encapsulated protocol
>> +	 * header as inner network header
>> +	 */
>> +	skb_set_network_header(skb, skb->mac_len);
>> +	skb_set_inner_network_header(skb, skb->mac_len + MPLS_HLEN);
>> +
>>  	new_mpls_lse = (__be32 *)skb_mpls_header(skb);
>>  	*new_mpls_lse = mpls->mpls_lse;
> 
> Is the above calculation correct if push_mpls() is called multiple times?
> 

No. Does OVS support more than 1? I really need someone who is familiar with the OVS code to make sure it works for all use cases. e.g., set skb_set_inner_network_header() before pushing a series of MPLS labels.

  reply	other threads:[~2016-08-22 13:11 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-19 17:08 [PATCH v3 net-next 0/3] net: mpls: fragmentation and gso fixes for locally originated traffic David Ahern
2016-08-19 17:09 ` [PATCH net-next 1/3] net: lwtunnel: Handle fragmentation David Ahern
2016-08-19 17:09 ` [PATCH net-next 2/3] net: mpls: Fixups for GSO David Ahern
2016-08-19 20:17   ` Alexander Duyck
2016-08-22 12:21   ` Simon Horman
2016-08-22 13:11     ` David Ahern [this message]
2016-08-22 14:51       ` Simon Horman
2016-08-23 19:24         ` David Ahern
2016-08-24  7:20           ` Simon Horman
2016-08-24 16:28             ` pravin shelar
2016-08-24 16:37               ` David Ahern
2016-08-24 17:41                 ` pravin shelar
2016-08-24 18:53                   ` David Ahern
2016-08-25  3:12                     ` David Ahern
2016-08-25  3:58                     ` pravin shelar
2016-09-26 15:56                 ` Jiri Benc
2016-09-26 17:02                   ` Jiri Benc
2016-09-27  2:04                     ` David Ahern
2016-09-27  7:45                       ` Jiri Benc
2016-09-27 16:38                         ` David Ahern
2016-09-27 16:45                           ` Jiri Benc
2016-08-19 17:09 ` [PATCH net-next 3/3] net: veth: Set features for MPLS David Ahern
  -- strict thread matches above, loose matches on Subject: below --
2016-08-17 21:49 [PATCH v2 net-next 0/3] net: mpls: fragmentation and gso fixes for locally originated traffic David Ahern
2016-08-17 21:49 ` [PATCH net-next 2/3] net: mpls: Fixups for GSO David Ahern
2016-08-17 23:16   ` Alexander Duyck
2016-08-17 23:23     ` David Ahern
2016-08-18  1:06       ` Alexander Duyck
2016-08-18  2:59         ` David Ahern
2016-08-18 14:37   ` Alexander Duyck
2016-08-18 16:18     ` David Ahern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dcf3df40-3914-37c6-55dc-e5c3de7530b5@cumulusnetworks.com \
    --to=dsa@cumulusnetworks.com \
    --cc=alexander.duyck@gmail.com \
    --cc=buytenh@wantstofly.org \
    --cc=davem@davemloft.net \
    --cc=ebiederm@xmission.com \
    --cc=netdev@vger.kernel.org \
    --cc=olivier.dugeon@orange.com \
    --cc=roopa@cumulusnetworks.com \
    --cc=rshearma@brocade.com \
    --cc=simon.horman@netronome.com \
    --cc=tgraf@suug.ch \
    --cc=tom@herbertland.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.