Re: [OE-core][PATCH] linux-dummy: add empty dependent packages

["Li Wang" <li.wang@windriver.com>]

[-- Attachment #1: Type: text/plain, Size: 3291 bytes --]

ping!

Thanks,
LiWang.

On 3/13/2021 05:48, Li Wang wrote:
>
> On 3/12/2021 20:44, Richard Purdie wrote:
>> On Fri, 2021-03-12 at 17:52 +0800, Li Wang wrote:
>>> some kernel includes kernel-image-image and kernel-devicetree packages.
>>> these patckages are defined in kernel.bbclass
>>> but, when use linux-dummy, these packages are not defined.
>>> so, define them as empty packages for avoiding compile error:
>>>
>>> ERROR: Nothing RPROVIDES 'kernel-devicetree'
>>>
>>> Signed-off-by: Li Wang <li.wang@windriver.com>
>>> ---
>>>   meta/classes/linux-dummy.bbclass         | 26 
>>> ++++++++++++++++++++++++++
>>>   meta/recipes-kernel/linux/linux-dummy.bb |  2 +-
>>>   2 files changed, 27 insertions(+), 1 deletion(-)
>>>   create mode 100644 meta/classes/linux-dummy.bbclass
>>>
>>> diff --git a/meta/classes/linux-dummy.bbclass 
>>> b/meta/classes/linux-dummy.bbclass
>>> new file mode 100644
>>> index 0000000..cd87915
>>> --- /dev/null
>>> +++ b/meta/classes/linux-dummy.bbclass
>>> @@ -0,0 +1,26 @@
>>> +
>>> +python __anonymous () {
>>> +    if d.getVar('PREFERRED_PROVIDER_virtual/kernel') == 'linux-dummy':
>>> +        # copy part codes from kernel.bbclass
>>> +        kname = d.getVar('KERNEL_PACKAGE_NAME') or "kernel"
>>> +
>>> +        # set an empty package of kernel-devicetree
>>> +        d.appendVar('PACKAGES', ' %s-devicetree' % kname)
>>> +        d.setVar('ALLOW_EMPTY_%s-devicetree' % kname, '1')
>>> +
>>> +        # Merge KERNEL_IMAGETYPE and KERNEL_ALT_IMAGETYPE into 
>>> KERNEL_IMAGETYPES
>>> +        type = d.getVar('KERNEL_IMAGETYPE') or ""
>>> +        alttype = d.getVar('KERNEL_ALT_IMAGETYPE') or ""
>>> +        types = d.getVar('KERNEL_IMAGETYPES') or ""
>>> +        if type not in types.split():
>>> +            types = (type + ' ' + types).strip()
>>> +        if alttype not in types.split():
>>> +            types = (alttype + ' ' + types).strip()
>>> +
>>> +        # set empty packages of kernel-image-*
>>> +        for type in types.split():
>>> +            typelower = type.lower()
>>> +            d.appendVar('PACKAGES', ' %s-image-%s' % (kname, 
>>> typelower))
>>> +            d.setVar('ALLOW_EMPTY_%s-image-%s' % (kname, 
>>> typelower), '1')
>>> +}
>>> +
>> Rather than generating broken empty packages, why not just set 
>> RPROVIDES_${PN}
>> with the appropriate things?
>
> linux-dummy is just an empty package, what does it PROVIDE the 
> appropriate things?
>
> linux-dummy has the similar codes:
>
> =====
>
> oe-core/meta/recipes-kernel/linux/linux-dummy.bb
>
> PACKAGES += "kernel-modules kernel-vmlinux"
> FILES_kernel-modules = ""
> ALLOW_EMPTY_kernel-modules = "1"
> DESCRIPTION_kernel-modules = "Kernel modules meta package"
> FILES_kernel-vmlinux = ""
> ALLOW_EMPTY_kernel-vmlinux = "1"
> DESCRIPTION_kernel-vmlinux = "Kernel vmlinux meta package"
>
> =====
>
> I can offer a more complete empty package as above sample.(FILES_* 
> DESCRIPTION_*)
>
> please give me some suggest about it.
>
> Thanks,
> LiWang.
>
>>
>> Cheers,
>>
>> Richard
>>
>
> 
>

[-- Attachment #2: Type: text/html, Size: 6258 bytes --]