From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DA7BC77B73 for ; Tue, 23 May 2023 03:22:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232127AbjEWDWX (ORCPT ); Mon, 22 May 2023 23:22:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39982 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229447AbjEWDWU (ORCPT ); Mon, 22 May 2023 23:22:20 -0400 Received: from out30-130.freemail.mail.aliyun.com (out30-130.freemail.mail.aliyun.com [115.124.30.130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3077190; Mon, 22 May 2023 20:22:17 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R131e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046050;MF=xueshuai@linux.alibaba.com;NM=1;PH=DS;RN=14;SR=0;TI=SMTPD_---0VjIKEmD_1684812131; Received: from 30.240.113.228(mailfrom:xueshuai@linux.alibaba.com fp:SMTPD_---0VjIKEmD_1684812131) by smtp.aliyun-inc.com; Tue, 23 May 2023 11:22:13 +0800 Message-ID: Date: Tue, 23 May 2023 11:22:08 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v5 2/4] PCI: move Alibaba Vendor ID linux/pci_ids.h Content-Language: en-US To: Bjorn Helgaas Cc: chengyou@linux.alibaba.com, kaishen@linux.alibaba.com, yangyicong@huawei.com, will@kernel.org, Jonathan.Cameron@huawei.com, baolin.wang@linux.alibaba.com, robin.murphy@arm.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, rdunlap@infradead.org, mark.rutland@arm.com, zhuo.song@linux.alibaba.com References: From: Shuai Xue In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023/5/23 00:04, Bjorn Helgaas wrote: > Please follow subject line capitalization style (learn it with "git > log --oneline include/linux/pci_ids.h"): > > PCI: Add Alibaba Vendor ID Sorry, I will rewrite the subject. > > On Mon, May 22, 2023 at 11:54:26AM +0800, Shuai Xue wrote: >> Move Alibaba Vendor ID (0x1ded) to linux/pci_ids.h so that it can shared by >> several drivers. > > It would be helpful for reviewers to list the drivers here, since only > one is obvious from the patch. Will add it. Then, the commit log should be: PCI: Add Alibaba Vendor ID to linux/pci_ids.h The Alibaba Vendor ID (0x1ded) is now only used by Alibaba elasticRDMA adapter driver. Move the Vendor ID to linux/pci_ids.h so that it can shared by several drivers later. > > Thanks for sorting the entry correctly! Aha, you are welcome :) Thank you for valuable comments. Best Regards, Shuai > >> Signed-off-by: Shuai Xue >> --- >> drivers/infiniband/hw/erdma/erdma_hw.h | 2 -- >> include/linux/pci_ids.h | 2 ++ >> 2 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/infiniband/hw/erdma/erdma_hw.h b/drivers/infiniband/hw/erdma/erdma_hw.h >> index 76ce2856be28..ee35ebef9ee7 100644 >> --- a/drivers/infiniband/hw/erdma/erdma_hw.h >> +++ b/drivers/infiniband/hw/erdma/erdma_hw.h >> @@ -11,8 +11,6 @@ >> #include >> >> /* PCIe device related definition. */ >> -#define PCI_VENDOR_ID_ALIBABA 0x1ded >> - >> #define ERDMA_PCI_WIDTH 64 >> #define ERDMA_FUNC_BAR 0 >> #define ERDMA_MISX_BAR 2 >> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h >> index 95f33dadb2be..9e8aec472f06 100644 >> --- a/include/linux/pci_ids.h >> +++ b/include/linux/pci_ids.h >> @@ -2586,6 +2586,8 @@ >> #define PCI_VENDOR_ID_TEKRAM 0x1de1 >> #define PCI_DEVICE_ID_TEKRAM_DC290 0xdc29 >> >> +#define PCI_VENDOR_ID_ALIBABA 0x1ded >> + >> #define PCI_VENDOR_ID_TEHUTI 0x1fc9 >> #define PCI_DEVICE_ID_TEHUTI_3009 0x3009 >> #define PCI_DEVICE_ID_TEHUTI_3010 0x3010 >> -- >> 2.20.1.12.g72788fdb >> >> >> _______________________________________________ >> linux-arm-kernel mailing list >> linux-arm-kernel@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 78752C7EE26 for ; Tue, 23 May 2023 03:22:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/QvmMYJs8OdyAZ9jF2np7akBz/X3hh/hQbaIv5Tkoo4=; b=ARVc5+P16GxzaH lBJMXUZ58yYglCMbTUZM3jwvMIAYbJ0KsW1nu2OPmdyMdzH4PjWImMrtrqSnRXF9I6ByiswCWSZor 8MQCe9CLEC4Mgng2sBbJEogf3RCartmS4Nw9b88dj/esPKPboG9eDJpAJHvnpu3Zsek7MBex7NmFs 0nhlLj3SJaNt8E3QhxALmY3M3cKaDjSISzaQxdSqMOt/vc8868zGOHmjhqbw5WXo9fB0YZg57wUNg 2ooIUdJ90zF4rncH3oRIh97fQgKLVuiRwtYt1e6XiGkKa/I9AMzPJpmFpniT2DhmQ+13wMRj04NDx TI1UFmrZcsheCw0C5XoA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q1IbP-008n4Z-06; Tue, 23 May 2023 03:22:23 +0000 Received: from out30-130.freemail.mail.aliyun.com ([115.124.30.130]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q1IbM-008n3V-0F for linux-arm-kernel@lists.infradead.org; Tue, 23 May 2023 03:22:21 +0000 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R131e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046050;MF=xueshuai@linux.alibaba.com;NM=1;PH=DS;RN=14;SR=0;TI=SMTPD_---0VjIKEmD_1684812131; Received: from 30.240.113.228(mailfrom:xueshuai@linux.alibaba.com fp:SMTPD_---0VjIKEmD_1684812131) by smtp.aliyun-inc.com; Tue, 23 May 2023 11:22:13 +0800 Message-ID: Date: Tue, 23 May 2023 11:22:08 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v5 2/4] PCI: move Alibaba Vendor ID linux/pci_ids.h Content-Language: en-US To: Bjorn Helgaas Cc: chengyou@linux.alibaba.com, kaishen@linux.alibaba.com, yangyicong@huawei.com, will@kernel.org, Jonathan.Cameron@huawei.com, baolin.wang@linux.alibaba.com, robin.murphy@arm.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, rdunlap@infradead.org, mark.rutland@arm.com, zhuo.song@linux.alibaba.com References: From: Shuai Xue In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230522_202220_277809_6A967BCC X-CRM114-Status: GOOD ( 15.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2023/5/23 00:04, Bjorn Helgaas wrote: > Please follow subject line capitalization style (learn it with "git > log --oneline include/linux/pci_ids.h"): > > PCI: Add Alibaba Vendor ID Sorry, I will rewrite the subject. > > On Mon, May 22, 2023 at 11:54:26AM +0800, Shuai Xue wrote: >> Move Alibaba Vendor ID (0x1ded) to linux/pci_ids.h so that it can shared by >> several drivers. > > It would be helpful for reviewers to list the drivers here, since only > one is obvious from the patch. Will add it. Then, the commit log should be: PCI: Add Alibaba Vendor ID to linux/pci_ids.h The Alibaba Vendor ID (0x1ded) is now only used by Alibaba elasticRDMA adapter driver. Move the Vendor ID to linux/pci_ids.h so that it can shared by several drivers later. > > Thanks for sorting the entry correctly! Aha, you are welcome :) Thank you for valuable comments. Best Regards, Shuai > >> Signed-off-by: Shuai Xue >> --- >> drivers/infiniband/hw/erdma/erdma_hw.h | 2 -- >> include/linux/pci_ids.h | 2 ++ >> 2 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/infiniband/hw/erdma/erdma_hw.h b/drivers/infiniband/hw/erdma/erdma_hw.h >> index 76ce2856be28..ee35ebef9ee7 100644 >> --- a/drivers/infiniband/hw/erdma/erdma_hw.h >> +++ b/drivers/infiniband/hw/erdma/erdma_hw.h >> @@ -11,8 +11,6 @@ >> #include >> >> /* PCIe device related definition. */ >> -#define PCI_VENDOR_ID_ALIBABA 0x1ded >> - >> #define ERDMA_PCI_WIDTH 64 >> #define ERDMA_FUNC_BAR 0 >> #define ERDMA_MISX_BAR 2 >> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h >> index 95f33dadb2be..9e8aec472f06 100644 >> --- a/include/linux/pci_ids.h >> +++ b/include/linux/pci_ids.h >> @@ -2586,6 +2586,8 @@ >> #define PCI_VENDOR_ID_TEKRAM 0x1de1 >> #define PCI_DEVICE_ID_TEKRAM_DC290 0xdc29 >> >> +#define PCI_VENDOR_ID_ALIBABA 0x1ded >> + >> #define PCI_VENDOR_ID_TEHUTI 0x1fc9 >> #define PCI_DEVICE_ID_TEHUTI_3009 0x3009 >> #define PCI_DEVICE_ID_TEHUTI_3010 0x3010 >> -- >> 2.20.1.12.g72788fdb >> >> >> _______________________________________________ >> linux-arm-kernel mailing list >> linux-arm-kernel@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel