Re: [PATCH v2 00/13] Request for Comments on SoftiWarp

[Dennis Dalessandro <dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>]

On 10/6/2017 8:28 AM, Bernard Metzler wrote:
> It is a re-posting of yesterdays misformatted patch and splits it into
> consumable pieces. Furthermore, it fixes formatting issues as
> indicated by checkpatch.

You should also remove the following:

1. All BUG/BUG_ON - just scrub all files
2. Remove all goto return stuff
3. TODO/XXX - either add the functionality or it's not needed
4. Extra whitespace, don't skip more than 1 line

It would be nice to see some commit messages too. Describe a bit about 
how things are working even if in just a few lines.

If we were using the staging tree still, I'd say it's in good enough 
shape to send there and let it get hacked on, but we aren't going down 
that road in this subsystem again I don't think. So the bar is a little 
higher I for getting in to mainline.

You also have a large number of debugging prints. While it's nice for 
development and can be turned off, I think alot of those are 
unnecessary. The RDMA subsystem on the whole needs a better strategy for 
dealing with debugging and logging, we just aren't there yet.

-Denny
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html