From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C43E8C433ED for ; Mon, 17 May 2021 19:32:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AA7A96128E for ; Mon, 17 May 2021 19:32:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234409AbhEQTeF (ORCPT ); Mon, 17 May 2021 15:34:05 -0400 Received: from polaris.svanheule.net ([84.16.241.116]:57678 "EHLO polaris.svanheule.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234394AbhEQTeD (ORCPT ); Mon, 17 May 2021 15:34:03 -0400 Received: from [IPv6:2a02:a03f:eafb:ee01:404a:340a:91cb:c07b] (unknown [IPv6:2a02:a03f:eafb:ee01:404a:340a:91cb:c07b]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: sander@svanheule.net) by polaris.svanheule.net (Postfix) with ESMTPSA id 18E871FFC02; Mon, 17 May 2021 21:32:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=svanheule.net; s=mail1707; t=1621279965; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=st+Q1TTctqUoxIlgrLDaGZoZTbZ7PzpMgveVrps9ljc=; b=nLP6b6oGufhmxBpGQxRsjukWfzXBhxL8zwdqca7Alswn8ITr6vh2fMJbf5uYtl+eatpuPy tn9uCRc370VoZ7vNIXdMyQUEC1IH+yTKH4ZbjENtqfsSIB74OloYuWv9OsB2x/6Qa+lEJN r7KpKwQkOLx9WvFzSSEbnjpdumOrk67leuwPqD/47RAevUz2ZL9GVfeuLRXmJHw/ie5uyZ p+spOXZrCil4HbsEAvnBkGEgFjNZtvyhL4pExnzYbKR2yeyS+wFCk7Ol/2FqVK11doZw5F CxQHhAdiScYX5CAXYT0o21saTdp5xTPZeQ/FQQpyipNPZThJ8lWk/rdHzTG6dQ== Message-ID: Subject: Re: [PATCH 0/5] RTL8231 GPIO expander support From: Sander Vanheule To: Andy Shevchenko Cc: Pavel Machek , Rob Herring , Lee Jones , Linus Walleij , "linux-leds@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" Date: Mon, 17 May 2021 21:32:43 +0200 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org On Sun, 2021-05-16 at 23:40 +0200, Sander Vanheule wrote: > > 2. Please, switch to fwnode API in LED driver > > Since you had the same comment on my previous patch set, I had already tried to > this this into account as much as possible. > > There's a few things I couldn't find the fwnode-equivalent for: >  * I use of_node_name_prefix to enforce the naming required by the binding. I >    could just walk over all (available) child nodes, which would be mostly >    equivalent. >  * To get the address of an LED child node, I use of_get_address, since this >    appeared to provide what I want to do: get the address of the node. I know >    next to nothing about ACPI. Does the equivalent exist there? Or am I taking >    the wrong approach? Hi Andy, I found this: https://www.kernel.org/doc/html/latest/firmware-guide/acpi/dsd/leds.html So instead of of_address, I now just read the "reg" property. The v2 I just sent should be fwnode-only. Best, Sander