From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1fNf67-0001u0-3V for mharc-grub-devel@gnu.org; Tue, 29 May 2018 09:55:35 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57862) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fNf5z-0001rp-2K for grub-devel@gnu.org; Tue, 29 May 2018 09:55:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fNf5v-0000Mk-UU for grub-devel@gnu.org; Tue, 29 May 2018 09:55:27 -0400 Received: from air.basealt.ru ([194.107.17.39]:33478) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fNf5v-0000Kf-HU for grub-devel@gnu.org; Tue, 29 May 2018 09:55:23 -0400 Received: by air.basealt.ru (Postfix, from userid 490) id 3717D589ED9; Tue, 29 May 2018 13:55:22 +0000 (UTC) Received: from Work-PC.localdomain (obninsk.basealt.ru [217.15.195.17]) by air.basealt.ru (Postfix) with ESMTPSA id 353A0589595 for ; Tue, 29 May 2018 13:55:19 +0000 (UTC) Subject: Re: [PATCH] Enable /dev/mapper/dm-[0-9]-* scanning To: grub-devel@gnu.org References: <6ef0e108-9b3c-0bb8-bf28-7fa013f01963@basealt.ru> <20180510193551.GL25320@router-fw-old.local.net-space.pl> <37013391-18cb-f1f7-6b7a-c6960f77c84b@basealt.ru> <20180514171303.GA8760@router-fw-old.local.net-space.pl> <348aa32f-a9bc-fe4d-0df5-d4c9982de3ef@basealt.ru> From: Oleg Solovyov Openpgp: preference=signencrypt Message-ID: Date: Tue, 29 May 2018 16:55:10 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="i0ivulGGuQyTvRmfq8tqqDjIYT8uxC8dy" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] [fuzzy] X-Received-From: 194.107.17.39 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 May 2018 13:55:34 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --i0ivulGGuQyTvRmfq8tqqDjIYT8uxC8dy Content-Type: multipart/mixed; boundary="KvXu8HOOPTPGZ23SAjsPd3MJCTe8r0bA9"; protected-headers="v1" From: Oleg Solovyov To: grub-devel@gnu.org Message-ID: Subject: Re: [PATCH] Enable /dev/mapper/dm-[0-9]-* scanning References: <6ef0e108-9b3c-0bb8-bf28-7fa013f01963@basealt.ru> <20180510193551.GL25320@router-fw-old.local.net-space.pl> <37013391-18cb-f1f7-6b7a-c6960f77c84b@basealt.ru> <20180514171303.GA8760@router-fw-old.local.net-space.pl> <348aa32f-a9bc-fe4d-0df5-d4c9982de3ef@basealt.ru> In-Reply-To: --KvXu8HOOPTPGZ23SAjsPd3MJCTe8r0bA9 Content-Type: multipart/alternative; boundary="------------DE4E96DF81C090B5B6014F78" Content-Language: en-US This is a multi-part message in MIME format. --------------DE4E96DF81C090B5B6014F78 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable 29.05.2018 16:50, Vladimir 'phcoder' Serbinenko =D0=BF=D0=B8=D1=88=D0=B5=D1= =82: > > > On Tue, 29 May 2018, 13:58 Oleg Solovyov, > wrote: > > Anybody? > > Why do you need this? Normally the same devices should be under > /dev/mapper. Using dm-X will mess up some other code most likely What happens if you have /dev/mapper/dm-0-luks symlinked to /dev/dm-0? This device will be skipped because basename starts with dm-0 There's no checking whether device is under /dev/mapper or not yet. > > > > 14.05.2018 20:13, Daniel Kiper =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > > On Fri, May 11, 2018 at 02:32:48PM +0300, Oleg Solovyov wrote: > >> Thanks for review > >> New version is attached > >> > >> From 19e3f13632a20a0b1be12b6d6ff4c52ba4f3b4d6 Mon Sep 17 > 00:00:00 2001 > >> From: Oleg Solovyov > > >> Date: Fri, 11 May 2018 13:55:46 +0300 > >> Subject: [PATCH] Don't skip /dev/mapper/dm-* devices > >> > >> This patch ensures that grub-probe will find the root device > placed in > >> /dev/mapper/dm-[0-9]+-.* > >> e.g. device named /dev/mapper/dm-0-luks will be found and > grub.cfg will > >> be updated properly, enabling the system to boot. > >> > >> Signed-off-by: Oleg Solovyov > > > Reviewed-by: Daniel Kiper > > > > > If there are no objections I will apply this patch in a week or s= o. > > > > Next time please use "git send-email" to send the patches. > > > > Daniel > > > > _______________________________________________ > > Grub-devel mailing list > > Grub-devel@gnu.org > > https://lists.gnu.org/mailman/listinfo/grub-devel > > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel > > > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel --------------DE4E96DF81C090B5B6014F78 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable 29.05.2018 16:50, Vladimir 'phcoder' Serbinenko =D0=BF=D0=B8=D1=88=D0= =B5=D1=82:


On Tue, 29 May 2018, 13:58 Oleg Solovyov, <mc= pain@basealt.ru> wrote:
Anybody?
Why do you need this? Normally the same devices should be under /dev/mapper. Using dm-X will mess up some other code most likely
What happens if you have /dev/mapper/dm-0-luks symlinked to /dev/dm-0?
This device will be skipped because basename starts with dm-0
There's no checking whether device is under /dev/mapper or not yet.


14.05.2018 20:13, Daniel Kiper =D0=BF=D0=B8=D1=88=D0=B5=D1=82:<= br> > On Fri, May 11, 2018 at 02:32:48PM +0300, Oleg Solovyov wrote:
>> Thanks for review
>> New version is attached
>>
>> From 19e3f13632a20a0b1be12b6d6ff4c52ba4f3b4d6 Mon Sep 17 00:00:00 2001
>> From: Oleg Solovyov <mcpain@altlinux.org>
>> Date: Fri, 11 May 2018 13:55:46 +0300
>> Subject: [PATCH] Don't skip /dev/mapper/dm-* devices >>
>> This patch ensures that grub-probe will find the root device placed in
>> /dev/mapper/dm-[0-9]+-.*
>> e.g. device named /dev/mapper/dm-0-luks will be found and grub.cfg will
>> be updated properly, enabling the system to boot.
>>
>> Signed-off-by: Oleg Solovyov <mcpain@altlinux.org>
> Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
>
> If there are no objections I will apply this patch in a week or so.
>
> Next time please use "git send-email" to send the patches.
>
> Daniel
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel


_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel


_______________________________________________
Grub-devel mailing list
=
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

--------------DE4E96DF81C090B5B6014F78-- --KvXu8HOOPTPGZ23SAjsPd3MJCTe8r0bA9-- --i0ivulGGuQyTvRmfq8tqqDjIYT8uxC8dy Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEohvh0wuxXF+pZkbSK/jbzM/lrU8FAlsNW8cACgkQK/jbzM/l rU+svxAAliI0uCjWQ7suc/VTFTiimivZkz+sp+bnfIauO0tWCK56Z6G9EuiqjJ9k shvKq6vzGz1fwN/g+KUpGPINIawDMrfoQXE9Sru7lUKk4KnhbcriYrr/O1q0DEA1 bfMgkZhiysrCuC6o3/Deykm/wmrS5BZ7dZK7kmDfikJApYxR9zh98EXENBKomZGi FyiraoerhamcYqA3AAEw+HIxxKa5LwmfoLBhx9VIjDiR0ci9JG/oSNm6E8ReVziS VcvfQ867UCUvlEVZ4YPmu2xaglbckzUO9DGbRyhlsKM8UFozYlihcHZNeEvYqOL2 Y238tymT+CrVtqcJSq/lF6+cyMXbHmSbRQhZfX81Bw1lH/yOoM8pj/mdVhqh4yF9 K+ZMSmyHKNBrnD4u9GaegwDlNrbCOcrtdPkvO8W2YybAfts6CMjkCOv3MjYCTbRR KgT9rgd90QIayhqWdArLdkocNa83glYUEwtN3kgx+W4jC5eYIPQX7CHpiADTPmQ9 FpCj3jZISXPaQ9wAeLGV02RUeME73gGTfs3GFTQXGWH2J1FSt9me2xgQYBVJ/Ggz zO62monMHvWVlJrf3yFF+YnIY4zaOutC6dolptM+q6f3+AI1JeItQWSiGqD1tToq I9/1flmdyq2HKkQOw4pC6YOBMwm5cDD5r4hV/ros5vy42Ra/SkU= =n84Q -----END PGP SIGNATURE----- --i0ivulGGuQyTvRmfq8tqqDjIYT8uxC8dy--