From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnout Vandecappelle Date: Mon, 12 Nov 2018 23:46:32 +0100 Subject: [Buildroot] [PATCH 4/6 v2] fs: split devices and permissions tables In-Reply-To: <84c91aa0b6b8503e5d9ece861f2215058b971082.1542043922.git.yann.morin.1998@free.fr> References: <84c91aa0b6b8503e5d9ece861f2215058b971082.1542043922.git.yann.morin.1998@free.fr> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net On 12/11/2018 18:33, Yann E. MORIN wrote: > Currently, we conflate device tables and permissions tables, on the > premise they are both created and applied with the same tool, makedevs. > > Split the two, in to their own final aggregated tables and their own > call to makedevs. Sorry, I don't think there is a good reason to split them up. I don't think this enables any other improvements either - the following two patches don't depend on this, right? I also don't feel that this change makes the code easier to understand (not more difficult either, but if it ain't broken, don't fix it). So nack from me. Regards, Arnout > > Signed-off-by: "Yann E. MORIN" > Cc: Thomas Petazzoni > Cc: Arnout Vandecappelle > --- > fs/common.mk | 27 +++++++++++++++++++-------- > 1 file changed, 19 insertions(+), 8 deletions(-) [snip]