From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49601) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e3zbW-0002cc-1s for qemu-devel@nongnu.org; Mon, 16 Oct 2017 03:14:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e3zbS-0001aw-U8 for qemu-devel@nongnu.org; Mon, 16 Oct 2017 03:14:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37160) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1e3zbS-0001Za-OK for qemu-devel@nongnu.org; Mon, 16 Oct 2017 03:14:22 -0400 References: <20170928203708.9376-1-david@redhat.com> <20171011140743.4a535984.cohuck@redhat.com> From: David Hildenbrand Message-ID: Date: Mon, 16 Oct 2017 09:14:18 +0200 MIME-Version: 1.0 In-Reply-To: <20171011140743.4a535984.cohuck@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 00/30] s390x: SMP for TCG List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cornelia Huck Cc: qemu-devel@nongnu.org, thuth@redhat.com, Christian Borntraeger , Alexander Graf , Richard Henderson On 11.10.2017 14:07, Cornelia Huck wrote: > On Thu, 28 Sep 2017 22:36:38 +0200 > David Hildenbrand wrote: > >> This series is based on a couple of other patches floating around on >> the mailing list (e.g. cleanups and LAP). The fist patches of v1 have >> been sent as a separate series. >> >> As I am working on kvm-unit-tests for SIGP, I discovered some bugs that >> have been fixed in this series. >> >> ====================================== >> I'll be on vacation until 15. October. >> ====================================== >> >> This series contains: >> - properly implement local external interrupts for TCG. Take care of >> interrupt masks. Cleanup service interrupt handling. >> - factor out KVM SIGP handling code into common code >> - implement missing SIGP orders for TCG handled by the kernel for KVM >> (including STOP and RESTART interrupts) >> - make TCG use the new SIGP code - experimental SMP support for s390x TCG >> - refactor STFL(E) implementation for TCG >> - bunch of cleanups >> >> Basically all SIGP instructions are fully supported. >> >> Thanks to Aurelien Jarno for the initital prototype and showcasing that >> supporting experimental SMP code can be implemented quite easily. >> > > Thanks, applied (with some minor changes, see the individual patches). > Thanks, all looks sane. >> CPU hotplug does still not work correctly. > > Do you have an idea what still needs to be done? > Nope, no idea yet. As the hotplugged CPU starts running but somehow produces a deadlock, however ordinary onlining/offlining of CPUs works, this could be a common code problem. If I find further problems using my kvm-unit-tests/testing, I'll send fixes. -- Thanks, David