From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 670D8C432BE for ; Thu, 2 Sep 2021 06:02:14 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1609F60FDA for ; Thu, 2 Sep 2021 06:02:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1609F60FDA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amsat.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:48348 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mLfnh-0007hB-8z for qemu-devel@archiver.kernel.org; Thu, 02 Sep 2021 02:02:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41824) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mLfmF-0006ib-7B; Thu, 02 Sep 2021 02:00:43 -0400 Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]:34312) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mLfmD-0007G4-LT; Thu, 02 Sep 2021 02:00:42 -0400 Received: by mail-wr1-x435.google.com with SMTP id m9so979807wrb.1; Wed, 01 Sep 2021 23:00:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=B1vyF0FWQId7bwTXnHEeutDw+FkCAGcy5KQHf8ZJDTw=; b=MljYoFJEaIwmS4dEg0e7YETX8lV5qIR2vz1h2VVpTgq/xhGtpeJpZgbpvqt0bJoZyZ eiFcyzOqigqMiBZwW04OVp/3nAHIPILouTkBcFNgTy9UnwbTL7l6GGcqJlgv1xPZi1Lm AyYXpU6pxnEx3zrijoKIhlqMc8aV1oo3JvTPbGY5/LEzTLIlIG9HovmUrFLNC0EPiPyR 2BgEg+ly8chT1FZfj7qaGs995d1Fb5IxFP5q1yzOth7t6gUsyzBgw7TWGu24D3TSGQ09 y4XH6EXVilAxjmsfh69TwDSlg3tR0FSvn8vWzK85l6RJCubaf4ZfV20qzs+X1LYlhuaF pknA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=B1vyF0FWQId7bwTXnHEeutDw+FkCAGcy5KQHf8ZJDTw=; b=AgW18bKhkCCjA4eIm5oOezlTIuxkZk+u+XEoh09R3LnMN+kvIsdbod9DU8LN3wrskI oFwETU7zlsWYMYv1adpA0p+DRFnvpGowkZyjYuyV4MMrho8gEoXuGxqKWc2z4q1MUZZN RdXoWtLu2t91gKgZK0uh9+zQsrF6GzDAhNrFFbXjUC31jUFcHbe1QlxqOgR+cGDUKLvT px2swyMAQ70+mYku148RSLFcLKfEg5IVMo9XoFwqT0V23FJjUxDyXXsR4ZIJbb9IVYfy Nozk+dAvIdJjjowG3lBgqusXFgoOesJtOdShYIGs2QYZ8bA4D405wR+cIek18Z1tMlBX Avuw== X-Gm-Message-State: AOAM532DvMomr9uz8YtPDcQear2P3F9TXzuPPACW7R+UFAwokKbxpyLu k0FRHbCiN2uzFTZFKtXs2eI2GD3trTk= X-Google-Smtp-Source: ABdhPJwRbWzWO/F+tKiM/9wzHDrYAnau9HlXytfQgZz3E0Qk1o5XxJr7k6Rn1RcEE9sabriRzl37Og== X-Received: by 2002:adf:e10c:: with SMTP id t12mr1563976wrz.36.1630562439269; Wed, 01 Sep 2021 23:00:39 -0700 (PDT) Received: from [192.168.1.36] (163.red-83-52-55.dynamicip.rima-tde.net. [83.52.55.163]) by smtp.gmail.com with ESMTPSA id l124sm670702wml.8.2021.09.01.23.00.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Sep 2021 23:00:37 -0700 (PDT) Subject: Re: [PATCH v2 3/5] hw/char: cadence_uart: Move clock/reset check to uart_can_receive() To: Bin Meng , Damien Hedde , "Edgar E . Iglesias" , Alistair Francis , Peter Maydell References: <20210901032724.23256-1-bmeng.cn@gmail.com> <20210901032724.23256-4-bmeng.cn@gmail.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: Date: Thu, 2 Sep 2021 08:00:36 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210901032724.23256-4-bmeng.cn@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::435; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-x435.google.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NICE_REPLY_A=-1.029, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 9/1/21 5:27 AM, Bin Meng wrote: > Currently the clock/reset check is done in uart_receive(), but we > can move the check to uart_can_receive() which is earlier. > > Signed-off-by: Bin Meng > > --- > > Changes in v2: > - avoid declaring variables mid-scope > > hw/char/cadence_uart.c | 17 ++++++++++------- > 1 file changed, 10 insertions(+), 7 deletions(-) Reviewed-by: Philippe Mathieu-Daudé