From: Jens Axboe <axboe@kernel.dk>
To: Josef Bacik <jbacik@fb.com>,
linux-block@vger.kernel.org, mpa@pengutronix.de,
nbd-general@lists.sourceforge.net, kernel-team@fb.com
Subject: Re: [PATCH] nbd: use loff_t for blocksize and nbd_set_size args
Date: Fri, 2 Dec 2016 21:06:40 -0700 [thread overview]
Message-ID: <dd4b264f-5529-54f5-5471-5ced434e1b90@kernel.dk> (raw)
In-Reply-To: <1480713552-3535-1-git-send-email-jbacik@fb.com>
On 12/02/2016 02:19 PM, Josef Bacik wrote:
> If we have large devices (say like the 40t drive I was trying to test with) we
> will end up overflowing the int arguments to nbd_set_size and not get the right
> size for our device. Fix this by using loff_t everywhere so I don't have to
> think about this again. Thanks,
Added, thanks Josef.
--
Jens Axboe
prev parent reply other threads:[~2016-12-03 4:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-02 21:19 [PATCH] nbd: use loff_t for blocksize and nbd_set_size args Josef Bacik
2016-12-03 4:06 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd4b264f-5529-54f5-5471-5ced434e1b90@kernel.dk \
--to=axboe@kernel.dk \
--cc=jbacik@fb.com \
--cc=kernel-team@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=mpa@pengutronix.de \
--cc=nbd-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.