From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C260C04AB5 for ; Mon, 3 Jun 2019 13:03:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 31E7E24E42 for ; Mon, 3 Jun 2019 13:03:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=st.com header.i=@st.com header.b="hp+ZYfxx" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728122AbfFCND4 (ORCPT ); Mon, 3 Jun 2019 09:03:56 -0400 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:8034 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726379AbfFCNDz (ORCPT ); Mon, 3 Jun 2019 09:03:55 -0400 Received: from pps.filterd (m0046660.ppops.net [127.0.0.1]) by mx08-00178001.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x53D29gj007830; Mon, 3 Jun 2019 15:03:41 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=st.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-id : content-transfer-encoding : mime-version; s=STMicroelectronics; bh=Yw1hBtZR78FRlvaY6GGctzL2o+O10Y/M0xnj+n+p2Bc=; b=hp+ZYfxxfJeIuT/RaytPDswUXx+ds5iGHjF2orcdEDZur/sIDfUbb85B9EQGs4KkmZ5f KyGWLZ3dGw5KVOu2jhV2/nxv5zvNfcLL605UUPvG+ZyM9FEPm+xK5+zETprDYxSNetBK 67WbBy9piiuojVicOol5hKWDMHkO5ajhMmdwq60YeRFvAmxtmj84JC5QzN5vlNI02N/z gAGV0P6Y6Fa6f/V2PZYnjsYsob6dwUJkUY91V5z2yYA+uYvcQWvUkfZ3LoAuIa63inCd rC6Fr75jQrNQJ5ychX3YNpFTi7pJ+xtYLoa+uuB3+2KnId4alxfXj5ZYAN6AuVL9Q/ip Sw== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx08-00178001.pphosted.com with ESMTP id 2sunmeaess-1 (version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT); Mon, 03 Jun 2019 15:03:41 +0200 Received: from zeta.dmz-eu.st.com (zeta.dmz-eu.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id D35C13F; Mon, 3 Jun 2019 13:03:40 +0000 (GMT) Received: from Webmail-eu.st.com (sfhdag5node2.st.com [10.75.127.14]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id A223D2434; Mon, 3 Jun 2019 13:03:40 +0000 (GMT) Received: from SFHDAG5NODE3.st.com (10.75.127.15) by SFHDAG5NODE2.st.com (10.75.127.14) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Mon, 3 Jun 2019 15:03:40 +0200 Received: from SFHDAG5NODE3.st.com ([fe80::7c09:5d6b:d2c7:5f47]) by SFHDAG5NODE3.st.com ([fe80::7c09:5d6b:d2c7:5f47%20]) with mapi id 15.00.1347.000; Mon, 3 Jun 2019 15:03:40 +0200 From: Fabien DESSENNE To: Hans Verkuil , Hugues FRUCHET , Mauro Carvalho Chehab , "Maxime Coquelin" , Alexandre TORGUE , Pavel Machek , "linux-media@vger.kernel.org" , "linux-stm32@st-md-mailman.stormreply.com" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" CC: Greg Kroah-Hartman , Sasha Levin Subject: Re: [PATCH] media: stm32-dcmi: fix irq = 0 case Thread-Topic: [PATCH] media: stm32-dcmi: fix irq = 0 case Thread-Index: AQHVF5HP7OIc+eCgyUyFjdbkSczlYqaJswGAgAAV2oA= Date: Mon, 3 Jun 2019 13:03:40 +0000 Message-ID: References: <1559294295-20573-1-git-send-email-fabien.dessenne@st.com> <46944972-1f88-ef3b-fef9-8e37753c0ffe@xs4all.nl> In-Reply-To: <46944972-1f88-ef3b-fef9-8e37753c0ffe@xs4all.nl> Accept-Language: fr-FR, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.75.127.44] Content-Type: text/plain; charset="utf-8" Content-ID: <16FAE0F28C0E154C942967FC70244FEE@st.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-06-03_10:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org SGkgSGFucw0KDQoNCiJwbGF0Zm9ybV9nZXRfaXJxKCkgPSAwIiBzaGFsbCBiZSBjb25zaWRlcmVk IGFzIGFuIGVycm9yLiBTZWUgdGhlc2UgDQpkaXNjdXNzaW9uczoNCmh0dHBzOi8vcGF0Y2h3b3Jr Lmtlcm5lbC5vcmcvcGF0Y2gvMTAwMDY2NTEvDQpodHRwczovL3lhcmNoaXZlLm5ldC9jb21wL2xp bnV4L3plcm8uaHRtbA0KDQpCUg0KDQpGYWJpZW4NCg0KT24gMDMvMDYvMjAxOSAxOjQ1IFBNLCBI YW5zIFZlcmt1aWwgd3JvdGU6DQo+IE9uIDUvMzEvMTkgMTE6MTggQU0sIEZhYmllbiBEZXNzZW5u ZSB3cm90ZToNCj4+IE1hbmFnZSB0aGUgaXJxID0gMCBjYXNlLCB3aGVyZSB3ZSBzaGFsbCByZXR1 cm4gYW4gZXJyb3IuDQo+Pg0KPj4gRml4ZXM6IGI1YjVhMjdiZWU1OCAoIm1lZGlhOiBzdG0zMi1k Y21pOiByZXR1cm4gYXBwcm9wcmlhdGUgZXJyb3IgY29kZXMgZHVyaW5nIHByb2JlIikNCj4+IFNp Z25lZC1vZmYtYnk6IEZhYmllbiBEZXNzZW5uZSA8ZmFiaWVuLmRlc3Nlbm5lQHN0LmNvbT4NCj4+ IC0tLQ0KPj4gICBkcml2ZXJzL21lZGlhL3BsYXRmb3JtL3N0bTMyL3N0bTMyLWRjbWkuYyB8IDIg Ky0NCj4+ICAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pDQo+ Pg0KPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbWVkaWEvcGxhdGZvcm0vc3RtMzIvc3RtMzItZGNt aS5jIGIvZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS9zdG0zMi9zdG0zMi1kY21pLmMNCj4+IGluZGV4 IGI5ZGFkMGEuLmQ4NTVlOWMgMTAwNjQ0DQo+PiAtLS0gYS9kcml2ZXJzL21lZGlhL3BsYXRmb3Jt L3N0bTMyL3N0bTMyLWRjbWkuYw0KPj4gKysrIGIvZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS9zdG0z Mi9zdG0zMi1kY21pLmMNCj4+IEBAIC0xNzAyLDcgKzE3MDIsNyBAQCBzdGF0aWMgaW50IGRjbWlf cHJvYmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikNCj4+ICAgCWlmIChpcnEgPD0gMCkg ew0KPiBTaG91bGRuJ3QgdGhpcyBiZSAnaXJxIDwgMCcgaW5zdGVhZCBvZiAnPD0nID8NCj4NCj4g QUZBSUNUIGlycSA9PSAwIGNhbiBiZSBhIHZhbGlkIGlycSBhbmQgaXNuJ3QgYW4gZXJyb3IuDQo+ DQo+IFJlZ2FyZHMsDQo+DQo+IAlIYW5zDQo+DQo+PiAgIAkJaWYgKGlycSAhPSAtRVBST0JFX0RF RkVSKQ0KPj4gICAJCQlkZXZfZXJyKCZwZGV2LT5kZXYsICJDb3VsZCBub3QgZ2V0IGlycVxuIik7 DQo+PiAtCQlyZXR1cm4gaXJxOw0KPj4gKwkJcmV0dXJuIGlycSA/IGlycSA6IC1FTlhJTzsNCj4+ ICAgCX0NCj4+ICAgDQo+PiAgIAlkY21pLT5yZXMgPSBwbGF0Zm9ybV9nZXRfcmVzb3VyY2UocGRl diwgSU9SRVNPVVJDRV9NRU0sIDApOw0KPj4= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9C98C46470 for ; Mon, 3 Jun 2019 13:04:00 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B20A127E3D for ; Mon, 3 Jun 2019 13:04:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="GbV4I/XM"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=st.com header.i=@st.com header.b="hp+ZYfxx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B20A127E3D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=st.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OvLcNWf7m1QyyRYmyUbi4xt28PdhWVmFTtCgFyKy/N8=; b=GbV4I/XMJMDcsc F5xHWVhxMoCG+Mr20nZ3+yNWp36FoQTZ/s9J8oLihQA4lwSLDJuKnpfY5tgWdkDPXUKRfctDlK74r 0sfOXA3lsrfWI7RcrkaMvMI0glp1XkcEJQT/KUgABnKio0lhiRRNYQEebMw3tsoWDAzz0f14/jihU 0c3CXkrQr2hDqUDXDRfWlPkJTflFnr01QAoMD2AiNoG0o7JTpA+jSolQROhbRmLSYefuDwB8aOa+4 jT7/rx2128MFv60LWEwhysSv2i1a30d1G55kd+xsMT3j+GQpKEtJnbFPohxbUPqmAAaAY5wMWKbU1 z6gk+bPjxA7Fql6tAP5w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hXmd0-0006TJ-Bz; Mon, 03 Jun 2019 13:03:54 +0000 Received: from mx08-00178001.pphosted.com ([91.207.212.93] helo=mx07-00178001.pphosted.com) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hXmcw-0006R3-Li for linux-arm-kernel@lists.infradead.org; Mon, 03 Jun 2019 13:03:52 +0000 Received: from pps.filterd (m0046660.ppops.net [127.0.0.1]) by mx08-00178001.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x53D29gj007830; Mon, 3 Jun 2019 15:03:41 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=st.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-id : content-transfer-encoding : mime-version; s=STMicroelectronics; bh=Yw1hBtZR78FRlvaY6GGctzL2o+O10Y/M0xnj+n+p2Bc=; b=hp+ZYfxxfJeIuT/RaytPDswUXx+ds5iGHjF2orcdEDZur/sIDfUbb85B9EQGs4KkmZ5f KyGWLZ3dGw5KVOu2jhV2/nxv5zvNfcLL605UUPvG+ZyM9FEPm+xK5+zETprDYxSNetBK 67WbBy9piiuojVicOol5hKWDMHkO5ajhMmdwq60YeRFvAmxtmj84JC5QzN5vlNI02N/z gAGV0P6Y6Fa6f/V2PZYnjsYsob6dwUJkUY91V5z2yYA+uYvcQWvUkfZ3LoAuIa63inCd rC6Fr75jQrNQJ5ychX3YNpFTi7pJ+xtYLoa+uuB3+2KnId4alxfXj5ZYAN6AuVL9Q/ip Sw== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx08-00178001.pphosted.com with ESMTP id 2sunmeaess-1 (version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT); Mon, 03 Jun 2019 15:03:41 +0200 Received: from zeta.dmz-eu.st.com (zeta.dmz-eu.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id D35C13F; Mon, 3 Jun 2019 13:03:40 +0000 (GMT) Received: from Webmail-eu.st.com (sfhdag5node2.st.com [10.75.127.14]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id A223D2434; Mon, 3 Jun 2019 13:03:40 +0000 (GMT) Received: from SFHDAG5NODE3.st.com (10.75.127.15) by SFHDAG5NODE2.st.com (10.75.127.14) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Mon, 3 Jun 2019 15:03:40 +0200 Received: from SFHDAG5NODE3.st.com ([fe80::7c09:5d6b:d2c7:5f47]) by SFHDAG5NODE3.st.com ([fe80::7c09:5d6b:d2c7:5f47%20]) with mapi id 15.00.1347.000; Mon, 3 Jun 2019 15:03:40 +0200 From: Fabien DESSENNE To: Hans Verkuil , Hugues FRUCHET , Mauro Carvalho Chehab , "Maxime Coquelin" , Alexandre TORGUE , Pavel Machek , "linux-media@vger.kernel.org" , "linux-stm32@st-md-mailman.stormreply.com" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] media: stm32-dcmi: fix irq = 0 case Thread-Topic: [PATCH] media: stm32-dcmi: fix irq = 0 case Thread-Index: AQHVF5HP7OIc+eCgyUyFjdbkSczlYqaJswGAgAAV2oA= Date: Mon, 3 Jun 2019 13:03:40 +0000 Message-ID: References: <1559294295-20573-1-git-send-email-fabien.dessenne@st.com> <46944972-1f88-ef3b-fef9-8e37753c0ffe@xs4all.nl> In-Reply-To: <46944972-1f88-ef3b-fef9-8e37753c0ffe@xs4all.nl> Accept-Language: fr-FR, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.75.127.44] Content-ID: <16FAE0F28C0E154C942967FC70244FEE@st.com> MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-06-03_10:, , signatures=0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190603_060351_150714_E63864D0 X-CRM114-Status: GOOD ( 18.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sasha Levin , Greg Kroah-Hartman Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Hans "platform_get_irq() = 0" shall be considered as an error. See these discussions: https://patchwork.kernel.org/patch/10006651/ https://yarchive.net/comp/linux/zero.html BR Fabien On 03/06/2019 1:45 PM, Hans Verkuil wrote: > On 5/31/19 11:18 AM, Fabien Dessenne wrote: >> Manage the irq = 0 case, where we shall return an error. >> >> Fixes: b5b5a27bee58 ("media: stm32-dcmi: return appropriate error codes during probe") >> Signed-off-by: Fabien Dessenne >> --- >> drivers/media/platform/stm32/stm32-dcmi.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/media/platform/stm32/stm32-dcmi.c b/drivers/media/platform/stm32/stm32-dcmi.c >> index b9dad0a..d855e9c 100644 >> --- a/drivers/media/platform/stm32/stm32-dcmi.c >> +++ b/drivers/media/platform/stm32/stm32-dcmi.c >> @@ -1702,7 +1702,7 @@ static int dcmi_probe(struct platform_device *pdev) >> if (irq <= 0) { > Shouldn't this be 'irq < 0' instead of '<=' ? > > AFAICT irq == 0 can be a valid irq and isn't an error. > > Regards, > > Hans > >> if (irq != -EPROBE_DEFER) >> dev_err(&pdev->dev, "Could not get irq\n"); >> - return irq; >> + return irq ? irq : -ENXIO; >> } >> >> dcmi->res = platform_get_resource(pdev, IORESOURCE_MEM, 0); >> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel