All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Ahern <dsahern@gmail.com>
To: nicolas.dichtel@6wind.com, zhang kai <zhangkaiheb@126.com>,
	davem@davemloft.net, yoshfuji@linux-ipv6.org, dsahern@kernel.org,
	kuba@kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ipv6: parameter p.name is empty
Date: Thu, 3 Jun 2021 09:15:27 -0600	[thread overview]
Message-ID: <dd5b5a62-841c-5a21-7571-78d75e2f2482@gmail.com> (raw)
In-Reply-To: <d1085905-215f-fb78-4d68-324bd6e48fdd@6wind.com>

On 6/3/21 7:33 AM, Nicolas Dichtel wrote:
> Le 03/06/2021 à 11:50, zhang kai a écrit :
>> so do not check it.
>>
>> Signed-off-by: zhang kai <zhangkaiheb@126.com>
>> ---
>>  net/ipv6/addrconf.c | 3 ---
>>  1 file changed, 3 deletions(-)
>>
>> diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
>> index b0ef65eb9..4c6b3fc7e 100644
>> --- a/net/ipv6/addrconf.c
>> +++ b/net/ipv6/addrconf.c
>> @@ -2833,9 +2833,6 @@ static int addrconf_set_sit_dstaddr(struct net *net, struct net_device *dev,
>>  	if (err)
>>  		return err;
>>  
>> -	dev = __dev_get_by_name(net, p.name);
>> -	if (!dev)
>> -		return -ENOBUFS;
>>  	return dev_open(dev, NULL);
>>  }
>>  
>>
> This bug seems to exist since the beginning of the SIT driver (24 years!):
> https://git.kernel.org/pub/scm/linux/kernel/git/davem/netdev-vger-cvs.git/commit/?id=e5afd356a411a
> Search addrconf_set_dstaddr()
> 
> Acked-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
> 

A patch was sent yesterday, "sit: set name of device back to struct
parms", to set the name field in params.

  reply	other threads:[~2021-06-03 15:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-03  9:50 [PATCH] ipv6: parameter p.name is empty zhang kai
2021-06-03 13:33 ` Nicolas Dichtel
2021-06-03 15:15   ` David Ahern [this message]
2021-06-03 16:29     ` Nicolas Dichtel
2021-06-03 17:09       ` David Ahern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dd5b5a62-841c-5a21-7571-78d75e2f2482@gmail.com \
    --to=dsahern@gmail.com \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nicolas.dichtel@6wind.com \
    --cc=yoshfuji@linux-ipv6.org \
    --cc=zhangkaiheb@126.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.