From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45459) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bK0zS-0001W8-FO for qemu-devel@nongnu.org; Mon, 04 Jul 2016 06:20:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bK0zM-00049F-L2 for qemu-devel@nongnu.org; Mon, 04 Jul 2016 06:20:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51399) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bK0zM-00049A-Fc for qemu-devel@nongnu.org; Mon, 04 Jul 2016 06:20:28 -0400 References: <1467272240-32123-1-git-send-email-pl@kamp.de> <1467272240-32123-7-git-send-email-pl@kamp.de> <577A00B1.3010508@kamp.de> From: Paolo Bonzini Message-ID: Date: Mon, 4 Jul 2016 12:20:22 +0200 MIME-Version: 1.0 In-Reply-To: <577A00B1.3010508@kamp.de> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 6/6] coroutine: reduce stack size to 64kB List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Lieven , Richard Henderson , qemu-devel@nongnu.org Cc: kwolf@redhat.com, peter.maydell@linaro.org, mst@redhat.com, dgilbert@redhat.com, mreitz@redhat.com On 04/07/2016 08:22, Peter Lieven wrote: >>> >> >> Ought we check that this is not smaller than >> >> sysconf(_SC_THREAD_STACK_MIN) >> >> which (for glibc at least), is 192k for ia64, 128k for aarch64, mips >> and tile (though why it is quite so high in those later cases I don't >> know). > > for x86_64 it seems to be 16k. I would not mind to adjust the stack size > either in qemu_alloc_stack or change the macro for the coroutine stack > size into a function returning MAX(1 << 16, sysconf(_SC_THREAD_STACK_MIN)). Yes, either of this is a good idea. Paolo