From mboxrd@z Thu Jan 1 00:00:00 1970 From: "David.Wu" Subject: =?UTF-8?Q?Re:_[PATCH_v1_1/2]_pinctrl:_rockchip=ef=bc=9aAdd_input_sc?= =?UTF-8?Q?hmitt_support?= Date: Tue, 28 Feb 2017 19:12:19 +0800 Message-ID: References: <1487068541-14120-1-git-send-email-david.wu@rock-chips.com> <1487068541-14120-2-git-send-email-david.wu@rock-chips.com> <48027259.fqOrTqXNdI@phil> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <48027259.fqOrTqXNdI@phil> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Heiko Stuebner Cc: huangtao-TNX95d0MmH7DzftRWevZcw@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-gpio@vger.kernel.org SGkgSGVpa28sCgrlnKggMjAxNy8yLzI0IDA6NTEsIEhlaWtvIFN0dWVibmVyIOWGmemBkzoKPiBI aSBEYXZpZCwKPgo+IEFtIERpZW5zdGFnLCAxNC4gRmVicnVhciAyMDE3LCAxODozNTo0MCBDRVQg c2NocmllYiBEYXZpZCBXdToKPj4gRnJvbTogImRhdmlkLnd1IiA8ZGF2aWQud3VAcm9jay1jaGlw cy5jb20+Cj4+Cj4+ICBzdHJ1Y3Qgcm9ja2NoaXBfcGluX2NvbmZpZyB7Cj4+IEBAIC0xMzU1LDYg KzEzNTgsNTMgQEAgc3RhdGljIGludCByb2NrY2hpcF9zZXRfcHVsbChzdHJ1Y3Qgcm9ja2NoaXBf cGluX2JhbmsKPj4gKmJhbmssIHJldHVybiByZXQ7Cj4+ICB9Cj4+Cj4+ICtzdGF0aWMgaW50IHJv Y2tjaGlwX2dldF9zY2htaXR0KHN0cnVjdCByb2NrY2hpcF9waW5fYmFuayAqYmFuaywgaW50Cj4+ IHBpbl9udW0pICt7Cj4+ICsJc3RydWN0IHJvY2tjaGlwX3BpbmN0cmwgKmluZm8gPSBiYW5rLT5k cnZkYXRhOwo+PiArCXN0cnVjdCByb2NrY2hpcF9waW5fY3RybCAqY3RybCA9IGluZm8tPmN0cmw7 Cj4+ICsJc3RydWN0IHJlZ21hcCAqcmVnbWFwOwo+PiArCWludCByZWcsIHJldDsKPj4gKwl1OCBi aXQ7Cj4+ICsJdTMyIGRhdGE7Cj4+ICsKPj4gKwljdHJsLT5zY2htaXR0X2NhbGNfcmVnKGJhbmss IHBpbl9udW0sICZyZWdtYXAsICZyZWcsICZiaXQpOwo+Cj4gd2UgbWlnaHQgd2FudCB0byBoYXZl IGFuZCBjaGVjayBhbiBhY3R1YWwgcmV0dXJuIHZhbHVlIGhlcmUuCj4gT24gdGhpbmdzIGxpa2Ug dGhlIHJrMzI4OCBvbmx5IHNvbWUgc3BlY2lhbCBwaW5zIGhhdmUgdGhlc2Ugc2NobWl0dCB0cmln Z2Vycwo+IGl0IHNlZW1zLCBzbyB3ZSBtaWdodCB3YW50IHRvIGFib3J0IGlmIHNvbWV0aGluZyB0 cmllcyB0byBhY2Nlc3MgYW4KPiB1bnN1cHBvcnRlZCBvbmUuCgpUaGFua3MsIGkgZm9yZ2V0IHRv IGNoZWNrIHRoZSByZXR1cm4gdmFsdWUuCj4KPj4gKwo+PiArCXJldCA9IHJlZ21hcF9yZWFkKHJl Z21hcCwgcmVnLCAmZGF0YSk7Cj4+ICsJaWYgKHJldCkKPj4gKwkJcmV0dXJuIHJldDsKPj4gKwo+ PiArCWRhdGEgPj49IGJpdDsKPj4gKwlyZXR1cm4gZGF0YSAmIDB4MTsKPgo+IFRoZSBtYXNrIHNl ZW1zIHRvIGFsc28gYmUgdmFyaWFibGUsIGZvciBleGFtcGxlIG9uIHRoZSByazMzOTkgdGhlcmUg c2VlbSB0byBiZQo+IG11bHRpcGxlICJsZXZlbHMiIGZvciBhdCBsZWFzdCBncGlvMi4gU28geW91 ciBjYWxjLWNhbGxiYWNrIG1pZ2h0IHdhbnQgdG8gYWxzbwo+IHNldCB0aGUgcmlnaHQgbWFzay4K ClRvIHRoZSBtdWx0aXBsZSAibGV2ZWxzIiwgaSB0aGluayB3ZSBjYW4gdXNlIHRoZSAKIlBJTl9D T05GSUdfSU5QVVRfU0NITUlUVCIgcGluIGNvbmZpZywgd2hpY2ggZGVzY3JpYmVkIGF0IHBpbmNv bmYtZ2VuZXJpYy5oLgoKICAqIEBQSU5fQ09ORklHX0lOUFVUX1NDSE1JVFQ6IHRoaXMgd2lsbCBj b25maWd1cmUgYW4gaW5wdXQgcGluIHRvIHJ1biBpbgogICoJc2NobWl0dC10cmlnZ2VyIG1vZGUu IElmIHRoZSBzY2htaXR0LXRyaWdnZXIgaGFzIGFkanVzdGFibGUgaHlzdGVyZXNpcywKICAqCXRo ZSB0aHJlc2hvbGQgdmFsdWUgaXMgZ2l2ZW4gb24gYSBjdXN0b20gZm9ybWF0IGFzIGFyZ3VtZW50 IHdoZW4KICAqCXNldHRpbmcgcGlucyB0byB0aGlzIG1vZGUuCgo+Cj4gT3RoZXJ3aXNlIGxvb2tz IGdvb2QuCj4KPgo+IEhlaWtvCj4KPgo+Cj4KCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpMaW51eC1yb2NrY2hpcCBtYWlsaW5nIGxpc3QKTGludXgtcm9j a2NoaXBAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWls bWFuL2xpc3RpbmZvL2xpbnV4LXJvY2tjaGlwCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752345AbdB1LOJ (ORCPT ); Tue, 28 Feb 2017 06:14:09 -0500 Received: from lucky1.263xmail.com ([211.157.147.132]:38642 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751989AbdB1LOF (ORCPT ); Tue, 28 Feb 2017 06:14:05 -0500 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: david.wu@rock-chips.com X-FST-TO: linux-kernel@vger.kernel.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: david.wu@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: =?UTF-8?Q?Re:_[PATCH_v1_1/2]_pinctrl:_rockchip=ef=bc=9aAdd_input_sc?= =?UTF-8?Q?hmitt_support?= To: Heiko Stuebner References: <1487068541-14120-1-git-send-email-david.wu@rock-chips.com> <1487068541-14120-2-git-send-email-david.wu@rock-chips.com> <48027259.fqOrTqXNdI@phil> Cc: linus.walleij@linaro.org, huangtao@rock-chips.com, linux-rockchip@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org From: "David.Wu" Message-ID: Date: Tue, 28 Feb 2017 19:12:19 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <48027259.fqOrTqXNdI@phil> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Heiko, 在 2017/2/24 0:51, Heiko Stuebner 写道: > Hi David, > > Am Dienstag, 14. Februar 2017, 18:35:40 CET schrieb David Wu: >> From: "david.wu" >> >> struct rockchip_pin_config { >> @@ -1355,6 +1358,53 @@ static int rockchip_set_pull(struct rockchip_pin_bank >> *bank, return ret; >> } >> >> +static int rockchip_get_schmitt(struct rockchip_pin_bank *bank, int >> pin_num) +{ >> + struct rockchip_pinctrl *info = bank->drvdata; >> + struct rockchip_pin_ctrl *ctrl = info->ctrl; >> + struct regmap *regmap; >> + int reg, ret; >> + u8 bit; >> + u32 data; >> + >> + ctrl->schmitt_calc_reg(bank, pin_num, ®map, ®, &bit); > > we might want to have and check an actual return value here. > On things like the rk3288 only some special pins have these schmitt triggers > it seems, so we might want to abort if something tries to access an > unsupported one. Thanks, i forget to check the return value. > >> + >> + ret = regmap_read(regmap, reg, &data); >> + if (ret) >> + return ret; >> + >> + data >>= bit; >> + return data & 0x1; > > The mask seems to also be variable, for example on the rk3399 there seem to be > multiple "levels" for at least gpio2. So your calc-callback might want to also > set the right mask. To the multiple "levels", i think we can use the "PIN_CONFIG_INPUT_SCHMITT" pin config, which described at pinconf-generic.h. * @PIN_CONFIG_INPUT_SCHMITT: this will configure an input pin to run in * schmitt-trigger mode. If the schmitt-trigger has adjustable hysteresis, * the threshold value is given on a custom format as argument when * setting pins to this mode. > > Otherwise looks good. > > > Heiko > > > >