Hi James,

On 02/21/2019 12:22 PM, James Prestwood wrote:
> A settings file containing a key/value but no group caused
> l_settings_load_from_data to segfault. This was due to both parse_key
> and parse_value not checking that the group was non-NULL.

Whoops :)

I think it might be more clear to fix this in 
l_settings_load_from_data() to not call parse_keyvalue if no group has 
been encountered previously.

> 
> Also, the return of parse_key was being checked against false, when
> it actually is returning a unsigned int. This was changed to just
> check !parse_key.
> ---
>   ell/settings.c | 8 +++++++-
>   1 file changed, 7 insertions(+), 1 deletion(-)
> 

Regards,
-Denis