All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Fastabend <john.fastabend@gmail.com>
To: Prashant Bhole <bhole_prashant_q7@lab.ntt.co.jp>,
	Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>
Cc: "David S . Miller" <davem@davemloft.net>,
	Shuah Khan <shuah@kernel.org>,
	netdev@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH bpf v2 0/5] fix test_sockmap
Date: Tue, 29 May 2018 08:48:47 -0700	[thread overview]
Message-ID: <dd755be4-a298-a037-b32a-b506f45f4d8f@gmail.com> (raw)
In-Reply-To: <20180528043803.4824-1-bhole_prashant_q7@lab.ntt.co.jp>

On 05/27/2018 09:37 PM, Prashant Bhole wrote:
> This series fixes error handling, timeout and data verification in
> test_sockmap. Previously it was not able to detect failure/timeout in
> RX/TX thread because error was not notified to the main thread.
> 
> Also slightly improved test output by printing parameter values (cork,
> apply, start, end) so that parameters for all tests are displayed.
> 
> Prashant Bhole (5):
>   selftests/bpf: test_sockmap, check test failure
>   selftests/bpf: test_sockmap, join cgroup in selftest mode
>   selftests/bpf: test_sockmap, fix test timeout
>   selftests/bpf: test_sockmap, fix data verification
>   selftests/bpf: test_sockmap, print additional test options
> 
>  tools/testing/selftests/bpf/test_sockmap.c | 76 +++++++++++++++++-----
>  1 file changed, 58 insertions(+), 18 deletions(-)
> 

After first patch "check test failure" how do we handle the case
where test is known to cause timeouts because we are specifically testing
these cases. This is the 'cork' parameter we discussed in the last
series. It looks like with this series the test may still throw an
error?

Thanks,
John

WARNING: multiple messages have this Message-ID (diff)
From: john.fastabend at gmail.com (John Fastabend)
Subject: [PATCH bpf v2 0/5] fix test_sockmap
Date: Tue, 29 May 2018 08:48:47 -0700	[thread overview]
Message-ID: <dd755be4-a298-a037-b32a-b506f45f4d8f@gmail.com> (raw)
In-Reply-To: <20180528043803.4824-1-bhole_prashant_q7@lab.ntt.co.jp>

On 05/27/2018 09:37 PM, Prashant Bhole wrote:
> This series fixes error handling, timeout and data verification in
> test_sockmap. Previously it was not able to detect failure/timeout in
> RX/TX thread because error was not notified to the main thread.
> 
> Also slightly improved test output by printing parameter values (cork,
> apply, start, end) so that parameters for all tests are displayed.
> 
> Prashant Bhole (5):
>   selftests/bpf: test_sockmap, check test failure
>   selftests/bpf: test_sockmap, join cgroup in selftest mode
>   selftests/bpf: test_sockmap, fix test timeout
>   selftests/bpf: test_sockmap, fix data verification
>   selftests/bpf: test_sockmap, print additional test options
> 
>  tools/testing/selftests/bpf/test_sockmap.c | 76 +++++++++++++++++-----
>  1 file changed, 58 insertions(+), 18 deletions(-)
> 

After first patch "check test failure" how do we handle the case
where test is known to cause timeouts because we are specifically testing
these cases. This is the 'cork' parameter we discussed in the last
series. It looks like with this series the test may still throw an
error?

Thanks,
John
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: john.fastabend@gmail.com (John Fastabend)
Subject: [PATCH bpf v2 0/5] fix test_sockmap
Date: Tue, 29 May 2018 08:48:47 -0700	[thread overview]
Message-ID: <dd755be4-a298-a037-b32a-b506f45f4d8f@gmail.com> (raw)
Message-ID: <20180529154847.5hmwXTfA8KL3kxuBlwaYlG-zySNqPZYBB8k3c1mM-zg@z> (raw)
In-Reply-To: <20180528043803.4824-1-bhole_prashant_q7@lab.ntt.co.jp>

On 05/27/2018 09:37 PM, Prashant Bhole wrote:
> This series fixes error handling, timeout and data verification in
> test_sockmap. Previously it was not able to detect failure/timeout in
> RX/TX thread because error was not notified to the main thread.
> 
> Also slightly improved test output by printing parameter values (cork,
> apply, start, end) so that parameters for all tests are displayed.
> 
> Prashant Bhole (5):
>   selftests/bpf: test_sockmap, check test failure
>   selftests/bpf: test_sockmap, join cgroup in selftest mode
>   selftests/bpf: test_sockmap, fix test timeout
>   selftests/bpf: test_sockmap, fix data verification
>   selftests/bpf: test_sockmap, print additional test options
> 
>  tools/testing/selftests/bpf/test_sockmap.c | 76 +++++++++++++++++-----
>  1 file changed, 58 insertions(+), 18 deletions(-)
> 

After first patch "check test failure" how do we handle the case
where test is known to cause timeouts because we are specifically testing
these cases. This is the 'cork' parameter we discussed in the last
series. It looks like with this series the test may still throw an
error?

Thanks,
John
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2018-05-29 15:49 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-28  4:37 [PATCH bpf v2 0/5] fix test_sockmap Prashant Bhole
2018-05-28  4:37 ` Prashant Bhole
2018-05-28  4:37 ` bhole_prashant_q7
2018-05-28  4:37 ` [PATCH bpf v2 1/5] selftests/bpf: test_sockmap, check test failure Prashant Bhole
2018-05-28  4:37   ` Prashant Bhole
2018-05-28  4:37   ` bhole_prashant_q7
2018-05-29 15:37   ` John Fastabend
2018-05-29 15:37     ` John Fastabend
2018-05-29 15:37     ` john.fastabend
2018-05-28  4:38 ` [PATCH bpf v2 2/5] selftests/bpf: test_sockmap, join cgroup in selftest mode Prashant Bhole
2018-05-28  4:38   ` Prashant Bhole
2018-05-28  4:38   ` bhole_prashant_q7
2018-05-28  4:38 ` [PATCH bpf v2 3/5] selftests/bpf: test_sockmap, fix test timeout Prashant Bhole
2018-05-28  4:38   ` Prashant Bhole
2018-05-28  4:38   ` bhole_prashant_q7
2018-05-28  4:38 ` [PATCH bpf v2 4/5] selftests/bpf: test_sockmap, fix data verification Prashant Bhole
2018-05-28  4:38   ` Prashant Bhole
2018-05-28  4:38   ` bhole_prashant_q7
2018-05-28  4:38 ` [PATCH bpf v2 5/5] selftests/bpf: test_sockmap, print additional test options Prashant Bhole
2018-05-28  4:38   ` Prashant Bhole
2018-05-28  4:38   ` bhole_prashant_q7
2018-05-29 15:48 ` John Fastabend [this message]
2018-05-29 15:48   ` [PATCH bpf v2 0/5] fix test_sockmap John Fastabend
2018-05-29 15:48   ` john.fastabend
2018-05-30  0:44   ` Prashant Bhole
2018-05-30  0:44     ` Prashant Bhole
2018-05-30  0:44     ` bhole_prashant_q7
2018-05-30  5:12     ` John Fastabend
2018-05-30  5:12       ` John Fastabend
2018-05-30  5:12       ` john.fastabend
2018-05-30  5:31       ` Prashant Bhole
2018-05-30  5:31         ` Prashant Bhole
2018-05-30  5:31         ` bhole_prashant_q7

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dd755be4-a298-a037-b32a-b506f45f4d8f@gmail.com \
    --to=john.fastabend@gmail.com \
    --cc=ast@kernel.org \
    --cc=bhole_prashant_q7@lab.ntt.co.jp \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.