From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB23BC43334 for ; Sat, 2 Jul 2022 16:51:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232374AbiGBQvd (ORCPT ); Sat, 2 Jul 2022 12:51:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50166 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232079AbiGBQvc (ORCPT ); Sat, 2 Jul 2022 12:51:32 -0400 Received: from mout.gmx.net (mout.gmx.net [212.227.15.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1274BDE93; Sat, 2 Jul 2022 09:51:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1656780663; bh=mUyhruXIhmuUViMeDFbRQp4XSTkRwYDiNt+WsCvGuuM=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=IAv5TECA6DaGDanu4F2UESXF9U4moCqIxQji5xOqiyBEcqkHYY6nfGeJy9vMUCEeH CEo2AWjmKthmW2XDuFNd+PGaGDVhDJnJ9Ewwb8ZthEs4qEX3YEQb28EWUBVY3Reh6I /Y8bOrvSyWmXh7j1b7mgqHSSYAPko34986YQpylI= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.0.69] ([46.223.3.210]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MMofW-1nr6qx0112-00Ik4J; Sat, 02 Jul 2022 18:51:03 +0200 Message-ID: Date: Sat, 2 Jul 2022 18:50:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH 1/8] serial: core: only get RS485 termination gpio if supported Content-Language: en-US To: =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= , Lukas Wunner Cc: Greg Kroah-Hartman , Jiri Slaby , robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, Andy Shevchenko , vz@mleia.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-serial , LKML , p.rosenberger@kunbus.com, Lino Sanfilippo References: <20220622154659.8710-1-LinoSanfilippo@gmx.de> <20220622154659.8710-2-LinoSanfilippo@gmx.de> <20220625194951.GA2879@wunner.de> From: Lino Sanfilippo In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:KV+4xPvzh0c7cByKeFFk/pLcKFJ1ZO2uSNEEgxRyg3FJs6W66M9 49CwH2GFa49hMrEpMPhGlXwgvKHiWeWkhZCbzE+fUo+oFH8iEd8Zl2HWpS2wXZPhVHdaqJs leXq7fpqRzpmIyK8+yZCGLeZYwSRvY5RB5KFL8igB7oZ6m7qLsVtxAlB0ufkvllsNyh2x7L gYhtSjBVzSb9SMohfo1eg== X-UI-Out-Filterresults: notjunk:1;V03:K0:gK6ld9oDcxA=:ClhnIwM/mA5AvWRKq/whT4 vlqN9ckew6KPdywCugY9q9WBB1eWTfDTaHJcW3F9ZUHgIEqOk+XzSLwP7KT3GReWRQji/VKnw B3u0LmhLwS+Ci88M0h4Ta9LxE5zfxaFG/Sw+1964WrE5HYDkFr0k8IKNNukSvYjPGQFgdfkX3 c1QwcRCCNhOJv1wpdAHtk61guvU7OtENaYGZnwlIrW6VRDiKOUjAcU4TBiwmVcIn2dARxFtyn 6e7gS9RBXJbJdvUGzLvYOBNC10egN/hP4tn7tQd9pi0jaxKl766tgH0vYZlYVNH/saqde/nDW W4PTZBlp1SHkYcAwDpqBNTEOGAar5EZ64jOLBf4kE0Fry6qQsLJ/22MDXKpyfWw9/X4HVY4Ru oNoxRN+p6moAVOAdvHwU8ziXYmVNTS8MgACHc15vr0R3jTasfznn8S0NPrjlYmoeDxCERlNBu 0/NAxzslsTmAij2gD4ZstA98YC/mZm6cF5N1eIucf/ehWzRmaWpxmpLRlvSQZiXwwEQiVdZAk 7Us7+SpGyeEesQTNCEpUM9U3Pkz7v082PoIcrUp//9130HnghuozMgfJyUUhgfw/kSYvSwOWH sZCeaXdVzuCycsaorpb3ehKi2wzzy4dPjVmQpVE5erKV1zi3xaBr6+bRyrF0hM3sZ1jnp9BHF FOEgi3VrXFjUPtRV6x717bHt0jz2SK4NQwgI5k7609GYIWUzHZPbz84kv7Jyp6BUEMs+jO3rb gHdjWCWuknMkJWVTo4Rr8QQuHCL0627C6YyH6wT9qGtBYFHZdACwmMyautyW8XuSa/WNxxxVi WltMwdTyclzPTY4DKU86Sb9i03GETuX93OmB41XMljBbh8OKo8qXqY8xvC93eCwp9pHLlphi8 x67OU+iEmIF+80BOZWSIOUkGN7jlkRStF+ncNEgoosBHvLV9aZFb1PIhKMKkYNEEEGd0fVZyP hbNRyrtFv9lKEjI88QHKD8xhY2qbGcb/2N784nwVDKof4Krg7fSOcXOTzfx/jOYsOzh5pqp3q RkfRe5xMAXArhsO3S3oAJGlbnxP3OM3cD4LDpbh0Meg5KEVsHtG82Y11d5cjq3JZSKPQb9qvf 6JbgCcch4pAhMuMX8wIWlOdRFqEy1rBZ/dvlbQB2B2foNy27TUdKMQWDg== Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 27.06.22 11:05, Ilpo J=C3=A4rvinen wrote: > On Sat, 25 Jun 2022, Lukas Wunner wrote: >> >> I think what you want to do is amend uart_get_rs485_mode() to set >> SER_RS485_TERMINATE_BUS in port->rs485_supported_flags if a GPIO >> was found in the DT. Instead of the change proposed above. Agreed. > > That seems appropriate (and is a fix). > > What makes it a bit complicated though is that it's a pointer currently > and what it points to is shared per driver (besides being const): > const struct serial_rs485 *rs485_supported; > While it could be embedded into uart_port, there's the .padding which we > might not want to bloat uart_port with. Perhaps create non-uapi struct > kserial_rs485 w/o .padding and add static_assert()s to ensure the > layout is identical to serial_rs485? > > This seems to be indeed the cleanest solution. Regards, Lino From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1BDEECCA47B for ; Sat, 2 Jul 2022 16:52:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=T1bZAh5nyBYXK+zCAoae7zC9N5Eqe0xJNnLJvjVxltg=; b=fb1K4dwE/lLNX0 f/0bjAPCs9kA6n43vPsgLTA5nbfvSw3mT5W5Xr4vskIEUPzQYPmJZ3tx99+CPvS9FrOCzQoIRAXet dUwwrf/8voMJpAtitnkTt/jtUCM2TtDU7yWgBGG3d2sprGP/lORqj5Fu/CwuvOFbojGNwUv6BK2Pl SeGAZXGP2hJbKgmD1r6vlUW2MdhLHOac6OyGqKXLG2ezpy2cCMSX67H7YDYF8odQBaMUN5pMmN5n8 6XqlZRARvEf6qqEnqp1zVdPZ8+2l03E4avLxjC/8fe1ffY8qzeTErnNRRk42yLChn1i1ZqXr/N+4E 2FKDht9STIF1ZtQvVpew==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o7gLB-00AXE0-2T; Sat, 02 Jul 2022 16:51:29 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o7gL8-00AXDM-MB for linux-arm-kernel@bombadil.infradead.org; Sat, 02 Jul 2022 16:51:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID: Sender:Reply-To:Content-ID:Content-Description; bh=9K4t3NzO4knRH25xLJmy+wPuzCr/qKWhasH44FPaStQ=; b=EtnWbp1o8QrXaJynSi8q5YU8g4 +dOai/+u7BgAcKbWsUzO++7V42tTfSYXf6YWzjA7hkAKJNdRL/rUNxDFyqSLWMG6PZhikrGjgFAZ+ 6Fu2ZeGsarhXKiz4DG3yW1Bb7+CM2VlbWc70yjo4u2HqJkf+uhXAJL0CqWZ6dJ/UtxJNaEipVI7+G M1vJTST8k4m2TCUDmAJXq6UWmWRoN6DCO5ArOvJBNMO4MELn1dA9288GNjEy8D6ZywAyIdaZfFhcu pOCA5+S2MATGI5Dlc2Ktmj+j6IrOHDbg9fWLQXvGIDmgsP5N6boIO+XaqrSt5mi/YcFG1cxquJvXZ UIN+tQNQ==; Received: from mout.gmx.net ([212.227.15.18]) by desiato.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o7gL1-00GH3X-R3 for linux-arm-kernel@lists.infradead.org; Sat, 02 Jul 2022 16:51:22 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1656780663; bh=mUyhruXIhmuUViMeDFbRQp4XSTkRwYDiNt+WsCvGuuM=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=IAv5TECA6DaGDanu4F2UESXF9U4moCqIxQji5xOqiyBEcqkHYY6nfGeJy9vMUCEeH CEo2AWjmKthmW2XDuFNd+PGaGDVhDJnJ9Ewwb8ZthEs4qEX3YEQb28EWUBVY3Reh6I /Y8bOrvSyWmXh7j1b7mgqHSSYAPko34986YQpylI= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.0.69] ([46.223.3.210]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MMofW-1nr6qx0112-00Ik4J; Sat, 02 Jul 2022 18:51:03 +0200 Message-ID: Date: Sat, 2 Jul 2022 18:50:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH 1/8] serial: core: only get RS485 termination gpio if supported Content-Language: en-US To: =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= , Lukas Wunner Cc: Greg Kroah-Hartman , Jiri Slaby , robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, Andy Shevchenko , vz@mleia.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-serial , LKML , p.rosenberger@kunbus.com, Lino Sanfilippo References: <20220622154659.8710-1-LinoSanfilippo@gmx.de> <20220622154659.8710-2-LinoSanfilippo@gmx.de> <20220625194951.GA2879@wunner.de> From: Lino Sanfilippo In-Reply-To: X-Provags-ID: V03:K1:KV+4xPvzh0c7cByKeFFk/pLcKFJ1ZO2uSNEEgxRyg3FJs6W66M9 49CwH2GFa49hMrEpMPhGlXwgvKHiWeWkhZCbzE+fUo+oFH8iEd8Zl2HWpS2wXZPhVHdaqJs leXq7fpqRzpmIyK8+yZCGLeZYwSRvY5RB5KFL8igB7oZ6m7qLsVtxAlB0ufkvllsNyh2x7L gYhtSjBVzSb9SMohfo1eg== X-UI-Out-Filterresults: notjunk:1;V03:K0:gK6ld9oDcxA=:ClhnIwM/mA5AvWRKq/whT4 vlqN9ckew6KPdywCugY9q9WBB1eWTfDTaHJcW3F9ZUHgIEqOk+XzSLwP7KT3GReWRQji/VKnw B3u0LmhLwS+Ci88M0h4Ta9LxE5zfxaFG/Sw+1964WrE5HYDkFr0k8IKNNukSvYjPGQFgdfkX3 c1QwcRCCNhOJv1wpdAHtk61guvU7OtENaYGZnwlIrW6VRDiKOUjAcU4TBiwmVcIn2dARxFtyn 6e7gS9RBXJbJdvUGzLvYOBNC10egN/hP4tn7tQd9pi0jaxKl766tgH0vYZlYVNH/saqde/nDW W4PTZBlp1SHkYcAwDpqBNTEOGAar5EZ64jOLBf4kE0Fry6qQsLJ/22MDXKpyfWw9/X4HVY4Ru oNoxRN+p6moAVOAdvHwU8ziXYmVNTS8MgACHc15vr0R3jTasfznn8S0NPrjlYmoeDxCERlNBu 0/NAxzslsTmAij2gD4ZstA98YC/mZm6cF5N1eIucf/ehWzRmaWpxmpLRlvSQZiXwwEQiVdZAk 7Us7+SpGyeEesQTNCEpUM9U3Pkz7v082PoIcrUp//9130HnghuozMgfJyUUhgfw/kSYvSwOWH sZCeaXdVzuCycsaorpb3ehKi2wzzy4dPjVmQpVE5erKV1zi3xaBr6+bRyrF0hM3sZ1jnp9BHF FOEgi3VrXFjUPtRV6x717bHt0jz2SK4NQwgI5k7609GYIWUzHZPbz84kv7Jyp6BUEMs+jO3rb gHdjWCWuknMkJWVTo4Rr8QQuHCL0627C6YyH6wT9qGtBYFHZdACwmMyautyW8XuSa/WNxxxVi WltMwdTyclzPTY4DKU86Sb9i03GETuX93OmB41XMljBbh8OKo8qXqY8xvC93eCwp9pHLlphi8 x67OU+iEmIF+80BOZWSIOUkGN7jlkRStF+ncNEgoosBHvLV9aZFb1PIhKMKkYNEEEGd0fVZyP hbNRyrtFv9lKEjI88QHKD8xhY2qbGcb/2N784nwVDKof4Krg7fSOcXOTzfx/jOYsOzh5pqp3q RkfRe5xMAXArhsO3S3oAJGlbnxP3OM3cD4LDpbh0Meg5KEVsHtG82Y11d5cjq3JZSKPQb9qvf 6JbgCcch4pAhMuMX8wIWlOdRFqEy1rBZ/dvlbQB2B2foNy27TUdKMQWDg== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220702_175120_750486_C50A70DA X-CRM114-Status: GOOD ( 12.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGksCgpPbiAyNy4wNi4yMiAxMTowNSwgSWxwbyBKw6RydmluZW4gd3JvdGU6Cj4gT24gU2F0LCAy NSBKdW4gMjAyMiwgTHVrYXMgV3VubmVyIHdyb3RlOgoKPj4KPj4gSSB0aGluayB3aGF0IHlvdSB3 YW50IHRvIGRvIGlzIGFtZW5kIHVhcnRfZ2V0X3JzNDg1X21vZGUoKSB0byBzZXQKPj4gU0VSX1JT NDg1X1RFUk1JTkFURV9CVVMgaW4gcG9ydC0+cnM0ODVfc3VwcG9ydGVkX2ZsYWdzIGlmIGEgR1BJ Two+PiB3YXMgZm91bmQgaW4gdGhlIERULiAgSW5zdGVhZCBvZiB0aGUgY2hhbmdlIHByb3Bvc2Vk IGFib3ZlLgoKQWdyZWVkLgoKPgo+IFRoYXQgc2VlbXMgYXBwcm9wcmlhdGUgKGFuZCBpcyBhIGZp eCkuCj4KPiBXaGF0IG1ha2VzIGl0IGEgYml0IGNvbXBsaWNhdGVkIHRob3VnaCBpcyB0aGF0IGl0 J3MgYSBwb2ludGVyIGN1cnJlbnRseQo+IGFuZCB3aGF0IGl0IHBvaW50cyB0byBpcyBzaGFyZWQg cGVyIGRyaXZlciAoYmVzaWRlcyBiZWluZyBjb25zdCk6Cj4gCWNvbnN0IHN0cnVjdCBzZXJpYWxf cnM0ODUgICAgICAgKnJzNDg1X3N1cHBvcnRlZDsKPiBXaGlsZSBpdCBjb3VsZCBiZSBlbWJlZGRl ZCBpbnRvIHVhcnRfcG9ydCwgdGhlcmUncyB0aGUgLnBhZGRpbmcgd2hpY2ggd2UKPiBtaWdodCBu b3Qgd2FudCB0byBibG9hdCB1YXJ0X3BvcnQgd2l0aC4gUGVyaGFwcyBjcmVhdGUgbm9uLXVhcGkg c3RydWN0Cj4ga3NlcmlhbF9yczQ4NSB3L28gLnBhZGRpbmcgYW5kIGFkZCBzdGF0aWNfYXNzZXJ0 KClzIHRvIGVuc3VyZSB0aGUKPiBsYXlvdXQgaXMgaWRlbnRpY2FsIHRvIHNlcmlhbF9yczQ4NT8K Pgo+CgpUaGlzIHNlZW1zIHRvIGJlIGluZGVlZCB0aGUgY2xlYW5lc3Qgc29sdXRpb24uCgpSZWdh cmRzLApMaW5vCgoKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3Rz LmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5m by9saW51eC1hcm0ta2VybmVsCg==