From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18A4BC433E0 for ; Mon, 8 Jun 2020 15:44:51 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D66E9206C3 for ; Mon, 8 Jun 2020 15:44:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="I1TYV2Sf" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D66E9206C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:33318 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jiJxC-0007xJ-5X for qemu-devel@archiver.kernel.org; Mon, 08 Jun 2020 11:44:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35910) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jiJwT-0007N7-7J for qemu-devel@nongnu.org; Mon, 08 Jun 2020 11:44:05 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:27159 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jiJwR-0004Tq-K7 for qemu-devel@nongnu.org; Mon, 08 Jun 2020 11:44:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591631042; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EvSYoXdzoLdCSX8de1LoyV3aVBmTk8/biD1L6amUE+Y=; b=I1TYV2SfmOELo0j9oRfl/bEAxQzJOwulyGdevIKT+UheDJzRNpKVCUWWAXhALRj5dDDEvG z5bFn1ok3pvITarCiSOhV/hd4NwxCalESmg9v2fqtzPx0H7FV/KTeoJPfEu+aBloX5qaNk wk5iowA5dCDtQ4aXZ8yCkzRMhONfh+E= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-187-u16TVxyNMt-SfOkuHel_RQ-1; Mon, 08 Jun 2020 11:43:53 -0400 X-MC-Unique: u16TVxyNMt-SfOkuHel_RQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 448331B18BC0; Mon, 8 Jun 2020 15:43:52 +0000 (UTC) Received: from [10.3.113.22] (ovpn-113-22.phx2.redhat.com [10.3.113.22]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A4E2F60C47; Mon, 8 Jun 2020 15:43:48 +0000 (UTC) Subject: Re: [PATCH] or1k: Fix compilation hiccup To: Markus Armbruster , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= References: <20200526185132.1652355-1-eblake@redhat.com> <87eeqx9alv.fsf@dusky.pond.sub.org> <873676ksbb.fsf@dusky.pond.sub.org> <09123e95-b1c1-be7b-1aa8-f68f99417b28@redhat.com> <87tuzlj4uk.fsf@dusky.pond.sub.org> From: Eric Blake Organization: Red Hat, Inc. Message-ID: Date: Mon, 8 Jun 2020 10:43:48 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <87tuzlj4uk.fsf@dusky.pond.sub.org> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=207.211.31.120; envelope-from=eblake@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/08 05:40:56 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Jia Liu , QEMU Trivial , QEMU Developers , Christophe de Dinechin , Stafford Horne Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 6/8/20 4:15 AM, Markus Armbruster wrote: >>>>> Yes: openrisc_sim_machine_init() sets mc->max_cpus = 2. >>>>> My suggestion of adding an assert() is essentially telling the >>>>> compiler that indeed smp_cpus must always be in the range [1,2], >>>>> which we can tell but it can't. >>>> >>>> Do we have a proper patch for this on the list? >>> >>> Apparently not. >>> >>> Philippe did try Peter's suggestion, found it works, but then posted it >>> only to Launchpad. Philippe, please post to the list, so we can finally >>> get this fixed. >> >> Sorry since it was Eric finding, I didn't understood I had to post it. >> Will do. > > You didn't *have* to, but it'll help if you do :) Now at https://lists.gnu.org/archive/html/qemu-devel/2020-06/msg01779.html -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org