Re: Bug in f2fs-tools-1.12.0

[Perfect Gentleman <perfect007gentleman@gmail.com>]

Hi Chao

With that patch fsck.f2fs works for  RO-partition with -f option.

  ~ $ sudo mount -o remount,ro /dev/sda1

  ~ $ sudo fsck.f2fs -a /dev/sda1
Info: Fix the reported corruption.
Info: Mounted device!
Info: Check FS only due to RO
         Error: Failed to open the device!

~ $ sudo fsck.f2fs -af /dev/sda1
Info: Fix the reported corruption.
Info: Force to fix corruption
Info: Mounted device!
Info: Check FS only due to RO
Info: [/dev/sda1] Disk Model: SAMSUNG MZ7WD240
Info: Segments per section = 1
Info: Sections per zone = 1
Info: sector size = 512
Info: total sectors = 468860047 (228935 MB)
Info: MKFS version
   "Linux version 4.16.6-gentoo (root@kubuntu) (gcc version 7.3.0 
(Gentoo 7.3.0-r1 p1.1)) #1 ZEN SMP PREEMPT Tue May 1 18:28:05 +07 2018"
Info: FSCK version
   from "Linux version 4.19.4-gentoo (root@HOST) (gcc version 8.2.0 
(Gentoo 8.2.0-r4 p1.5)) #1 ZEN SMP PREEMPT Fri Nov 23 22:15:59 +07 2018"
     to "Linux version 4.19.4-gentoo (root@HOST) (gcc version 8.2.0 
(Gentoo 8.2.0-r4 p1.5)) #1 ZEN SMP PREEMPT Fri Nov 23 22:15:59 +07 2018"
Info: superblock features = 0 :
Info: superblock encrypt level = 0, salt = 00000000000000000000000000000000
Info: total FS sectors = 468860040 (228935 MB)
Info: CKPT version = 40e50ae1
Info: Checked valid nat_bits in checkpoint
Info: checkpoint state = c5 :  nat_bits crc compacted_summary unmount

[FSCK] Unreachable nat entries                        [Ok..] [0x0]
[FSCK] SIT valid block bitmap checking                [Ok..]
[FSCK] Hard link checking for regular file            [Ok..] [0x0]
[FSCK] valid_block_count matching with CP             [Ok..] [0x334ce10]
[FSCK] valid_node_count matcing with CP (de lookup)   [Ok..] [0x1fe41]
[FSCK] valid_node_count matcing with CP (nat lookup)  [Ok..] [0x1fe41]
[FSCK] valid_inode_count matched with CP              [Ok..] [0x12fb1]
[FSCK] free segment_count matched with CP             [Ok..] [0x41f0]
[FSCK] next block offset is free                      [Ok..]
[FSCK] fixing SIT types
[FSCK] other corrupted bugs                           [Ok..]

Done.

Regards

On 11/26/18 8:35 PM, Chao Yu wrote:
> Hi Perfect Gentleman,
>
> On 2018-11-26 19:11, Perfect Gentleman wrote:
>> Hi Chao
>>
>> What patch do you mean?
> I mean
>
> https://git.kernel.org/pub/scm/linux/kernel/git/chao/f2fs-tools.git/commit/?h=dev-test&id=a6160c3e21f43b89b49802cc4a956d1c4b65ae44
>
> Thanks,
>
>> Redards
>>
>> P.S. It's reply to all :)
>>
>> On 11/26/18 5:52 PM, Chao Yu wrote:
>>> Hi Perfect Gentleman,
>>>
>>> Thanks for the report.
>>>
>>> On 2018/11/25 13:24, Perfect Gentleman wrote:
>>>> Hi f2fs-team,
>>>>
>>>> there is bug: fsck.f2fs cannot check read-only filesystem. But 1.11.0
>>>> can do that.
>>>>
>>>> fsck              |Info: Fix the reported corruption.
>>>> fsck              |Info: Mounted device!
>>>> fsck              |Info: Check FS only due to RO
>>>> fsck              |Error: Failed to open the device!
>>> I guess this is due to below commit, which stop opening device in
>>> f2fs-tools if the device has already been opened by other one, like mount.
>>>
>>> https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs-tools.git/commit/?h=dev-test&id=eb9d8037ed3b37a647d514470f1a1df91daedb64
>>>
>>>
>>> I tried e2fsprogs, w/o -f option, the result is the same:
>>>
>>> fsck 1.44.4 (18-Aug-2018)
>>> e2fsck 1.44.4 (18-Aug-2018)
>>> /dev/zram0 is mounted.
>>> e2fsck: Cannot continue, aborting.
>>>
>>> But still we can trigger forced fsck.ext4 by using -f option.
>>>
>>> Could you have a try with following patch?
>>>
>>> [PATCH] fsck.f2fs: allow to fsck readonly image w/ -f option
>>>
>>> Thanks,
>>>
>>>> fsck              | * Filesystems couldn't be fixed
>>>>     [ !! ]
>>>> fsck              | * ERROR: fsck failed to start
>>>>
>>>> Regards,
>>>> Alex
>>>>
>>>>
>>>>
>>>> _______________________________________________
>>>> Linux-f2fs-devel mailing list
>>>> Linux-f2fs-devel@lists.sourceforge.net
>>>> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
>>>>
>>
>> _______________________________________________
>> Linux-f2fs-devel mailing list
>> Linux-f2fs-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel