From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932552AbcG1Pgb (ORCPT ); Thu, 28 Jul 2016 11:36:31 -0400 Received: from esa2.dell-outbound.iphmx.com ([68.232.149.220]:60607 "EHLO esa2.dell-outbound.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932411AbcG1PgY (ORCPT ); Thu, 28 Jul 2016 11:36:24 -0400 DomainKey-Signature: s=smtpout; d=dell.com; c=simple; q=dns; h=Received:X-LoopCount0:X-IronPort-AV:From:To:CC:Subject: Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language: X-MS-Has-Attach:X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader:x-originating-ip: Content-Type:Content-Transfer-Encoding:MIME-Version: Return-Path; b=1JZeNt4OsIJ7/Hzn5Vqd6HZN9XN7G79XcjCPWdQ+lvgIkhAKV2rCv8ep O78LMuQYRLAdTbprA9YA9C2/WtuCpjco/yz6bR/Ds1sxxsqDeRz28DdyQ delVtJXZWwtRdcZH8bmQdKeccjJspCgb2ckJX7CZbLUl73WwNjCEvox02 A=; X-LoopCount0: from 10.175.216.250 X-IronPort-AV: E=Sophos;i="5.28,434,1464670800"; d="scan'208";a="826698429" From: To: CC: , , Subject: RE: [PATCH] dell-wmi: Add events created by Dell Rugged 2-in-1s Thread-Topic: [PATCH] dell-wmi: Add events created by Dell Rugged 2-in-1s Thread-Index: AQHR5FPfN9AkRB1xfUWyNEdZMBDLaaAsF/iAgAAi1gCAADfXN4AAWgmA///bNmCAAGpuAIAA7sPQ Date: Thu, 28 Jul 2016 15:36:19 +0000 Message-ID: References: <1469217684-6643-1-git-send-email-mario_limonciello@dell.com> <201607271805.57123@pali> <13ec06e37e284263b6bf4fe4a6a04a78@ausx13mpc120.AMER.DELL.COM> <201607272215.12385@pali> In-Reply-To: <201607272215.12385@pali> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.208.89.195] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u6SFaZib001673 > > > > > > Anyway, what is "Wifi Catcher"? HW switch buttton which > > > enable/disable wifi? Or something else? > > > > Wifi catcher was a special hardware switch slider switch. When the > > machine was turned in S3 the sliding the switch beyond the on > > position would scan for available wifi networks and light up an LED > > if some from your predefined list were found. > > > > When the machine was on, it would open up the applet that let you > > configure the behavior for the switch in S3. > > Hm... maybe it better fit KEY_WLAN then? Just speculation. > Yeah, I think that's a good fit. I'll adjust that when I resubmit the rugged patch shortly. > > > > So there should be no "real" clash here. > > > > > > Problem can be in future. This driver is unified for all Dell > > > products with wmi interface and so future product could do some > > > nasty things... > > > > I agree with Darren here. > > > > At least on Dell side we're creating new codes for "new" buttons and > > the limitation is really on the kernel side for how many KEY_PROG# > > or similar functions they can be re-assigned to. > > Ok. > > > Maybe it's time to think of another way to get this information to > > userspace rather that always translating them into key codes? > > If event is generated by pressing key, button or hw switch, then input > key is correct way. If there is no KEY define which fit for new vendor > hw button, then I think we should start discussion with input subsystem > how to handle such situation. > > > There's a lot that are marked as KE_IGNORE because the kernel can't > > do anything interesting with them as no 1-1 mapping exists to a > > keycode. > > Most marked as KE_IGNORE are because duplicate event is sent via > keyboard controller or via other subsystem (e.g. rfkill). > > But events which are not keys or buttons should not be sent via input > devices. At least I think it is against usage of input devices. > > Events like "battery was removed" or "keyboard backlight was changed" or > "battery lifetime decreased under X %" can be useful for userspace > applications. I agree. But I think we do not have any subsystem or > interface for sending them from kernel to userspace. > > If we start talking about creating interface for it, I would rather see > something more generic, not Dell-only specific or created specially for > Dell machines which will not fit for others... > I don't think it needs to be Dell specific, I'm sure plenty of other platform drivers would use it too. If this interface is created we can figure out which ones really are useful notifications to userspace. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Subject: RE: [PATCH] dell-wmi: Add events created by Dell Rugged 2-in-1s Date: Thu, 28 Jul 2016 15:36:19 +0000 Message-ID: References: <1469217684-6643-1-git-send-email-mario_limonciello@dell.com> <201607271805.57123@pali> <13ec06e37e284263b6bf4fe4a6a04a78@ausx13mpc120.AMER.DELL.COM> <201607272215.12385@pali> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <201607272215.12385@pali> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: pali.rohar@gmail.com Cc: dvhart@infradead.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org List-Id: platform-driver-x86.vger.kernel.org PiA+ID4NCj4gPiA+IEFueXdheSwgd2hhdCBpcyAiV2lmaSBDYXRjaGVyIj8gSFcgc3dpdGNoIGJ1 dHR0b24gd2hpY2gNCj4gPiA+IGVuYWJsZS9kaXNhYmxlIHdpZmk/IE9yIHNvbWV0aGluZyBlbHNl Pw0KPiA+DQo+ID4gV2lmaSBjYXRjaGVyIHdhcyBhIHNwZWNpYWwgaGFyZHdhcmUgc3dpdGNoIHNs aWRlciBzd2l0Y2guICBXaGVuIHRoZQ0KPiA+IG1hY2hpbmUgd2FzIHR1cm5lZCBpbiBTMyB0aGUg c2xpZGluZyB0aGUgc3dpdGNoIGJleW9uZCB0aGUgb24NCj4gPiBwb3NpdGlvbiB3b3VsZCBzY2Fu IGZvciBhdmFpbGFibGUgd2lmaSBuZXR3b3JrcyBhbmQgbGlnaHQgdXAgYW4gTEVEDQo+ID4gaWYg c29tZSBmcm9tIHlvdXIgcHJlZGVmaW5lZCBsaXN0IHdlcmUgZm91bmQuDQo+ID4NCj4gPiBXaGVu IHRoZSBtYWNoaW5lIHdhcyBvbiwgaXQgd291bGQgb3BlbiB1cCB0aGUgYXBwbGV0IHRoYXQgbGV0 IHlvdQ0KPiA+IGNvbmZpZ3VyZSB0aGUgYmVoYXZpb3IgZm9yIHRoZSBzd2l0Y2ggaW4gUzMuDQo+ IA0KPiBIbS4uLiBtYXliZSBpdCBiZXR0ZXIgZml0IEtFWV9XTEFOIHRoZW4/IEp1c3Qgc3BlY3Vs YXRpb24uDQo+IA0KDQpZZWFoLCBJIHRoaW5rIHRoYXQncyBhIGdvb2QgZml0LiAgSSdsbCBhZGp1 c3QgdGhhdCB3aGVuIEkgcmVzdWJtaXQgdGhlDQpydWdnZWQgcGF0Y2ggc2hvcnRseS4NCg0KPiA+ ID4gPiBTbyB0aGVyZSBzaG91bGQgYmUgbm8gInJlYWwiIGNsYXNoIGhlcmUuDQo+ID4gPg0KPiA+ ID4gUHJvYmxlbSBjYW4gYmUgaW4gZnV0dXJlLiBUaGlzIGRyaXZlciBpcyB1bmlmaWVkIGZvciBh bGwgRGVsbA0KPiA+ID4gcHJvZHVjdHMgd2l0aCB3bWkgaW50ZXJmYWNlIGFuZCBzbyBmdXR1cmUg cHJvZHVjdCBjb3VsZCBkbyBzb21lDQo+ID4gPiBuYXN0eSB0aGluZ3MuLi4NCj4gPg0KPiA+IEkg YWdyZWUgd2l0aCBEYXJyZW4gaGVyZS4NCj4gPg0KPiA+IEF0IGxlYXN0IG9uIERlbGwgc2lkZSB3 ZSdyZSBjcmVhdGluZyBuZXcgY29kZXMgZm9yICJuZXciIGJ1dHRvbnMgYW5kDQo+ID4gdGhlIGxp bWl0YXRpb24gaXMgcmVhbGx5IG9uIHRoZSBrZXJuZWwgc2lkZSBmb3IgaG93IG1hbnkgS0VZX1BS T0cjDQo+ID4gb3Igc2ltaWxhciBmdW5jdGlvbnMgdGhleSBjYW4gYmUgcmUtYXNzaWduZWQgdG8u DQo+IA0KPiBPay4NCj4gDQo+ID4gTWF5YmUgaXQncyB0aW1lIHRvIHRoaW5rIG9mIGFub3RoZXIg d2F5IHRvIGdldCB0aGlzIGluZm9ybWF0aW9uIHRvDQo+ID4gdXNlcnNwYWNlIHJhdGhlciB0aGF0 IGFsd2F5cyB0cmFuc2xhdGluZyB0aGVtIGludG8ga2V5IGNvZGVzPw0KPiANCj4gSWYgZXZlbnQg aXMgZ2VuZXJhdGVkIGJ5IHByZXNzaW5nIGtleSwgYnV0dG9uIG9yIGh3IHN3aXRjaCwgdGhlbiBp bnB1dA0KPiBrZXkgaXMgY29ycmVjdCB3YXkuIElmIHRoZXJlIGlzIG5vIEtFWSBkZWZpbmUgd2hp Y2ggZml0IGZvciBuZXcgdmVuZG9yDQo+IGh3IGJ1dHRvbiwgdGhlbiBJIHRoaW5rIHdlIHNob3Vs ZCBzdGFydCBkaXNjdXNzaW9uIHdpdGggaW5wdXQgc3Vic3lzdGVtDQo+IGhvdyB0byBoYW5kbGUg c3VjaCBzaXR1YXRpb24uDQo+IA0KPiA+IFRoZXJlJ3MgYSBsb3QgdGhhdCBhcmUgbWFya2VkIGFz IEtFX0lHTk9SRSBiZWNhdXNlIHRoZSBrZXJuZWwgY2FuJ3QNCj4gPiBkbyBhbnl0aGluZyBpbnRl cmVzdGluZyB3aXRoIHRoZW0gYXMgbm8gMS0xIG1hcHBpbmcgZXhpc3RzIHRvIGENCj4gPiBrZXlj b2RlLg0KPiANCj4gTW9zdCBtYXJrZWQgYXMgS0VfSUdOT1JFIGFyZSBiZWNhdXNlIGR1cGxpY2F0 ZSBldmVudCBpcyBzZW50IHZpYQ0KPiBrZXlib2FyZCBjb250cm9sbGVyIG9yIHZpYSBvdGhlciBz dWJzeXN0ZW0gKGUuZy4gcmZraWxsKS4NCj4gDQo+IEJ1dCBldmVudHMgd2hpY2ggYXJlIG5vdCBr ZXlzIG9yIGJ1dHRvbnMgc2hvdWxkIG5vdCBiZSBzZW50IHZpYSBpbnB1dA0KPiBkZXZpY2VzLiBB dCBsZWFzdCBJIHRoaW5rIGl0IGlzIGFnYWluc3QgdXNhZ2Ugb2YgaW5wdXQgZGV2aWNlcy4NCj4g DQo+IEV2ZW50cyBsaWtlICJiYXR0ZXJ5IHdhcyByZW1vdmVkIiBvciAia2V5Ym9hcmQgYmFja2xp Z2h0IHdhcyBjaGFuZ2VkIiBvcg0KPiAiYmF0dGVyeSBsaWZldGltZSBkZWNyZWFzZWQgdW5kZXIg WCAlIiBjYW4gYmUgdXNlZnVsIGZvciB1c2Vyc3BhY2UNCj4gYXBwbGljYXRpb25zLiBJIGFncmVl LiBCdXQgSSB0aGluayB3ZSBkbyBub3QgaGF2ZSBhbnkgc3Vic3lzdGVtIG9yDQo+IGludGVyZmFj ZSBmb3Igc2VuZGluZyB0aGVtIGZyb20ga2VybmVsIHRvIHVzZXJzcGFjZS4NCj4gDQo+IElmIHdl IHN0YXJ0IHRhbGtpbmcgYWJvdXQgY3JlYXRpbmcgaW50ZXJmYWNlIGZvciBpdCwgSSB3b3VsZCBy YXRoZXIgc2VlDQo+IHNvbWV0aGluZyBtb3JlIGdlbmVyaWMsIG5vdCBEZWxsLW9ubHkgc3BlY2lm aWMgb3IgY3JlYXRlZCBzcGVjaWFsbHkgZm9yDQo+IERlbGwgbWFjaGluZXMgd2hpY2ggd2lsbCBu b3QgZml0IGZvciBvdGhlcnMuLi4NCj4gDQoNCkkgZG9uJ3QgdGhpbmsgaXQgbmVlZHMgdG8gYmUg RGVsbCBzcGVjaWZpYywgSSdtIHN1cmUgcGxlbnR5IG9mIG90aGVyIHBsYXRmb3JtDQpkcml2ZXJz IHdvdWxkIHVzZSBpdCB0b28uDQoNCklmIHRoaXMgaW50ZXJmYWNlIGlzIGNyZWF0ZWQgd2UgY2Fu IGZpZ3VyZSBvdXQgd2hpY2ggb25lcyByZWFsbHkgYXJlIHVzZWZ1bA0Kbm90aWZpY2F0aW9ucyB0 byB1c2Vyc3BhY2UuDQoNCg==