From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1lCvpU-0006YT-Db for mharc-grub-devel@gnu.org; Thu, 18 Feb 2021 21:47:40 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35784) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lCvpQ-0006RX-8e for grub-devel@gnu.org; Thu, 18 Feb 2021 21:47:37 -0500 Received: from mail-qk1-x729.google.com ([2607:f8b0:4864:20::729]:46989) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lCvpL-00009u-VC for grub-devel@gnu.org; Thu, 18 Feb 2021 21:47:36 -0500 Received: by mail-qk1-x729.google.com with SMTP id w19so4280751qki.13 for ; Thu, 18 Feb 2021 18:47:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficientek-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9TCXLzmBC+tIFpmtbQyreAvLwn4VOzaH8ZP4OKhOKhw=; b=fKOGmNP9r5vxkv3LFvOGUN622BQyvGkTlzepTw1cXZL5kru5tVsvQqJ50zwgDT5Ri4 Q6aP0WuqveonVyYBRiUgqBsrl7lkla1nD9Yyl2LtAxFnl4wQvYIjR16EWdbANOFngOEC lobk1rDy3CVRvrhU0v1/zfIEuwfH4TWUt2i/tH6PL2TMjNKCufLF+Upku5Cc0U+bnOJI NmWnCJhEFRBVRz6181HnlG1zc9GMXRv7Lzn0+BWK8igTpiJBmqS4flNRiLfqOzXhJ7O1 G4vVQ3lxGVmwK4VrTBbFWVKq4QAQrq0YG85D62SvsnWTkZH+FcxP0LWzVP//aGZM/9Q6 odIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9TCXLzmBC+tIFpmtbQyreAvLwn4VOzaH8ZP4OKhOKhw=; b=AOCsiVZisukNiUEEGSVvtjcdZIMRJGRk5HqsowP9jg8O9yNS0LHscJSyS4cLSqb43M ETAvQosDnRprrDeaDSgwGg2lFWIOQNRnAUlGtk77EVXMdmh+YwTKnLqnsW/NFthdHRoD kHbFs0REWKk7fxJN7EybAW2HHNA523imkl4idIvvI+XdWFxyKkR80jhhXHhgWGPXnSVK 09QtBDtYpgHvWNmb+mOGG3JhNQVOw9m5OC8diC2QizZccXVStT/swjGeVGCSOPe7CUuL BAj4QuITPslswT0OFrm16gDYRWeOtwcFjoa3tBws2KoiH7ko8Ey5yQ2BV6C94BLUYCVd jVNA== X-Gm-Message-State: AOAM532ATQ/MBuVU3FaQiqC0r5B/v2hsKcdDuf9v5COCc295dOCGzEJH 7gkc2AlsgdEaivjkFDMbnUb3jyl1NA2AoA== X-Google-Smtp-Source: ABdhPJwudOO8x47BT/jGhceKTHVFCCf6egA3BvzLI+EE2Z35vnH+JiM0JuoqLYJ9ZEkP4u8zcxApSQ== X-Received: by 2002:a37:4c09:: with SMTP id z9mr7446632qka.9.1613702850685; Thu, 18 Feb 2021 18:47:30 -0800 (PST) Received: from localhost.localdomain ([2605:a601:aac5:3700:c323:c101:d96b:34f1]) by smtp.gmail.com with ESMTPSA id y2sm5341515qkj.56.2021.02.18.18.47.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Feb 2021 18:47:30 -0800 (PST) From: Glenn Washburn To: grub-devel@gnu.org Cc: Daniel Kiper , Glenn Washburn Subject: [PATCH v4 13/13] error: Do compile-time format string checking on grub_error Date: Thu, 18 Feb 2021 20:47:14 -0600 Message-Id: X-Mailer: git-send-email 2.27.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::729; envelope-from=development@efficientek.com; helo=mail-qk1-x729.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Feb 2021 02:47:37 -0000 This should help prevent format string errorsand thus improve the quality of error reporting. Signed-off-by: Glenn Washburn --- include/grub/err.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/grub/err.h b/include/grub/err.h index 24ba9f5f5..b08d5d0de 100644 --- a/include/grub/err.h +++ b/include/grub/err.h @@ -85,7 +85,8 @@ struct grub_error_saved extern grub_err_t EXPORT_VAR(grub_errno); extern char EXPORT_VAR(grub_errmsg)[GRUB_MAX_ERRMSG]; -grub_err_t EXPORT_FUNC(grub_error) (grub_err_t n, const char *fmt, ...); +grub_err_t EXPORT_FUNC(grub_error) (grub_err_t n, const char *fmt, ...) + __attribute__ ((format (GNU_PRINTF, 2, 3))); void EXPORT_FUNC(grub_fatal) (const char *fmt, ...) __attribute__ ((noreturn)); void EXPORT_FUNC(grub_error_push) (void); int EXPORT_FUNC(grub_error_pop) (void); -- 2.27.0