From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jacek Anaszewski Subject: Re: [PATCH v2 6/6] leds: netdev trigger: allow setting initial values in device tree Date: Thu, 14 Mar 2019 16:36:45 +0100 Message-ID: References: <20190313202615.22883-1-linux@rasmusvillemoes.dk> <20190314140619.3309-1-linux@rasmusvillemoes.dk> <20190314140619.3309-7-linux@rasmusvillemoes.dk> <742bd6b2-0a11-858e-d727-204b0313265e@gmail.com> <10d65087-2ae5-8ddf-e9be-02c9341b452b@rasmusvillemoes.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <10d65087-2ae5-8ddf-e9be-02c9341b452b@rasmusvillemoes.dk> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Rasmus Villemoes , Pavel Machek , =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= Cc: LKML , linux-leds@vger.kernel.org, devicetree@vger.kernel.org List-Id: linux-leds@vger.kernel.org On 3/14/19 4:05 PM, Rasmus Villemoes wrote: > On 14/03/2019 15.24, Jacek Anaszewski wrote: >> Rasmus, >> >> Thank you for the update. >> Still, there is one thing to improve. >> > >>>   static int netdev_trig_activate(struct led_classdev *led_cdev) >>>   { >>>       struct led_netdev_data *trigger_data; >>> @@ -423,6 +451,8 @@ static int netdev_trig_activate(struct >>> led_classdev *led_cdev) >>>       trigger_data->mode = 0; >>>       atomic_set(&trigger_data->interval, msecs_to_jiffies(50)); >>>       trigger_data->last_activity = 0; >>> +    if (led_cdev->flags & LED_INIT_DEFAULT_TRIGGER) >>> +        netdev_trig_of_init(led_cdev, trigger_data); >> >> We don't necessarily want OF settings to be used for initialization on >> each LED trigger activation for the LED class device, but only on the >> first one. That's why the triggers using this flags clean it here: >> >> led_cdev->flags &= ~LED_INIT_DEFAULT_TRIGGER; > > Right, I noticed that pattern, but wondered about it. If this is > supposed to be a general thing, why isn't it just done by the trigger > core after the call of led_trigger_set() in the two places the bit gets > set? I.e. > > led_cdev->flags |= LED_INIT_DEFAULT_TRIGGER; > led_trigger_set(led_cdev, trig); > + led_cdev->flags &= ~LED_INIT_DEFAULT_TRIGGER; > > I can certainly add clearing the flag to my code, just wondering. Good point. It would have to be applied in both led_trigger_set_default() and led_trigger_register(). So you either need to add generic support for clearing the flag (and update the three users) or update your patch alone. -- Best regards, Jacek Anaszewski