From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751564AbeCIXm5 (ORCPT <rfc822;w@1wt.eu>);
        Fri, 9 Mar 2018 18:42:57 -0500
Received: from mail-pl0-f45.google.com ([209.85.160.45]:33177 "EHLO
        mail-pl0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751225AbeCIXmz (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 9 Mar 2018 18:42:55 -0500
X-Google-Smtp-Source: AG47ELtA0GDC2a+VYjJBYFCktw+T/bY77nG3fbbT4Eeb130/qWXmIKjFfZxEywawXsqO1x14tLmkCQ==
Subject: Re: WARNING in __proc_create
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: coreteam@netfilter.org, David Miller <davem@davemloft.net>,
        Florian Westphal <fw@strlen.de>,
        Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
        LKML <linux-kernel@vger.kernel.org>,
        Linux Kernel Network Developers <netdev@vger.kernel.org>,
        netfilter-devel@vger.kernel.org,
        Pablo Neira Ayuso <pablo@netfilter.org>
References: <001a113f2be668a1e9056701e617@google.com>
 <CAM_iQpV+PnGUXEKcSrF7u19NOeLLp0PhDW-DOkEfS+8pLnTgYw@mail.gmail.com>
 <a559bbb6-0db4-2b71-b363-792d88d7eef7@gmail.com>
 <c4b2dca8-f2b9-c187-9ee5-e7c4816848f5@gmail.com>
 <CAM_iQpXLQtaBRBPmcGzUTUhNHiomos4eAvXy7kyrY+uAzpNt3g@mail.gmail.com>
 <5d89ba78-64b4-9c9b-c9f3-c67094343c3f@gmail.com>
 <CAM_iQpXPO_9=sj1DiMRfNmhZkUnCaoJtWw2O82g9AKSYjRFrZA@mail.gmail.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Message-ID: <ddcf91b3-8526-bac5-d2bb-c5a39deeaac1@gmail.com>
Date: Fri, 9 Mar 2018 15:42:53 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.6.0
MIME-Version: 1.0
In-Reply-To: <CAM_iQpXPO_9=sj1DiMRfNmhZkUnCaoJtWw2O82g9AKSYjRFrZA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On 03/09/2018 03:32 PM, Cong Wang wrote:
> On Fri, Mar 9, 2018 at 3:21 PM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
>>
>>
>> On 03/09/2018 03:05 PM, Cong Wang wrote:
>>>
>>>
>>> BTW, the warning itself is all about empty names, so perhaps
>>> it's better to fix them separately.
>>
>>
>> Huh ? You want more syzbot reports ? I do not.
> 
> I always prefer one patch to fix one problem, and, as I already said,
> checking "." and ".." is probably not as trivial as checking empty.
> 
> This why I believe 2 (or more) patches here are better than 1 single
> patch.
> 
> BTW, I don't have any patch, it is so trivial that I don't want to spend
> my time on it.

The trivial patch has been sent, and Florian gave a (very good) feedback.

Then Pablo offered to write a complete patch.

They both had more pressing issues, and quite frankly I also had more 
pressing issues.

I doubt that sending again the simple fix will be accepted by netfilter 
maintainers.